-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KuiContextMenu => EuiContextMenu #17621
KuiContextMenu => EuiContextMenu #17621
Conversation
💔 Build Failed |
084ba77
to
e8f2fee
Compare
@@ -23,6 +23,10 @@ | |||
} | |||
} | |||
|
|||
.euiContextMenuItem { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only thing I'm not sure of. Will see if @snide has any ideas.
💚 Build Succeeded |
I could not rename a panel under "Customize Panel". The "Panel Title" input did not update when typed in. Everything else worked great. |
e8f2fee
to
a209213
Compare
Rebased with master, now everything should be working, the fix was in EUI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
💔 Build Failed |
hm, failed on:
|
a209213
to
e6a2f32
Compare
💚 Build Succeeded |
* Switch to euicontextmenu * update jest panel snapshots
@stacey-gammon I don't think this got backported to 6.x. It looks like the backport PR was closed and not merged. |
* Switch to euicontextmenu * update jest panel snapshots
oh no! good catch. Not sure how that happened. Will throw up a PR now. |
I found it because I had a merge conflict with #19130 |
Before:
After:
I had to add a specific
display:block
on the euiContextMenuItem to get them to show up stacked. No idea why... design team might be able to help. :)Oh I also need a collapse icon, right now I'm just using expand for both: