Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESQL] Scroll to Panel #176835

Merged
merged 2 commits into from
Feb 14, 2024
Merged

[ESQL] Scroll to Panel #176835

merged 2 commits into from
Feb 14, 2024

Conversation

ThomThomson
Copy link
Contributor

Summary

One line change that fixes #176831

@ThomThomson ThomThomson added loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Feb 13, 2024
@ThomThomson
Copy link
Contributor Author

/ci

@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

@ThomThomson
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #9 / AlertPropertyActions renders the correct number of actions

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 384.3KB 384.4KB +27.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson marked this pull request as ready for review February 14, 2024 17:05
@ThomThomson ThomThomson requested a review from a team as a code owner February 14, 2024 17:05
nreese
nreese approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review only

@ThomThomson ThomThomson merged commit 5e56ad2 into elastic:main Feb 14, 2024
17 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Feb 14, 2024
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@ThomThomson @CoenWarmer
[ESQL] Scroll to Panel (elastic#176835)
3652c55 
Scroll to panel when it is focused
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@ThomThomson @fkanout
[ESQL] Scroll to Panel (elastic#176835)
a06b3bf 
Scroll to panel when it is focused
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ESQL] Dashboard does not scroll to panel when creating via ESQL
4 participants
@ThomThomson @kibana-ci @nreese @kibanamachine