decouple anomaly job creation action from Embeddable framework

src/plugins/dashboard/public/dashboard_container/external_api/dashboard_api.ts

@@ -8,12 +8,24 @@
 
 import type { DataView } from '@kbn/data-views-plugin/public';
 import { CanDuplicatePanels, CanExpandPanels, TracksOverlays } from '@kbn/presentation-containers';
-import { HasTypeDisplayName, PublishesSavedObjectId } from '@kbn/presentation-publishing';
+import {
+  HasType,
+  HasTypeDisplayName,
+  PublishesLocalUnifiedSearch,
+  PublishesPanelTitle,
+  PublishesSavedObjectId,
+} from '@kbn/presentation-publishing';
 import { DashboardPanelState } from '../../../common';
 import { DashboardContainer } from '../embeddable/dashboard_container';
 
 // TODO lock down DashboardAPI
-export type DashboardAPI = DashboardContainer;
+export type DashboardAPI = DashboardContainer &
+  Partial<
+    HasType<'dashboard'> &
+      PublishesLocalUnifiedSearch &
+      PublishesPanelTitle &
+      PublishesSavedObjectId
+  >;
 export type AwaitingDashboardAPI = DashboardAPI | null;
 
 export const buildApiFromDashboardContainer = (container?: DashboardContainer) => container ?? null;

x-pack/plugins/lens/public/embeddable/index.ts

@@ -7,4 +7,4 @@
 
 export * from './embeddable';
 
-export { type HasLensConfig, apiHasLensConfig } from './interfaces/has_lens_config';
+export { type LensApi, isLensApi } from './interfaces/lens_api';

x-pack/plugins/lens/public/embeddable/interfaces/lens_api.ts

@@ -0,0 +1,38 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import type {
+  HasParentApi,
+  HasType,
+  PublishesLocalUnifiedSearch,
+  PublishesPanelTitle,
+} from '@kbn/presentation-publishing';
+import {
+  apiIsOfType,
+  apiPublishesLocalUnifiedSearch,
+  apiPublishesPanelTitle,
+} from '@kbn/presentation-publishing';
+import { LensSavedObjectAttributes } from '../embeddable';
+
+export type HasLensConfig = HasType<'lens'> & {
+  getSavedVis: () => Readonly<LensSavedObjectAttributes | undefined>;
+};
+
+export type LensApi = HasLensConfig &
+  PublishesPanelTitle &
+  PublishesLocalUnifiedSearch &
+  Partial<HasParentApi<unknown>>;
+
+export const isLensApi = (api: unknown): api is LensApi => {
+  return Boolean(
+    api &&
+      apiIsOfType(api, 'lens') &&
+      typeof (api as HasLensConfig).getSavedVis === 'function' &&
+      apiPublishesPanelTitle(api) &&
+      apiPublishesLocalUnifiedSearch(api)
+  );
+};

x-pack/plugins/lens/public/index.ts

@@ -7,7 +7,7 @@
 
 import { LensPlugin } from './plugin';
 
-export { apiHasLensConfig } from './embeddable/interfaces/has_lens_config';
+export { isLensApi } from './embeddable/interfaces/lens_api';
 export type {
   EmbeddableComponentProps,
   EmbeddableComponent,
@@ -110,7 +110,7 @@ export type {
 export type { InlineEditLensEmbeddableContext } from './trigger_actions/open_lens_config/in_app_embeddable_edit/types';
 
 export type {
-  HasLensConfig,
+  LensApi,
   LensEmbeddableInput,
   LensSavedObjectAttributes,
   Embeddable,

x-pack/plugins/maps/public/embeddable/map_api.ts

@@ -0,0 +1,37 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import type {
+  HasParentApi,
+  HasType,
+  PublishesDataViews,
+  PublishesPanelTitle,
+  PublishesLocalUnifiedSearch,
+} from '@kbn/presentation-publishing';
+import {
+  apiIsOfType,
+  apiPublishesLocalUnifiedSearch,
+  apiPublishesPanelTitle,
+} from '@kbn/presentation-publishing';
+import type { ILayer } from '../classes/layers/layer';
+
+export type MapApi = HasType<'map'> & {
+  getLayerList: () => ILayer[];
+} & PublishesDataViews &
+  PublishesPanelTitle &
+  PublishesLocalUnifiedSearch &
+  Partial<HasParentApi<unknown>>;
+
+export const isMapApi = (api: unknown): api is MapApi => {
+  return Boolean(
+    api &&
+      apiIsOfType(api, 'map') &&
+      typeof (api as MapApi).getLayerList === 'function' &&
+      apiPublishesPanelTitle(api) &&
+      apiPublishesLocalUnifiedSearch(api)
+  );
+};

x-pack/plugins/maps/public/index.ts

@@ -28,6 +28,7 @@ export type {
 export type { MapsSetupApi, MapsStartApi } from './api';
 
 export type { MapEmbeddable, MapEmbeddableInput, MapEmbeddableOutput } from './embeddable';
+export { type MapApi, isMapApi } from './embeddable/map_api';
 
 export type { EMSTermJoinConfig, SampleValuesConfig } from './ems_autosuggest';
 

x-pack/plugins/maps/public/trigger_actions/synchronize_movement/is_compatible.ts

@@ -7,7 +7,7 @@
 
 import { apiIsOfType } from '@kbn/presentation-publishing';
 import { apiHasVisualizeConfig } from '@kbn/visualizations-plugin/public';
-import { apiHasLensConfig } from '@kbn/lens-plugin/public';
+import { isLensApi } from '@kbn/lens-plugin/public';
 import { MAP_SAVED_OBJECT_TYPE } from '../../../common/constants';
 import { isLegacyMapApi } from '../../legacy_visualizations/is_legacy_map';
 import { mapEmbeddablesSingleton } from '../../embeddable/map_embeddables_singleton';
@@ -19,7 +19,7 @@ export function isCompatible(api: SynchronizeMovementActionApi) {
   }
   return (
     apiIsOfType(api, MAP_SAVED_OBJECT_TYPE) ||
-    (apiHasLensConfig(api) && api.getSavedVis()?.visualizationType === 'lnsChoropleth') ||
+    (isLensApi(api) && api.getSavedVis()?.visualizationType === 'lnsChoropleth') ||
     (apiHasVisualizeConfig(api) && isLegacyMapApi(api))
   );
 }

x-pack/plugins/maps/public/trigger_actions/synchronize_movement/types.ts

@@ -6,9 +6,9 @@
  */
 
 import type { HasType } from '@kbn/presentation-publishing';
-import type { HasLensConfig } from '@kbn/lens-plugin/public';
+import type { LensApi } from '@kbn/lens-plugin/public';
 import type { HasVisualizeConfig } from '@kbn/visualizations-plugin/public';
 
 export type SynchronizeMovementActionApi =
   | HasType<'map' | 'visualization' | 'lens'>
-  | Partial<HasLensConfig | HasVisualizeConfig>;
+  | Partial<LensApi | HasVisualizeConfig>;

x-pack/plugins/ml/public/application/jobs/new_job/job_from_dashboard/index.ts

@@ -5,5 +5,5 @@
  * 2.0.
  */
 
-export { QuickJobCreatorBase, isLensEmbeddable, isMapEmbeddable } from './quick_create_job_base';
+export { QuickJobCreatorBase } from './quick_create_job_base';
 export type { CreateState } from './quick_create_job_base';

x-pack/plugins/ml/public/application/jobs/new_job/job_from_dashboard/quick_create_job_base.ts

@@ -11,11 +11,14 @@ import type { IUiSettingsClient } from '@kbn/core/public';
 import type { TimefilterContract } from '@kbn/data-plugin/public';
 import { firstValueFrom } from 'rxjs';
 import type * as estypes from '@elastic/elasticsearch/lib/api/typesWithBodyKey';
-import type { DashboardLocatorParams, DashboardStart } from '@kbn/dashboard-plugin/public';
+import type {
+  DashboardAPI,
+  DashboardLocatorParams,
+  DashboardStart,
+} from '@kbn/dashboard-plugin/public';
+import { getPanelTitle } from '@kbn/presentation-publishing';
 import type { Filter, Query, DataViewBase } from '@kbn/es-query';
 import { FilterStateStore } from '@kbn/es-query';
-import type { Embeddable } from '@kbn/lens-plugin/public';
-import type { MapEmbeddable } from '@kbn/maps-plugin/public';
 import type { ErrorType } from '@kbn/ml-error-utils';
 import type { DataViewsContract } from '@kbn/data-views-plugin/public';
 import type { MlApiServices } from '../../../services/ml_api_service';
@@ -25,16 +28,6 @@ import type { CREATED_BY_LABEL } from '../../../../../common/constants/new_job';
 import { createQueries } from '../utils/new_job_utils';
 import { createDatafeedId } from '../../../../../common/util/job_utils';
 
-export function isLensEmbeddable(arg: any): arg is Embeddable {
-  return arg.hasOwnProperty('type') && arg.type === 'lens';
-}
-
-export function isMapEmbeddable(arg: any): arg is MapEmbeddable {
-  return arg.hasOwnProperty('type') && arg.type === 'map';
-}
-
-export type Dashboard = Embeddable['parent'];
-
 interface CreationState {
   success: boolean;
   error?: ErrorType;
@@ -85,7 +78,7 @@ export class QuickJobCreatorBase {
     end: number | undefined;
     startJob: boolean;
     runInRealTime: boolean;
-    dashboard?: Dashboard;
+    dashboard?: DashboardAPI;
   }) {
     const datafeedId = createDatafeedId(jobId);
     const datafeed = { ...datafeedConfig, job_id: jobId, datafeed_id: datafeedId };
@@ -232,23 +225,14 @@ export class QuickJobCreatorBase {
     return mergedQueries;
   }
 
-  private async createDashboardLink(dashboard: Dashboard, datafeedConfig: estypes.MlDatafeed) {
-    const dashboardTitle = dashboard?.getTitle();
-    if (dashboardTitle === undefined || dashboardTitle === '') {
-      // embeddable may have not been in a dashboard
-      // and my not have been given a title as it is unsaved.
-      return null;
-    }
-
-    const findDashboardsService = await this.dashboardService.findDashboardsService();
-    // find the dashboard from the dashboard service as the dashboard passed in may not have the correct id
-    const foundDashboard = await findDashboardsService.findByTitle(dashboardTitle);
-    if (foundDashboard === undefined) {
+  private async createDashboardLink(dashboard: DashboardAPI, datafeedConfig: estypes.MlDatafeed) {
+    const savedObjectId = dashboard.savedObjectId?.value;
+    if (!savedObjectId) {
       return null;
     }
 
     const params: DashboardLocatorParams = {
-      dashboardId: foundDashboard.id,
+      dashboardId: savedObjectId,
       timeRange: {
         from: '$earliest$',
         to: '$latest$',
@@ -270,13 +254,13 @@ export class QuickJobCreatorBase {
     const url = `${location.app}${location.path}`;
     const urlName = i18n.translate('xpack.ml.newJob.fromLens.createJob.namedUrlDashboard', {
       defaultMessage: 'Open {dashboardTitle}',
-      values: { dashboardTitle },
+      values: { dashboardTitle: getPanelTitle(dashboard) ?? 'dashboard' },
     });
 
     return { url_name: urlName, url_value: url, time_range: 'auto' };
   }
 
-  private async getCustomUrls(dashboard: Dashboard, datafeedConfig: estypes.MlDatafeed) {
+  private async getCustomUrls(dashboard: DashboardAPI, datafeedConfig: estypes.MlDatafeed) {
     const customUrls = await this.createDashboardLink(dashboard, datafeedConfig);
     return dashboard !== undefined && customUrls !== null ? { custom_urls: [customUrls] } : {};
   }

x-pack/plugins/ml/public/application/jobs/new_job/job_from_lens/index.ts

@@ -13,4 +13,5 @@ export {
   getJobsItemsFromEmbeddable,
   isCompatibleVisualizationType,
   redirectToADJobWizards,
+  getChartInfoFromVisualization,
 } from './utils';

x-pack/plugins/ml/public/application/jobs/new_job/job_from_lens/quick_create_job.ts

@@ -8,7 +8,6 @@
 import { i18n } from '@kbn/i18n';
 import type {
   ChartInfo,
-  Embeddable,
   LensPublicStart,
   LensSavedObjectAttributes,
 } from '@kbn/lens-plugin/public';
@@ -17,7 +16,7 @@ import type { TimefilterContract } from '@kbn/data-plugin/public';
 import type { DataViewsContract } from '@kbn/data-views-plugin/public';
 import type { Filter, Query } from '@kbn/es-query';
 import type { DashboardStart } from '@kbn/dashboard-plugin/public';
-
+import type { LensApi } from '@kbn/lens-plugin/public';
 import type { JobCreatorType } from '../common/job_creator';
 import { createEmptyJob, createEmptyDatafeed } from '../common/job_creator/util/default_configs';
 import { stashJobForCloning } from '../common/job_creator/util/general';
@@ -51,7 +50,7 @@ export class QuickLensJobCreator extends QuickJobCreatorBase {
   public async createAndSaveJob(
     jobId: string,
     bucketSpan: string,
-    embeddable: Embeddable,
+    embeddable: LensApi,
     startJob: boolean,
     runInRealTime: boolean,
     layerIndex: number