Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lens] update LensEmbeddable.getSavedVis to return LensSavedObjectAttributes #177064

Merged
merged 3 commits into from
Feb 20, 2024
Merged

[lens] update LensEmbeddable.getSavedVis to return LensSavedObjectAttributes #177064

merged 3 commits into from
Feb 20, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Feb 15, 2024 •
edited
Loading

Blocking #176869

While working on #176869, I discovered there is a type mismatch between LensEmbeddable.getSavedVis internal implementation and consumers of LensEmbeddable.getSavedVis results.

LensEmbeddable.getSavedVis returns Readonly<Document | undefined>.
LensEmbeddable.getSavedVis consumers are typing the response as LensSavedObjectAttributes.

This PR updates LensEmbeddable.getSavedVis to return Readonly<LensSavedObjectAttributes | undefined> since that is how its being used.

@nreese
Copy link
Contributor Author

nreese commented Feb 15, 2024

/ci

@nreese nreese marked this pull request as ready for review February 15, 2024 20:42
@nreese nreese requested a review from a team as a code owner February 15, 2024 20:42
@nreese nreese added technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.14.0 labels Feb 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@nreese nreese added release_note:skip Skip the PR/issue when compiling release notes project:embeddableRebuild labels Feb 15, 2024
@nreese
Copy link
Contributor Author

nreese commented Feb 20, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.4MB 1.4MB +77.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
lens 62 61 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

drewdaemon
drewdaemon approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nreese nreese merged commit 82d7244 into elastic:main Feb 20, 2024
26 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 20, 2024
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@nreese @kibanamachine @fkanout
[lens] update LensEmbeddable.getSavedVis to return LensSavedObjectAtt…
6678134 
…ributes (elastic#177064)

Blocking elastic#176869

While working on elastic#176869, I
discovered there is a type mismatch between `LensEmbeddable.getSavedVis`
internal implementation and consumers of `LensEmbeddable.getSavedVis`
results.

LensEmbeddable.getSavedVis returns `Readonly<Document | undefined>`.
LensEmbeddable.getSavedVis consumers are typing the response as
`LensSavedObjectAttributes`.

This PR updates `LensEmbeddable.getSavedVis` to return
`Readonly<LensSavedObjectAttributes | undefined>` since that is how its
being used.

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewdaemon drewdaemon drewdaemon approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nreese @elasticmachine @kibana-ci @drewdaemon @kibanamachine