Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLOs] only display group by cardinality when group by exists #178133

Merged
merged 2 commits into from
Mar 6, 2024
Merged

[SLOs] only display group by cardinality when group by exists #178133

merged 2 commits into from
Mar 6, 2024

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Mar 6, 2024 •
edited by kibanamachine
Loading

Summary

Resolves #178129

Screenshot 2024-03-06 at 10 54 54 AM

Release note

SLOs: Does not display group by cardinality when group by is not selected.

Testing

  1. Create an SLO without a group by
  2. Create an SLO with a group by
  3. Edit the SLO without a group by. The cardinality callout should not appear
  4. Add a group by to the same SLO. The cardinality callout should appear
  5. Edit the SLO with a group by. The cardinality callout should appear
  6. Remove the group by on the same SLO. The cardinality callout should disappear

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience v8.13.0 v8.14.0 release_note:fix Feature:SLO Team:obs-ux-management Observability Management User Experience Team labels Mar 6, 2024
@dominiqueclarke dominiqueclarke marked this pull request as ready for review March 6, 2024 15:55
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner March 6, 2024 15:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@dominiqueclarke
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 661.0KB 661.0KB +62.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke merged commit edb11eb into elastic:main Mar 6, 2024
19 checks passed
@dominiqueclarke dominiqueclarke deleted the fix/group-by-edit-view branch March 6, 2024 18:19
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 6, 2024
@dominiqueclarke
[SLOs] only display group by cardinality when group by exists (elasti…
8458672 
…c#178133)

## Summary

Resolves elastic#178129

<img width="882" alt="Screenshot 2024-03-06 at 10 54 54 AM"
src="https://github.com/elastic/kibana/assets/11356435/f9c6e979-d921-478a-9b38-ab65a0798ee0">

### Release note
SLOs: Does not display group by cardinality when group by is not
selected.

### Testing
1. Create an SLO without a group by
2. Create an SLO with a group by
3. Edit the SLO without a group by. The cardinality callout should not
appear
4. Add a group by to the same SLO. The cardinality callout should appear
5. Edit the SLO with a group by. The cardinality callout should appear
6. Remove the group by on the same SLO. The cardinality callout should
disappear

(cherry picked from commit edb11eb)
@kibanamachine kibanamachine mentioned this pull request Mar 6, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 6, 2024
@kibanamachine @dominiqueclarke
[8.13] [SLOs] only display group by cardinality when group by exists (#…
86d2742 
…178133) (#178154)

# Backport

This will backport the following commits from `main` to `8.13`:
- [[SLOs] only display group by cardinality when group by exists
(#178133)](#178133)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dominique
Clarke","email":"dominique.clarke@elastic.co"},"sourceCommit":{"committedDate":"2024-03-06T18:19:12Z","message":"[SLOs]
only display group by cardinality when group by exists (#178133)\n\n##
Summary\r\n\r\nResolves
https://github.com/elastic/kibana/issues/178129\r\n\r\n<img
width=\"882\" alt=\"Screenshot 2024-03-06 at 10 54 54
AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/11356435/f9c6e979-d921-478a-9b38-ab65a0798ee0\">\r\n\r\n###
Release note\r\nSLOs: Does not display group by cardinality when group
by is not\r\nselected.\r\n\r\n### Testing\r\n1. Create an SLO without a
group by\r\n2. Create an SLO with a group by\r\n3. Edit the SLO without
a group by. The cardinality callout should not\r\nappear\r\n4. Add a
group by to the same SLO. The cardinality callout should appear\r\n5.
Edit the SLO with a group by. The cardinality callout should
appear\r\n6. Remove the group by on the same SLO. The cardinality
callout
should\r\ndisappear","sha":"edb11ebb3644ab5188f333c4e397f3869d9d5adf","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Feature:SLO","Team:obs-ux-management","v8.13.0","v8.14.0"],"title":"[SLOs]
only display group by cardinality when group by
exists","number":178133,"url":"https://github.com/elastic/kibana/pull/178133","mergeCommit":{"message":"[SLOs]
only display group by cardinality when group by exists (#178133)\n\n##
Summary\r\n\r\nResolves
https://github.com/elastic/kibana/issues/178129\r\n\r\n<img
width=\"882\" alt=\"Screenshot 2024-03-06 at 10 54 54
AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/11356435/f9c6e979-d921-478a-9b38-ab65a0798ee0\">\r\n\r\n###
Release note\r\nSLOs: Does not display group by cardinality when group
by is not\r\nselected.\r\n\r\n### Testing\r\n1. Create an SLO without a
group by\r\n2. Create an SLO with a group by\r\n3. Edit the SLO without
a group by. The cardinality callout should not\r\nappear\r\n4. Add a
group by to the same SLO. The cardinality callout should appear\r\n5.
Edit the SLO with a group by. The cardinality callout should
appear\r\n6. Remove the group by on the same SLO. The cardinality
callout
should\r\ndisappear","sha":"edb11ebb3644ab5188f333c4e397f3869d9d5adf"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/178133","number":178133,"mergeCommit":{"message":"[SLOs]
only display group by cardinality when group by exists (#178133)\n\n##
Summary\r\n\r\nResolves
https://github.com/elastic/kibana/issues/178129\r\n\r\n<img
width=\"882\" alt=\"Screenshot 2024-03-06 at 10 54 54
AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/11356435/f9c6e979-d921-478a-9b38-ab65a0798ee0\">\r\n\r\n###
Release note\r\nSLOs: Does not display group by cardinality when group
by is not\r\nselected.\r\n\r\n### Testing\r\n1. Create an SLO without a
group by\r\n2. Create an SLO with a group by\r\n3. Edit the SLO without
a group by. The cardinality callout should not\r\nappear\r\n4. Add a
group by to the same SLO. The cardinality callout should appear\r\n5.
Edit the SLO with a group by. The cardinality callout should
appear\r\n6. Remove the group by on the same SLO. The cardinality
callout
should\r\ndisappear","sha":"edb11ebb3644ab5188f333c4e397f3869d9d5adf"}}]}]
BACKPORT-->

Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:SLO release_note:fix Team:obs-ux-management Observability Management User Experience Team v8.13.0 v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SLOs] Group by cardinality displays when no group by is selected in edit flow
6 participants
@dominiqueclarke @apmmachine @elasticmachine @kibana-ci @kibanamachine @shahzad31