Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Fixes hidden add panel popover on smaller viewports #178593

Merged
merged 2 commits into from
Mar 15, 2024
Merged

[Dashboard] Fixes hidden add panel popover on smaller viewports #178593

merged 2 commits into from
Mar 15, 2024

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Mar 13, 2024 •
edited by kibanamachine
Loading

Summary

Closes #172490.

Mar-12-2024 19-28-35

This restricts the height of the Add panel popover so it doesn't get pushed up and hidden under the unified search bar.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@cqliu1 cqliu1 requested review from a team as code owners March 13, 2024 02:33
@cqliu1 cqliu1 added Feature:Dashboard Dashboard related features release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Mar 13, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@cqliu1 cqliu1 force-pushed the dashboard/restrict-panel-menu-height branch from 8939e8a to c58f689 Compare March 13, 2024 02:38
@nreese nreese self-requested a review March 13, 2024 14:12
nreese
nreese approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review and tested in chrome

@cqliu1 cqliu1 added loe:small Small Level of Effort impact:critical This issue should be addressed immediately due to a critical level of impact on the product. labels Mar 13, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboard 430 435 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 383.7KB 385.6KB +1.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cqliu1 cqliu1 changed the title [Dashboard] Fixes hidden add panel popover on small viewports [Dashboard] Fixes hidden add panel popover on smaller viewports Mar 13, 2024
andreadelrio
andreadelrio approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design changes LGTM.

@cqliu1 cqliu1 merged commit be12500 into elastic:main Mar 15, 2024
30 checks passed
@cqliu1 cqliu1 added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 15, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 15, 2024
@cqliu1
[Dashboard] Fixes hidden add panel popover on smaller viewports (elas…
5599116 
…tic#178593)

(cherry picked from commit be12500)
@kibanamachine kibanamachine mentioned this pull request Mar 15, 2024
Merged
kibanamachine pushed a commit that referenced this pull request Mar 15, 2024
@cqliu1
[Dashboard] Fixes hidden add panel popover on smaller viewports (#178593
6e030ff 
)

(cherry picked from commit be12500)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Mar 15, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine added a commit that referenced this pull request Mar 15, 2024
@kibanamachine @cqliu1
[8.13] [Dashboard] Fixes hidden add panel popover on smaller viewports (
038cfb2 
#178593) (#178819)

# Backport

This will backport the following commits from `main` to `8.13`:
- [[Dashboard] Fixes hidden add panel popover on smaller viewports
(#178593)](#178593)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Catherine
Liu","email":"catherine.liu@elastic.co"},"sourceCommit":{"committedDate":"2024-03-15T16:13:54Z","message":"[Dashboard]
Fixes hidden add panel popover on smaller viewports
(#178593)","sha":"be12500902702daadd364f2f2c20685708b989b8","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Dashboard","release_note:fix","Team:Presentation","loe:small","impact:critical","v8.14.0","v8.13.1"],"title":"[Dashboard]
Fixes hidden add panel popover on smaller
viewports","number":178593,"url":"https://github.com/elastic/kibana/pull/178593","mergeCommit":{"message":"[Dashboard]
Fixes hidden add panel popover on smaller viewports
(#178593)","sha":"be12500902702daadd364f2f2c20685708b989b8"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/178593","number":178593,"mergeCommit":{"message":"[Dashboard]
Fixes hidden add panel popover on smaller viewports
(#178593)","sha":"be12500902702daadd364f2f2c20685708b989b8"}},{"branch":"8.13","label":"v8.13.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Catherine Liu <catherine.liu@elastic.co>
kibanamachine added a commit that referenced this pull request Mar 15, 2024
@kibanamachine @cqliu1
[8.13] [Dashboard] Fixes hidden add panel popover on smaller viewports (
9744e43 
#178593) (#178820)

# Backport

This will backport the following commits from `main` to `8.13`:
- [[Dashboard] Fixes hidden add panel popover on smaller viewports
(#178593)](#178593)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Catherine
Liu","email":"catherine.liu@elastic.co"},"sourceCommit":{"committedDate":"2024-03-15T16:13:54Z","message":"[Dashboard]
Fixes hidden add panel popover on smaller viewports
(#178593)","sha":"be12500902702daadd364f2f2c20685708b989b8","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Dashboard","release_note:fix","Team:Presentation","loe:small","impact:critical","auto-backport","v8.14.0","v8.13.1"],"number":178593,"url":"https://github.com/elastic/kibana/pull/178593","mergeCommit":{"message":"[Dashboard]
Fixes hidden add panel popover on smaller viewports
(#178593)","sha":"be12500902702daadd364f2f2c20685708b989b8"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/178593","number":178593,"mergeCommit":{"message":"[Dashboard]
Fixes hidden add panel popover on smaller viewports
(#178593)","sha":"be12500902702daadd364f2f2c20685708b989b8"}},{"branch":"8.13","label":"v8.13.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Catherine Liu <catherine.liu@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreadelrio andreadelrio andreadelrio approved these changes

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Dashboard Dashboard related features impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.13.0 v8.13.1 v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"add Panel" menu hidden under other elements
6 participants
@cqliu1 @elasticmachine @kibana-ci @kibanamachine @nreese @andreadelrio