Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[embeddable refactor] rename PublishesLocalUnifiedSearch to PublishesUnifiedSearch #178638

Merged
merged 12 commits into from
Mar 14, 2024
Merged

[embeddable refactor] rename PublishesLocalUnifiedSearch to PublishesUnifiedSearch #178638

merged 12 commits into from
Mar 14, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Mar 13, 2024 •
edited
Loading

Part of #178630

PR cleans up PublishesUnifiedSearch, removing reference to local.

PR removes getFallbackTimeRange from interface. To get this value use api.parentApi.timeRange.value

@nreese
Copy link
Contributor Author

nreese commented Mar 13, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Mar 13, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Mar 13, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Mar 13, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Mar 13, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Mar 13, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Mar 14, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Mar 14, 2024

/ci

@nreese nreese marked this pull request as ready for review March 14, 2024 03:48
@nreese nreese requested review from a team as code owners March 14, 2024 03:48
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes project:embeddableRebuild v8.14.0 labels Mar 14, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

jgowdyelastic
jgowdyelastic approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML code changes LGTM

@botelastic botelastic bot added the Feature:Drilldowns Embeddable panel Drilldowns label Mar 14, 2024
@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Mar 14, 2024
mbondyra
mbondyra approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🆗 Tested on visualize and Lens, no regression noticed.

ThomThomson
ThomThomson approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming convention update LGTM! Code only review.

Now with the local wording removed, it will make much more sense when a parent and a child both have unified search state.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/presentation-publishing 120 116 -4
embeddable 457 456 -1
total -5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 383.8KB 383.8KB -40.0B
ml 3.7MB 3.7MB -104.0B
total -144.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 37.4KB 37.4KB -16.0B
discoverEnhanced 6.9KB 6.9KB -36.0B
embeddable 66.5KB 66.2KB -313.0B
lens 45.9KB 45.8KB -12.0B
maps 49.6KB 49.6KB -12.0B
presentationPanel 41.7KB 41.6KB -42.0B
urlDrilldown 15.8KB 15.8KB -16.0B
visualizations 58.1KB 58.1KB -4.0B
total -451.0B
Unknown metric groups

API count

id before after diff
@kbn/presentation-publishing 156 149 -7
embeddable 562 561 -1
total -8

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

davismcphee
davismcphee approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-only review, Data Discovery changes LGTM 👍

@nreese nreese merged commit 5a65fc8 into elastic:main Mar 14, 2024
16 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

@Dosant Dosant Dosant approved these changes

@mbondyra mbondyra mbondyra approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@nreese @elasticmachine @kibana-ci @mbondyra @Dosant @ThomThomson @jgowdyelastic @davismcphee @kibanamachine