Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ops] Propagate DRY_RUN to gpctl-promote #178658

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

delanni
Copy link
Contributor

@delanni delanni commented Mar 13, 2024

Summary

We've had some issues with the weekly scheduled serverless release after we've switched to a direct trigger to gpctl-promote.

Although we've tried a few options, and we've probably found the solution, but we can still go for sure, and try a dry-run cross trigger. This wasn't possible before, but https://github.com/elastic/gpctl/pull/261 should now respect DRY_RUN env vars coming in.

This PR propagates those variables, so we can test the setup.

@delanni delanni added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting skip-ci labels Mar 13, 2024
@delanni delanni marked this pull request as ready for review March 13, 2024 16:47
@delanni delanni requested a review from a team as a code owner March 13, 2024 16:47
@delanni delanni added the Team:Operations Team label for Operations Team label Mar 13, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@delanni delanni merged commit 52ff9b0 into elastic:main Mar 14, 2024
13 checks passed
@delanni delanni deleted the propagate-dry-run-to-gpctl branch March 14, 2024 09:55
delanni added a commit that referenced this pull request Mar 14, 2024
## Summary
Missed adding this change in
#178658

Tested in
https://buildkite.com/elastic/kibana-serverless-release-1/builds/138 -
the receiving pipeline is now prepared for `DRY_RUN` and we can happily
trigger the downstream `gpctl-promote` job.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes skip-ci Team:Operations Team label for Operations Team v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants