-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboard Log Threshold rule type with FAAD #178680
Onboard Log Threshold rule type with FAAD #178680
Conversation
/ci |
1 similar comment
/ci |
/ci |
/ci |
/ci |
/ci |
Pinging @elastic/response-ops (Team:ResponseOps) |
…ana into move-log-threshold-to-faad
x-pack/plugins/observability_solution/infra/server/lib/alerting/register_rule_types.ts
Outdated
Show resolved
Hide resolved
...ability_solution/infra/server/lib/alerting/log_threshold/register_log_threshold_rule_type.ts
Outdated
Show resolved
Hide resolved
...ins/observability_solution/infra/server/lib/alerting/log_threshold/log_threshold_executor.ts
Outdated
Show resolved
Hide resolved
...ins/observability_solution/infra/server/lib/alerting/log_threshold/log_threshold_executor.ts
Outdated
Show resolved
Hide resolved
...ins/observability_solution/infra/server/lib/alerting/log_threshold/log_threshold_executor.ts
Outdated
Show resolved
Hide resolved
...ins/observability_solution/infra/server/lib/alerting/log_threshold/log_threshold_executor.ts
Outdated
Show resolved
Hide resolved
…ana into move-log-threshold-to-faad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality-wise, I tested creating an alert and recovering it + notification, also exceeding the limit for number of alerts that are generated and everything seemed as expected! 💪🏻
Code-wise, I rely on ResponseOps team review :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ana into move-log-threshold-to-faad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed the as mentioned. Working as expected 👍 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
💚 Build Succeeded
Metrics [docs]History
To update your PR or re-run it, just comment with: cc @doakalexi |
Towards: #169867
This PR onboards Log Threshold rule type with FAAD.
To verify
Create a log threshold rule.
Example:
Your rule should create an alert and should saved it in
.internal.alerts-observability.metrics.alerts-default-000001
Example:
Then set
count.value: 75
The alert should be recovered and the AAD in the above index should be updated
kibana.alert.status: recovered
.