-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboard Latency Threshold rule type with FAAD #179080
Onboard Latency Threshold rule type with FAAD #179080
Conversation
/ci |
/ci |
Pinging @elastic/response-ops (Team:ResponseOps) |
@@ -90,6 +90,7 @@ export const ApmRuleTypeAlertDefinition: IRuleTypeAlerts = { | |||
context: APM_RULE_TYPE_ALERT_CONTEXT, | |||
mappings: { fieldMap: apmRuleTypeAlertFieldMap }, | |||
useLegacyAlerts: true, | |||
shouldWrite: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does shouldWrite
mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We added this flag to prevent rules that were registered with both the rule registry and the alerting framework from having both write alerting docs. It will be removed once we move all rules away from the rule registry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should set this to true
here and remove the override in x-pack/plugins/observability_solution/apm/server/routes/alerts/rule_types/transaction_duration/register_transaction_duration_rule_type.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need this until all the APM rules have been onboarded. On the last rule I will make sure to do this. Thanks!
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, alert documents appear correct, in the expected index, can be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified locally, works as expected 👍 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @doakalexi |
Towards: #169867
This PR onboards Latency Threshold rule type with FAAD.
To verify
Example:
.internal.alerts-observability.apm.alerts-default-000001
Example:
Set
threshold: 10000
The alert should be recovered and the AAD in the above index should be updated
kibana.alert.status: recovered
.