Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embeddables Rebuild] Move titles API #179202

Merged
merged 6 commits into from
Mar 22, 2024

Conversation

ThomThomson
Copy link
Contributor

Summary

This PR moves the titles API and state comparators away from the embeddable plugin and to the presentation-publishing package.

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:Embeddables Relating to the Embeddable system project:embeddableRebuild labels Mar 21, 2024
@ThomThomson
Copy link
Contributor Author

/ci

@ThomThomson ThomThomson added release_note:skip Skip the PR/issue when compiling release notes and removed Feature:Dashboard Dashboard related features labels Mar 21, 2024
@ThomThomson
Copy link
Contributor Author

/ci

@ThomThomson ThomThomson marked this pull request as ready for review March 21, 2024 23:17
@ThomThomson ThomThomson requested a review from a team as a code owner March 21, 2024 23:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Mar 21, 2024
@ThomThomson ThomThomson removed the Feature:Embedding Embedding content via iFrame label Mar 21, 2024
@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Mar 22, 2024
@nreese nreese self-requested a review March 22, 2024 13:30
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for moving these into presentation-publishing. Its great to see more logic consolidated into this package.
code review only

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboard 435 438 +3
dashboardEnhanced 60 63 +3
discover 769 772 +3
discoverEnhanced 32 35 +3
embeddable 107 109 +2
embeddableEnhanced 32 35 +3
inputControlVis 68 71 +3
lens 1368 1371 +3
links 122 125 +3
maps 1149 1152 +3
ml 1968 1971 +3
presentationPanel 85 88 +3
urlDrilldown 34 37 +3
visualizations 404 407 +3
total +41

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/presentation-publishing 116 134 +18
embeddable 462 453 -9
total +9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 385.5KB 385.5KB +6.0B
lens 1.4MB 1.4MB -5.0B
total +1.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/presentation-publishing 3 4 +1
embeddable 11 10 -1
total -0

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 66.1KB 65.9KB -208.0B
embeddableEnhanced 9.9KB 9.9KB +2.0B
lens 45.9KB 45.9KB +3.0B
presentationPanel 41.7KB 41.6KB -84.0B
total -287.0B
Unknown metric groups

API count

id before after diff
@kbn/presentation-publishing 149 164 +15
embeddable 564 555 -9
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit 59b1f8a into elastic:main Mar 22, 2024
16 checks passed
@kibanamachine kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Embeddables Relating to the Embeddable system Feature:Embedding Embedding content via iFrame impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants