Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ZDT] add aliases when creating the index #179792

Merged
merged 3 commits into from
Apr 2, 2024
Merged

[ZDT] add aliases when creating the index #179792

merged 3 commits into from
Apr 2, 2024

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Apr 2, 2024 •
edited
Loading

Summary

Fix #179783

Create the aliases during initial index creation, instead of doing it in a later stage. This avoids an additional roundtrip with ES during project creation.

Before:

INIT -> CREATE_TARGET_INDEX -> UPDATE_ALIASES -> INDEX_STATE_UPDATE_DONE -> DONE

After:

INIT -> CREATE_TARGET_INDEX -> INDEX_STATE_UPDATE_DONE -> DONE

@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes Feature:Migrations v8.14.0 labels Apr 2, 2024
@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet pgayvallet marked this pull request as ready for review April 2, 2024 09:31
@pgayvallet pgayvallet requested a review from a team as a code owner April 2, 2024 09:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

jloleysens
jloleysens approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, apologies I kicked off another build after I added the ci:serverless-test-all label, but apparently the test_serverless tests are running anyway!

@pgayvallet pgayvallet force-pushed the kbn-179783-aliases-during-creation branch from 849d007 to 2bcdeab Compare April 2, 2024 14:01
@pgayvallet pgayvallet enabled auto-merge (squash) April 2, 2024 14:01
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 8b95195 into elastic:main Apr 2, 2024
17 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 2, 2024
@pgayvallet pgayvallet mentioned this pull request Apr 16, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Migrations release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ZDT] create aliases during initial index creation
5 participants
@pgayvallet @elasticmachine @kibana-ci @jloleysens @kibanamachine