Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Support dimension mappings in dynamic templates #180023

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Apr 4, 2024

Summary

Add time_series_dimension: true to dynamic field mappings defined with dimension: true.

Fixes #179649.

Related to elastic/elasticsearch#93564.

Checklist

Risk Matrix

Risk Probability Severity Mitigation/Notes
Sets of dimensions change after upgrading package Low (no package is using this now?) Medium Add knowledge base issue about this. Package maintainers may need to analyze the possible migration path for these packages. @lalit-satapathy @tetianakravchenko please confirm if this can be an issue.

@jsoriano jsoriano self-assigned this Apr 4, 2024
@jsoriano jsoriano requested a review from a team as a code owner April 4, 2024 09:03
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Apr 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jsoriano

@jsoriano jsoriano merged commit 392ef7b into elastic:main Apr 5, 2024
21 checks passed
@jsoriano jsoriano deleted the fleet-dimensions-dynamic-template branch April 5, 2024 17:52
@kibanamachine kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] TSDB: add dimension mapping for the dynamic templates
6 participants