Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data views] Reenable MKI test - change data import tool to be serverless compatible #181349

Merged
merged 20 commits into from
May 9, 2024
Merged

[data views] Reenable MKI test - change data import tool to be serverless compatible #181349

merged 20 commits into from
May 9, 2024

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Apr 22, 2024 •
edited
Loading

Summary

Change data import / export method so test works in MKI environment.

Closes #171479 and #180568

Verified by running functional test runner run locally against MKI environment.

@mattkime mattkime self-assigned this Apr 22, 2024
@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Apr 22, 2024
@mattkime mattkime changed the title change data import tool to be serverless compatible [data views] Reenable MKI test - change data import tool to be serverless compatible Apr 22, 2024
@mattkime
Copy link
Contributor Author

/ci

@mattkime
Copy link
Contributor Author

/ci

@mattkime
Copy link
Contributor Author

/ci

@mattkime
Copy link
Contributor Author

/ci

@mattkime
Copy link
Contributor Author

/ci

@mattkime mattkime marked this pull request as ready for review May 2, 2024 14:40
@mattkime mattkime requested a review from a team as a code owner May 2, 2024 14:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@mattkime mattkime requested a review from a team May 2, 2024 16:25
@mattkime
Copy link
Contributor Author

mattkime commented May 2, 2024

/ci

@mattkime
Copy link
Contributor Author

mattkime commented May 2, 2024

/ci

@kertal kertal requested review from pheyos and wayneseymour May 3, 2024 12:27
@mattkime
Copy link
Contributor Author

mattkime commented May 3, 2024

/ci

kertal
kertal reviewed May 3, 2024
View reviewed changes
...t_serverless/functional/test_suites/common/management/data_views/_data_view_create_delete.ts
@@ -31,7 +29,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await esArchiver.loadIfNeeded(
'x-pack/test_serverless/functional/es_archives/kibana_sample_data_flights_index_pattern'
);
await kibanaServer.importExport.load(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: if this fixes the MKI error, isn't L29 + L42 redundant?
@pheyos wrote in the issue

The root cause is in both cases direct system indices access. AFAICS, this is happening when loading / unloading the archive x-pack/test_serverless/functional/es_archives/kibana_sample_data_flights_index_pattern. This kind of access is not available in MKI and the tests need to be adjusted (e.g. by loading things through kibanaServer.importExport or other APIs).

Since those functions are still here, should it work? will it work when they are removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kertal line 29 is importing regular ES docs while line 32 is importing saved objects. I'll defer to @pheyos as to whether I'm doing this correctly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's correct @mattkime. The other issue was reported quite a while back and I suspect some other things have changed as well in the mean time. I ran the tests against an observability MKI project and they passed.

davismcphee
davismcphee approved these changes May 4, 2024
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM 👍 I didn't run it on MKI though so hopefully our QA friends can help with that.

pheyos
pheyos approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattkime
Copy link
Contributor Author

mattkime commented May 8, 2024

/ci

@mattkime
Copy link
Contributor Author

mattkime commented May 8, 2024

/ci

@kibana-ci
Copy link
Collaborator

kibana-ci commented May 8, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: a075389
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-181349-a0753894426f

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataViewManagement 136.4KB 136.4KB -4.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5407 +5407
total size - 8.8MB +8.8MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mattkime

@mattkime mattkime merged commit 1bcec40 into elastic:main May 9, 2024
20 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels May 9, 2024
@davismcphee davismcphee mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal left review comments

@davismcphee davismcphee davismcphee approved these changes

@TattdCodeMonkey TattdCodeMonkey TattdCodeMonkey approved these changes

@pheyos pheyos pheyos approved these changes

@wayneseymour wayneseymour Awaiting requested review from wayneseymour

Assignees

@mattkime mattkime

Labels
backport:skip This commit does not require backporting ci:build-serverless-image Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failsOnMKI: Serverless Common UI - Management Data View Management creating and deleting default data view
9 participants
@mattkime @elasticmachine @kibana-ci @kertal @pheyos @TattdCodeMonkey @wayneseymour @davismcphee @kibanamachine