[Security Solution][Telemetry] Add integration tests #181927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaffarano
added
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 29, 2024
(cherry picked from commit 2cc5109)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 29, 2024
…#182024) # Backport This will backport the following commits from `main` to `8.14`: - [ [Security Solution][Telemetry] Add integration tests (#181927)](#181927) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sebastián Zaffarano","email":"sebastian.zaffarano@elastic.co"},"sourceCommit":{"committedDate":"2024-04-29T19:02:51Z","message":" [Security Solution][Telemetry] Add integration tests (#181927)","sha":"2cc5109484ee8336b04bb52b4e58b0aa34480b21","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: SecuritySolution","v8.14.0","v8.15.0"],"title":" [Security Solution][Telemetry] Add integration tests","number":181927,"url":"https://github.com/elastic/kibana/pull/181927","mergeCommit":{"message":" [Security Solution][Telemetry] Add integration tests (#181927)","sha":"2cc5109484ee8336b04bb52b4e58b0aa34480b21"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181927","number":181927,"mergeCommit":{"message":" [Security Solution][Telemetry] Add integration tests (#181927)","sha":"2cc5109484ee8336b04bb52b4e58b0aa34480b21"}}]}] BACKPORT--> Co-authored-by: Sebastián Zaffarano <sebastian.zaffarano@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TelemetryLoggernow includes always by default some basic data (like cluster uuid), so it is highly recommended to start using it when possible (instantiate it using thenewTelemetryLoggerfunction)endpoint-meta-telemetryendpoint-meta-telemetryto simplify its logic and also improve error handling. Based on the tests, I had to add or change how we managed errors for some (edge) cases. Also, the errors now log more information introducing fields for relevant data instead of using a nonstatic string (e.g., instead ofRunning task: ${taskId} [last: ${taskExecutionPeriod.last} - current: ${taskExecutionPeriod.current}], nowtaskIdand theexecutionPeriodare searchable fields and not part of the log message, which becomes a "static string").Regarding error handling, the goal is to send as much information as possible and not abort the execution when we encounter weird (but still feasible) errors.
endpoint-meta-telemetryusing the already defined feature flag, just in case we need to disable it through a configuration artifact. This change deprecates the current way we split the events to send them into batches (although if we disable the feature flag, it still uses this approach).