Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps] Fix for flaky test x-pack/test/alerting_api_integration/spaces_only/tests/actions/migrations·ts #182279

Merged
merged 2 commits into from
May 2, 2024

Conversation

doakalexi
Copy link
Contributor

@doakalexi doakalexi commented May 1, 2024

Resolves #169159

Summary

I could not reproduce the failure in this test, but it's using esArchiver which is known to be flaky. I followed the instructions in this issue, Proactively improve robustness of FTR tests that use esArchiver #161882, to help reduce flakiness in the future.

Flaky test runner:
run 1 x 50
run 2 x 200
run 3 x 200

@doakalexi doakalexi changed the title Removes skip on flaky migration test [ResponseOps] Fix for flaky test x-pack/test/alerting_api_integration/spaces_only/tests/actions/migrations·ts May 2, 2024
@doakalexi doakalexi added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) release_note:skip Skip the PR/issue when compiling release notes v8.15.0 labels May 2, 2024
@doakalexi doakalexi marked this pull request as ready for review May 2, 2024 14:17
@doakalexi doakalexi requested a review from a team as a code owner May 2, 2024 14:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like this should be backported to 8.14 as well

@doakalexi doakalexi enabled auto-merge (squash) May 2, 2024 14:27
@doakalexi
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@doakalexi doakalexi merged commit e062a9f into elastic:main May 2, 2024
25 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.14 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 182279

Questions ?

Please refer to the Backport tool documentation

@doakalexi
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

doakalexi added a commit to doakalexi/kibana that referenced this pull request May 2, 2024
…/spaces_only/tests/actions/migrations·ts (elastic#182279)

Resolves elastic#169159

## Summary

I could not reproduce the failure in this test, but it's using
`esArchiver` which is known to be flaky. I followed the instructions in
this issue, [Proactively improve robustness of FTR tests that use
esArchiver elastic#161882](elastic#161882), to
help reduce flakiness in the future.

Flaky test runner:
[run
1](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5829#_)
x 50
[run
2](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5830)
x 200
[run
3](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5831)
x 200

(cherry picked from commit e062a9f)

# Conflicts:
#	x-pack/test/alerting_api_integration/spaces_only/tests/actions/migrations.ts
doakalexi added a commit that referenced this pull request May 2, 2024
…gration/spaces_only/tests/actions/migrations·ts (#182279) (#182506)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[ResponseOps] Fix for flaky test
x-pack/test/alerting_api_integration/spaces_only/tests/actions/migrations·ts
(#182279)](#182279)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexi
Doak","email":"109488926+doakalexi@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-05-02T18:33:58Z","message":"[ResponseOps]
Fix for flaky test
x-pack/test/alerting_api_integration/spaces_only/tests/actions/migrations·ts
(#182279)\n\nResolves
https://github.com/elastic/kibana/issues/169159\r\n\r\n##
Summary\r\n\r\nI could not reproduce the failure in this test, but it's
using\r\n`esArchiver` which is known to be flaky. I followed the
instructions in\r\nthis issue, [Proactively improve robustness of FTR
tests that use\r\nesArchiver
#161882](#161882), to\r\nhelp
reduce flakiness in the future.\r\n\r\nFlaky test
runner:\r\n[run\r\n1](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5829#_)\r\nx
50\r\n[run\r\n2](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5830)\r\nx
200\r\n[run\r\n3](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5831)\r\nx
200","sha":"e062a9fbc9696ca872da98de63fb598b65ea6467","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v8.14.0","v8.15.0"],"number":182279,"url":"https://github.com/elastic/kibana/pull/182279","mergeCommit":{"message":"[ResponseOps]
Fix for flaky test
x-pack/test/alerting_api_integration/spaces_only/tests/actions/migrations·ts
(#182279)\n\nResolves
https://github.com/elastic/kibana/issues/169159\r\n\r\n##
Summary\r\n\r\nI could not reproduce the failure in this test, but it's
using\r\n`esArchiver` which is known to be flaky. I followed the
instructions in\r\nthis issue, [Proactively improve robustness of FTR
tests that use\r\nesArchiver
#161882](#161882), to\r\nhelp
reduce flakiness in the future.\r\n\r\nFlaky test
runner:\r\n[run\r\n1](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5829#_)\r\nx
50\r\n[run\r\n2](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5830)\r\nx
200\r\n[run\r\n3](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5831)\r\nx
200","sha":"e062a9fbc9696ca872da98de63fb598b65ea6467"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182279","number":182279,"mergeCommit":{"message":"[ResponseOps]
Fix for flaky test
x-pack/test/alerting_api_integration/spaces_only/tests/actions/migrations·ts
(#182279)\n\nResolves
https://github.com/elastic/kibana/issues/169159\r\n\r\n##
Summary\r\n\r\nI could not reproduce the failure in this test, but it's
using\r\n`esArchiver` which is known to be flaky. I followed the
instructions in\r\nthis issue, [Proactively improve robustness of FTR
tests that use\r\nesArchiver
#161882](#161882), to\r\nhelp
reduce flakiness in the future.\r\n\r\nFlaky test
runner:\r\n[run\r\n1](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5829#_)\r\nx
50\r\n[run\r\n2](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5830)\r\nx
200\r\n[run\r\n3](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5831)\r\nx
200","sha":"e062a9fbc9696ca872da98de63fb598b65ea6467"}}]}] BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.14.0 v8.15.0
Projects
None yet
5 participants