Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embeddable] Removes unused function #183178

Merged
merged 1 commit into from
May 10, 2024
Merged

[Embeddable] Removes unused function #183178

merged 1 commit into from
May 10, 2024

Conversation

ThomThomson
Copy link
Contributor

No description provided.

@ThomThomson ThomThomson added loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels May 10, 2024
@ThomThomson ThomThomson marked this pull request as ready for review May 10, 2024 16:48
@ThomThomson ThomThomson requested a review from a team as a code owner May 10, 2024 16:48
@ThomThomson ThomThomson mentioned this pull request May 10, 2024
Merged
nickpeihl
nickpeihl approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label May 10, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 70.0KB 69.9KB -34.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit cd5f701 into elastic:main May 10, 2024
23 of 26 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Embedding Embedding content via iFrame impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThomThomson @kibana-ci @nickpeihl @kibanamachine