Cleanup dockerfile #183334

jbudz · 2024-05-13T18:45:12Z

Skips font install on serverless, pdf reporting is disabled
Moves tini and font download to stage 0
Removes curl install from Ubuntu stage 1

jbudz · 2024-05-13T18:49:35Z

buildkite test this

jbudz · 2024-05-13T21:11:44Z

buildkite test this

jbudz · 2024-05-13T22:17:00Z

src/dev/build/tasks/os_packages/docker_generator/templates/base/Dockerfile

@@ -79,44 +104,25 @@ RUN for iter in {1..10}; do \
      {{packageManager}} update  && \
      {{packageManager}} upgrade -y  && \
      {{packageManager}} install -y --no-install-recommends \
-       fontconfig fonts-liberation libnss3 libfontconfig1 ca-certificates curl && \


libfontconfig1 is already a dependency of fontconfig. fonts-liberation is superseded by the installed font NotoSansCJK.

@elastic/kibana-reporting-services any idea if I'm missing anything? I'm pretty sure we're okay, tests are passing and my manual checks lgtm.

docs at https://www.elastic.co/guide/en/kibana/current/secure-reporting.html#install-reporting-packages

cc @tsullivan - we both don't spot anything missing in the Dockerfile. Thank you!

elasticmachine · 2024-05-13T22:17:26Z

Pinging @elastic/kibana-operations (Team:Operations)

src/dev/build/tasks/os_packages/docker_generator/templates/base/Dockerfile

kibana-ci · 2024-05-14T17:28:52Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 782589a
Kibana UBI FIPS Image: docker.elastic.co/kibana-ci/kibana-ubi-fips:8.15.0-SNAPSHOT-782589a788abd316a75c60d1d62732cb70f20090
Cloud Deployment
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-183334-782589a788ab

Failed CI Steps

FTR Configs #97

Test Failures

[job] [logs] FTR Configs #97 / discover/esql discover esql view test should query an index pattern that doesnt translate to a dataview correctly

Metrics [docs]

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id	before	after	diff
`module count`	-	5407	+5407
`total size`	-	8.8MB	+8.8MB

History

💚 Build #209878 succeeded 4377765
💚 Build #209699 succeeded 8d40005
💔 Build #209677 failed 08e8b4f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2024-05-14T19:02:38Z

💔 All backports failed

Status	Branch	Result
❌	7.17	Backport failed because of merge conflicts You might need to backport the following PRs to 7.17: - [ci] Verify docker contexts (#122897)
❌	8.14	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 183334

Questions ?

Please refer to the Backport tool documentation

- Skips font install on serverless, pdf reporting is disabled - Moves tini and font download to stage 0 - Removes curl install from Ubuntu stage 1

#183334

jsoriano · 2024-05-16T09:18:42Z

Hey @jbudz,

We use curl in elastic-package for healtchecks, and builds have started to fail since the latest snapshots. I wonder if the removal of curl can also cause issues to users.

These are our healthchecks in elastic-package: https://github.com/elastic/elastic-package/blob/cf8e1c9d33068a4daa63032a49e3e51006fe9171/internal/stack/_static/kibana-healthcheck.sh.tmpl

If the decision of removing curl is not going to be reconsidered, what would be your recommendation? Should we do the healthchecks in a different way? Or we should create our own custom images with curl?

cc @elastic/ecosystem

jsoriano · 2024-05-16T09:33:17Z

Searching a bit in the Elastic org, it looks like curl is frequently used in healthchecks for Kibana: https://github.com/search?q=org%3Aelastic+curl+kibana+5601+health&type=code&p=1

This reverts commit 946e1b9.

This reverts commit a8f15df.

jbudz · 2024-05-16T11:20:59Z

Thanks for the ping. No problem, I reverted the backports and will re-add it to main. Linked issues are above.

@jsoriano

Partially reverts #183334. Some services using kibana as a base expect it to exist for running health checks. cc @jsoriano

jsoriano · 2024-05-16T17:02:27Z

Thanks @jbudz!

elastic#183334

This reverts commit a8f15df.

jbudz added 2 commits May 13, 2024 13:07

refactor

5caf869

fixes

08e8b4f

jbudz added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes ci:cloud-deploy Create or update a Cloud deployment ci:build-serverless-image labels May 13, 2024

fixes

8d40005

jbudz commented May 13, 2024

View reviewed changes

jbudz marked this pull request as ready for review May 13, 2024 22:17

jbudz requested a review from a team as a code owner May 13, 2024 22:17

Merge branch 'main' into cleanup-dockerfile

4377765

Ikuni17 reviewed May 14, 2024

View reviewed changes

src/dev/build/tasks/os_packages/docker_generator/templates/base/Dockerfile Show resolved Hide resolved

jbudz added the ci:build-docker-fips Build Docker FIPS image label May 14, 2024

Merge branch 'main' into cleanup-dockerfile

782589a

Ikuni17 approved these changes May 14, 2024

View reviewed changes

jbudz merged commit e2dd5ee into elastic:main May 14, 2024
23 checks passed

kibanamachine added the v8.15.0 label May 14, 2024

jbudz added backport:all-open Backport to all branches that could still receive a release and removed v8.15.0 labels May 14, 2024

kibanamachine added the v8.15.0 label May 14, 2024

jbudz added a commit to jbudz/kibana that referenced this pull request May 14, 2024

Cleanup dockerfile (elastic#183334)

b9de2f1

- Skips font install on serverless, pdf reporting is disabled - Moves tini and font download to stage 0 - Removes curl install from Ubuntu stage 1

jbudz mentioned this pull request May 14, 2024

[8.14] Cleanup dockerfile (#183334) #183438

Merged

jbudz added a commit to jbudz/kibana that referenced this pull request May 14, 2024

Cleanup dockerfile (elastic#183334)

ee53b1a

- Skips font install on serverless, pdf reporting is disabled - Moves tini and font download to stage 0 - Removes curl install from Ubuntu stage 1

jbudz mentioned this pull request May 14, 2024

[7.17] Cleanup dockerfile (#183334) #183440

Merged

kibanamachine mentioned this pull request May 14, 2024

Upgrade Node.js to v20.13.1 #183345

Merged

jbudz added a commit that referenced this pull request May 14, 2024

[8.14] Cleanup dockerfile (#183334) (#183438)

946e1b9

#183334

kibanamachine mentioned this pull request May 14, 2024

[build] Add image based on chainguard #183200

Merged

jbudz added a commit that referenced this pull request May 15, 2024

[7.17] Cleanup dockerfile (#183334) (#183440)

a8f15df

#183334

jbudz added a commit that referenced this pull request May 16, 2024

Revert "[8.14] Cleanup dockerfile (#183334) (#183438)"

c65d1b4

This reverts commit 946e1b9.

jbudz added a commit that referenced this pull request May 16, 2024

Revert "[7.17] Cleanup dockerfile (#183334) (#183440)"

f93d335

This reverts commit a8f15df.

jbudz mentioned this pull request May 16, 2024

[artifacts/container] Re-add curl #183626

Merged

jbudz added a commit that referenced this pull request May 16, 2024

[artifacts/container] Re-add curl (#183626)

b211842

Partially reverts #183334. Some services using kibana as a base expect it to exist for running health checks. cc @jsoriano

jsoriano mentioned this pull request May 17, 2024

[prometheus] Eliminate labels fingerprint elastic/integrations#9785

Merged

7 tasks

agithomas mentioned this pull request May 17, 2024

[Meta] [TSDB] Eliminate fingerprinting of dimensions and labels added as part of TSDB Enablement elastic/integrations#9910

Open

szaffarano mentioned this pull request Jul 12, 2024

[8.14] [Telemetry][Security Solution] Use the proper index to query builtin alerts (#187859) #188233

Closed

adelisle pushed a commit to Makila-AI/kibana that referenced this pull request Aug 5, 2024

[7.17] Cleanup dockerfile (elastic#183334) (elastic#183440)

5b2b6d3

elastic#183334

adelisle pushed a commit to Makila-AI/kibana that referenced this pull request Aug 5, 2024

Revert "[7.17] Cleanup dockerfile (elastic#183334) (elastic#183440)"

6ecd553

This reverts commit a8f15df.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup dockerfile #183334

Cleanup dockerfile #183334

jbudz commented May 13, 2024 •

edited by kibanamachine

Loading

jbudz commented May 13, 2024

jbudz commented May 13, 2024

jbudz May 13, 2024

jbudz May 13, 2024

rshen91 May 14, 2024

elasticmachine commented May 13, 2024

kibana-ci commented May 14, 2024 •

edited

Loading

kibanamachine commented May 14, 2024

jsoriano commented May 16, 2024 •

edited

Loading

jsoriano commented May 16, 2024

jbudz commented May 16, 2024

jsoriano commented May 16, 2024

Cleanup dockerfile #183334

Cleanup dockerfile #183334

Conversation

jbudz commented May 13, 2024 • edited by kibanamachine Loading

jbudz commented May 13, 2024

jbudz commented May 13, 2024

jbudz May 13, 2024

Choose a reason for hiding this comment

jbudz May 13, 2024

Choose a reason for hiding this comment

rshen91 May 14, 2024

Choose a reason for hiding this comment

elasticmachine commented May 13, 2024

kibana-ci commented May 14, 2024 • edited Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Canvas Sharable Runtime

History

kibanamachine commented May 14, 2024

💔 All backports failed

Manual backport

Questions ?

jsoriano commented May 16, 2024 • edited Loading

jsoriano commented May 16, 2024

jbudz commented May 16, 2024

jsoriano commented May 16, 2024

jbudz commented May 13, 2024 •

edited by kibanamachine

Loading

kibana-ci commented May 14, 2024 •

edited

Loading

jsoriano commented May 16, 2024 •

edited

Loading