Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embeddables Rebuild] Publish Phase Events #184445

Merged
merged 4 commits into from
May 29, 2024
Merged

[Embeddables Rebuild] Publish Phase Events #184445

merged 4 commits into from
May 29, 2024

Conversation

ThomThomson
Copy link
Contributor

Summary

Fixes #184443

This PR makes React Embeddables publish Phase events when they finish loading. This allows Dashboards with React Embeddables to properly fire phase events and report telemetry.

@ThomThomson
Copy link
Contributor Author

/ci

1 similar comment
@ThomThomson
Copy link
Contributor Author

/ci

@ThomThomson
Copy link
Contributor Author

/ci

@ThomThomson
Copy link
Contributor Author

/ci

@ThomThomson ThomThomson added loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Embeddables Relating to the Embeddable system labels May 29, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
presentationPanel 9.1KB 9.1KB -7.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 70.0KB 70.4KB +415.0B
presentationPanel 43.4KB 43.4KB -7.0B
total +408.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson marked this pull request as ready for review May 29, 2024 18:35
@ThomThomson ThomThomson requested a review from a team as a code owner May 29, 2024 18:35
@nickpeihl nickpeihl self-requested a review May 29, 2024 18:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

nickpeihl
nickpeihl approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

code review and tested with image embeddable and confirmed phase events are published

I have other concerns about the flakiness of dashboard event reporting, but it appears those are being addressed separately in #184061

@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label May 29, 2024
@ThomThomson ThomThomson merged commit 81d3e1a into elastic:main May 29, 2024
30 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Embeddables Relating to the Embeddable system Feature:Embedding Embedding content via iFrame impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Embeddables Rebuild] React Embeddables Cannot collect telemetry
5 participants
@ThomThomson @kibana-ci @elasticmachine @nickpeihl @kibanamachine