[Security Solution][Detection Engine] ML Cypress Improvements #186831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylnd
changed the title
|
/ci |
This commit contains a few improvements, cherry-picked from elastic#181926. Full context/details can be found there, but I'll try to summarize below: * ML form helpers receive normal rule parameters (instead of humanized job names) * Better starting state: deletes rules and stops ML jobs before test suite * Relaxed assertions: removes assertions that fail if there's more than one test in the environment (this is somewhat redundant with the previous improvement, but no harm in having both).
rylnd
force-pushed
the
ml_cypress_improvements
branch
from
906b70d to
8b3afa3
Compare
rylnd
changed the title
|
/ci |
|
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6381[✅] Security Solution Detection Engine - Cypress: 100/100 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6382[✅] [Serverless] Security Solution Detection Engine - Cypress: 100/100 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6385[✅] Security Solution Detection Engine - Cypress: 100/100 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6386[✅] [Serverless] Security Solution Detection Engine - Cypress: 100/100 tests passed. |
dhurley14
reviewed
Jun 25, 2024
x-pack/test/security_solution_cypress/cypress/support/machine_learning.ts
Outdated
Show resolved
Hide resolved
x-pack/test/security_solution_cypress/cypress/support/machine_learning.ts
Outdated
Show resolved
Hide resolved
x-pack/test/security_solution_cypress/cypress/support/machine_learning.ts
Outdated
Show resolved
Hide resolved
These were cherry-picked from the ML suppression branch, where they're used more fully. For now, we only use forceStopAndCloseJob to get a clean test state.
|
@dhurley14 I removed those unused helpers from this PR 👍 |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.15.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains a collection of fixes, mainly cherry-picked from #181926. Since some of these tests are failing sporadically on main, I'm opening this "test fix" PR for expedience while #181926 is still in review.
Checklist