[UII] Remove action links and buttons when secrets field is disabled #188252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jen-huang
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
jen-huang
changed the title
💚 Build Succeeded
Metrics [docs]Async chunks
cc @jen-huang |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 12, 2024
…lastic#188252) ## Summary Resolves elastic#187642 This PR removes action links and buttons to replace and convert secrets fields if the field itself is disabled, for cases like the user not having write permissions: <img width="730" alt="image" src="https://github.com/user-attachments/assets/957ad858-74bf-4f28-a212-148253e4ca0f"> <img width="716" alt="image" src="https://github.com/user-attachments/assets/d70f7946-8b62-4e13-9d16-98ddac26b826"> Also applies sentence casing to `Service token` label. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 4c0db61)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 12, 2024
…sabled (#188252) (#188258) # Backport This will backport the following commits from `main` to `8.15`: - [[UII] Remove action links and buttons when secrets field is disabled (#188252)](#188252) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jen Huang","email":"its.jenetic@gmail.com"},"sourceCommit":{"committedDate":"2024-07-12T18:31:16Z","message":"[UII] Remove action links and buttons when secrets field is disabled (#188252)\n\n## Summary\r\n\r\nResolves #187642 \r\n\r\nThis PR removes action links and buttons to replace and convert secrets\r\nfields if the field itself is disabled, for cases like the user not\r\nhaving write permissions:\r\n\r\n<img width=\"730\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/957ad858-74bf-4f28-a212-148253e4ca0f\">\r\n\r\n<img width=\"716\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/d70f7946-8b62-4e13-9d16-98ddac26b826\">\r\n\r\nAlso applies sentence casing to `Service token` label.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"4c0db61e6d92ada57833471a33daa5eb40c38e44","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v8.16.0"],"title":"[UII] Remove action links and buttons when secrets field is disabled","number":188252,"url":"https://github.com/elastic/kibana/pull/188252","mergeCommit":{"message":"[UII] Remove action links and buttons when secrets field is disabled (#188252)\n\n## Summary\r\n\r\nResolves #187642 \r\n\r\nThis PR removes action links and buttons to replace and convert secrets\r\nfields if the field itself is disabled, for cases like the user not\r\nhaving write permissions:\r\n\r\n<img width=\"730\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/957ad858-74bf-4f28-a212-148253e4ca0f\">\r\n\r\n<img width=\"716\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/d70f7946-8b62-4e13-9d16-98ddac26b826\">\r\n\r\nAlso applies sentence casing to `Service token` label.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"4c0db61e6d92ada57833471a33daa5eb40c38e44"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188252","number":188252,"mergeCommit":{"message":"[UII] Remove action links and buttons when secrets field is disabled (#188252)\n\n## Summary\r\n\r\nResolves #187642 \r\n\r\nThis PR removes action links and buttons to replace and convert secrets\r\nfields if the field itself is disabled, for cases like the user not\r\nhaving write permissions:\r\n\r\n<img width=\"730\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/957ad858-74bf-4f28-a212-148253e4ca0f\">\r\n\r\n<img width=\"716\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/d70f7946-8b62-4e13-9d16-98ddac26b826\">\r\n\r\nAlso applies sentence casing to `Service token` label.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"4c0db61e6d92ada57833471a33daa5eb40c38e44"}}]}] BACKPORT--> Co-authored-by: Jen Huang <its.jenetic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #187642
This PR removes action links and buttons to replace and convert secrets fields if the field itself is disabled, for cases like the user not having write permissions:
Also applies sentence casing to
Service tokenlabel.Checklist