Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Unskip time zone test #190116

Merged
merged 2 commits into from
Aug 8, 2024
Merged

[Discover] Unskip time zone test #190116

merged 2 commits into from
Aug 8, 2024

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Aug 8, 2024 •
edited by kibanamachine
Loading

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Aug 8, 2024
@jughosta jughosta self-assigned this Aug 8, 2024
@jughosta
Copy link
Contributor Author

jughosta commented Aug 8, 2024

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6717

[✅] x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group5.ts: 25/25 tests passed.
[✅] test/functional/apps/discover/group1/config.ts: 25/25 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group5.ts: 25/25 tests passed.

see run history

@jughosta jughosta marked this pull request as ready for review August 8, 2024 13:01
@jughosta jughosta requested a review from a team as a code owner August 8, 2024 13:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@jughosta jughosta enabled auto-merge (squash) August 8, 2024 14:45
davismcphee
davismcphee approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@jughosta jughosta merged commit 6a8b950 into elastic:main Aug 8, 2024
22 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 8, 2024
@jughosta
[Discover] Unskip time zone test (elastic#190116)
11a295a 
- Closes elastic#189943
- Closes elastic#190058

(cherry picked from commit 6a8b950)
@kibanamachine kibanamachine mentioned this pull request Aug 8, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 8, 2024
@kibanamachine @jughosta
[8.15] [Discover] Unskip time zone test (#190116) (#190181)
7eeabc3 
# Backport

This will backport the following commits from `main` to `8.15`:
- [[Discover] Unskip time zone test
(#190116)](#190116)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2024-08-08T19:16:49Z","message":"[Discover]
Unskip time zone test (#190116)\n\n- Closes
https://github.com/elastic/kibana/issues/189943\r\n- Closes
https://github.com/elastic/kibana/issues/190058","sha":"6a8b9505b85b8f6f0a9b4021fd5835b63b47d3b7","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.16.0"],"title":"[Discover]
Unskip time zone
test","number":190116,"url":"https://github.com/elastic/kibana/pull/190116","mergeCommit":{"message":"[Discover]
Unskip time zone test (#190116)\n\n- Closes
https://github.com/elastic/kibana/issues/189943\r\n- Closes
https://github.com/elastic/kibana/issues/190058","sha":"6a8b9505b85b8f6f0a9b4021fd5835b63b47d3b7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190116","number":190116,"mergeCommit":{"message":"[Discover]
Unskip time zone test (#190116)\n\n- Closes
https://github.com/elastic/kibana/issues/189943\r\n- Closes
https://github.com/elastic/kibana/issues/190058","sha":"6a8b9505b85b8f6f0a9b4021fd5835b63b47d3b7"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

Assignees

@jughosta jughosta

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.15.0 v8.16.0
Projects
None yet
Milestone
No milestone
5 participants
@jughosta @kibanamachine @elasticmachine @kibana-ci @davismcphee