[ResponseOps] Fix scss deprecation issue #190948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcoelho
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
@petrklapka It seems opting into the new |
Hey @adcoelho! I believe what you want to do is keep whatever the current behavior is once the SASS deprecation happens in a future version. In order to do that, you want to swap the rule and declaration order. Check out what Vadim did here for his fix. |
ryankeairns
approved these changes
Aug 21, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @adcoelho |
ryankeairns
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190927
Summary
This pr fixes a small deprecation issue after the SASS upgrade. I opted into the new syntax.