Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Full FTR, Integration, and Unit tests to the FIPS Test Pipeline #192632

Merged
merged 59 commits into from
Nov 19, 2024
Merged

Enabling Full FTR, Integration, and Unit tests to the FIPS Test Pipeline #192632

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
77697db
Replacing smoke test step with FTR pick order step
kc13greiner Sep 11, 2024
35fa148
Adding unit and integration
kc13greiner Sep 11, 2024
ec83314
Update .buildkite/pipelines/fips.yml
kc13greiner Sep 11, 2024
c54e919
Removing extra args env var
kc13greiner Oct 1, 2024
07b21c0
removing config limitations
kc13greiner Oct 1, 2024
f43f7d5
Merge branch 'main' into feature/Run_Full_FIPS_FTR
kc13greiner Oct 1, 2024
4fe0825
adding extra functions back
kc13greiner Oct 1, 2024
ddab617
Skipping new failing tests
kc13greiner Oct 2, 2024
4fe127d
Merge branch 'main' into feature/Run_Full_FIPS_FTR
kc13greiner Oct 2, 2024
d33488d
Update fips.yml to include jest
kc13greiner Oct 2, 2024
6daa6c8
attempting to add fips node options cmd line args
kc13greiner Oct 2, 2024
17ba872
Correcting node options to the front
kc13greiner Oct 2, 2024
83766b6
trying diff hash alg
kc13greiner Oct 3, 2024
b2b354b
testing change to signing/digest algorithm, skipping known issues
kc13greiner Oct 3, 2024
dfd9154
Switching hash back and changing curve
kc13greiner Oct 4, 2024
c17e569
trying PEM instead of DER
kc13greiner Oct 4, 2024
001651c
Trying different cipher on pk
kc13greiner Oct 4, 2024
67d8092
cipher threw unsupported envelope, try w/o cipher for now
kc13greiner Oct 4, 2024
e0f7ebc
switching back to DER with the cipher
kc13greiner Oct 4, 2024
8aaf935
adding initialization to ensure its the proper len
kc13greiner Oct 4, 2024
1f93c2f
already imported
kc13greiner Oct 4, 2024
7feec4f
Trying longer rsa
kc13greiner Oct 4, 2024
4cc907e
Attempting to log ciphers to see what is available
kc13greiner Oct 5, 2024
af02d5b
comma
kc13greiner Oct 5, 2024
6a9d171
Clearing up other errors to focus on signing
kc13greiner Oct 6, 2024
0046e88
Flipping condition
kc13greiner Oct 6, 2024
bf5113f
removing log
kc13greiner Oct 6, 2024
7158794
Testing original
kc13greiner Oct 7, 2024
20d4b7b
Commenting out scryptParams
kc13greiner Oct 7, 2024
412a745
Merge branch 'main' into feature/Run_Full_FIPS_FTR
kc13greiner Oct 7, 2024
a863849
Temporary hotfixes to test integration tests in pipeline
kc13greiner Oct 10, 2024
aed8025
import disappeared
kc13greiner Oct 10, 2024
c796660
Merge branch 'main' into feature/Run_Full_FIPS_FTR
kc13greiner Oct 10, 2024
52b5f3c
Merge branch 'main' into feature/Run_Full_FIPS_FTR
kc13greiner Oct 11, 2024
f1504ac
More override tests
kc13greiner Oct 15, 2024
2b5a712
Moving fips config
kc13greiner Oct 15, 2024
29a79db
Skipping PKCS12 and MD5 fs tests
kc13greiner Oct 16, 2024
ae4293e
Fix for unused config issue
kc13greiner Oct 16, 2024
36da348
Dont register
kc13greiner Oct 17, 2024
3e078fa
disable oss in FIPS mode, revert security service, clean up other ove…
kc13greiner Oct 25, 2024
e620cf2
clean up
kc13greiner Oct 25, 2024
608b2f9
Merge branch 'main' into feature/Run_Full_FIPS_FTR
kc13greiner Oct 25, 2024
7d840a4
adding back trial license since some calls don't use the servers factory
kc13greiner Oct 25, 2024
be62e5e
Merge branch 'main' into feature/Run_Full_FIPS_FTR
kc13greiner Oct 30, 2024
2ce8759
Skipping data archive test
kc13greiner Nov 4, 2024
f290b6e
Changing some fips test overrides and skipping some tests
kc13greiner Nov 5, 2024
b2a38ab
Last skips and fixing trial/es overrides for fips
kc13greiner Nov 6, 2024
d444894
skipping serverless test due to overrieds
kc13greiner Nov 7, 2024
f6829f6
Merge branch 'main' into feature/Run_Full_FIPS_FTR
kc13greiner Nov 7, 2024
cf928c8
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine Nov 7, 2024
84fa1aa
ensuring there is only 1 oss on the cli
kc13greiner Nov 8, 2024
7454e8a
Merge branch 'main' into feature/Run_Full_FIPS_FTR
kc13greiner Nov 8, 2024
08561e4
Fixing test license type
kc13greiner Nov 8, 2024
e4b6636
Adding comment to clarify test license usage
kc13greiner Nov 11, 2024
c362dd7
PR feedback
kc13greiner Nov 13, 2024
abff161
Update .buildkite/scripts/steps/test/jest_parallel.sh
kc13greiner Nov 13, 2024
7a8ce60
Merge branch 'main' into feature/Run_Full_FIPS_FTR
kc13greiner Nov 13, 2024
a8be638
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine Nov 13, 2024
95969a9
Merge branch 'main' into feature/Run_Full_FIPS_FTR
legrego Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .buildkite/pipelines/fips.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,16 @@ steps:
machineType: n2-standard-2
preemptible: true

- command: .buildkite/scripts/steps/fips/smoke_test.sh
label: 'Pick Smoke Test Group Run Order'
- command: .buildkite/scripts/steps/test/pick_test_group_run_order.sh
label: 'Pick Test Group Run Order'
depends_on: build
timeout_in_minutes: 10
env:
FTR_CONFIGS_SCRIPT: '.buildkite/scripts/steps/test/ftr_configs.sh'
FTR_EXTRA_ARGS: '$FTR_EXTRA_ARGS'
LIMIT_CONFIG_TYPE: 'functional'
kc13greiner marked this conversation as resolved.
Show resolved Hide resolved
JEST_UNIT_SCRIPT: '.buildkite/scripts/steps/test/jest.sh'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like these will run with FIPS enabled.

kibana/.buildkite/scripts/common/env.sh

Lines 143 to 146 in 833a267

if [[ -f "$KIBANA_DIR/config/node.options" ]]; then
echo -e '\n--enable-fips' >>"$KIBANA_DIR/config/node.options"
echo "--openssl-config=$HOME/nodejs.cnf" >>"$KIBANA_DIR/config/node.options"
fi
is configuring distributions

NODE_OPTIONS for jest at

kibana/.buildkite/scripts/steps/test/jest_parallel.sh

Line 63 in 833a267

cmd="NODE_OPTIONS=\"--max-old-space-size=12288 --trace-warnings\" node ./scripts/jest --config=\"$config\" $parallelism --coverage=false --passWithNoTests"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I think I have it setup properly now!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI in progress: https://buildkite.com/elastic/kibana-fips/builds/197#01924db0-7734-405c-bc8c-c26facdcbb60

JEST_INTEGRATION_SCRIPT: '.buildkite/scripts/steps/test/jest_integration.sh'
retry:
automatic:
- exit_status: '*'
Expand Down
24 changes: 0 additions & 24 deletions .buildkite/scripts/steps/fips/smoke_test.sh
View file
Open in desktop

This file was deleted.