Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] Add remote_indices to autocomplete overrides #193403

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[Console] Add remote_indices to autocomplete overrides #193403

merged 1 commit into from
Sep 20, 2024

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Sep 19, 2024 •
edited by kibanamachine
Loading

Summary

Closes #188608 by adding "remote_indices" to the Create or update roles API. I'm not adding remote_cluster because it's not documented, and I don't know yet if it's on purpose or not. As remote_indices was also missing from the Elasticsearch specification, I opened elastic/elasticsearch-specification#2915 too.

Screenshots

Screenshot 2024-09-19 at 14 07 07 Screenshot 2024-09-19 at 14 07 33

For maintainers

@pquentin pquentin added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 labels Sep 19, 2024
@pquentin pquentin requested a review from a team as a code owner September 19, 2024 10:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #54 / console app console onboarding tour allows re-running the tour

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sabarasaba
sabarasaba approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, thanks @pquentin!

@pquentin pquentin merged commit 5a034e9 into elastic:main Sep 20, 2024
30 checks passed
@pquentin pquentin deleted the security-put-role-remote-indices branch September 20, 2024 10:59
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 20, 2024
@pquentin
[Console] Add remote_indices to autocomplete overrides (elastic#193403)
34b0760 
## Summary

Closes elastic#188608 by adding
"remote_indices" to the Create or update roles API. I'm not adding
`remote_cluster` because it's not documented, and I don't know yet if
it's on purpose or not. As `remote_indices` was also missing from the
Elasticsearch specification, I opened
elastic/elasticsearch-specification#2915 too.

## Screenshots

<img width="561" alt="Screenshot 2024-09-19 at 14 07 07"
src="https://github.com/user-attachments/assets/172a4c54-335c-43f7-a899-5b84bb4fd2da">

<img width="591" alt="Screenshot 2024-09-19 at 14 07 33"
src="https://github.com/user-attachments/assets/e57c20c3-6acf-4ede-8f79-e388f90e4104">

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 5a034e9)
@kibanamachine kibanamachine mentioned this pull request Sep 20, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Sep 20, 2024
Merged
kibanamachine added a commit that referenced this pull request Sep 20, 2024
@kibanamachine @pquentin
[8.x] [Console] Add remote_indices to autocomplete overrides (#193403) (
d8a35bc 
#193538)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Console] Add remote_indices to autocomplete overrides
(#193403)](#193403)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Quentin
Pradet","email":"quentin.pradet@elastic.co"},"sourceCommit":{"committedDate":"2024-09-20T10:59:37Z","message":"[Console]
Add remote_indices to autocomplete overrides (#193403)\n\n##
Summary\r\n\r\nCloses #188608 by
adding\r\n\"remote_indices\" to the Create or update roles API. I'm not
adding\r\n`remote_cluster` because it's not documented, and I don't know
yet if\r\nit's on purpose or not. As `remote_indices` was also missing
from the\r\nElasticsearch specification, I
opened\r\nhttps://github.com/elastic/elasticsearch-specification/pull/2915
too.\r\n\r\n## Screenshots\r\n\r\n<img width=\"561\" alt=\"Screenshot
2024-09-19 at 14 07
07\"\r\nsrc=\"https://github.com/user-attachments/assets/172a4c54-335c-43f7-a899-5b84bb4fd2da\">\r\n\r\n<img
width=\"591\" alt=\"Screenshot 2024-09-19 at 14 07
33\"\r\nsrc=\"https://github.com/user-attachments/assets/e57c20c3-6acf-4ede-8f79-e388f90e4104\">\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"5a034e9268620f3d757272599e584a3ec4da24fc","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Console]
Add remote_indices to autocomplete
overrides","number":193403,"url":"https://github.com/elastic/kibana/pull/193403","mergeCommit":{"message":"[Console]
Add remote_indices to autocomplete overrides (#193403)\n\n##
Summary\r\n\r\nCloses #188608 by
adding\r\n\"remote_indices\" to the Create or update roles API. I'm not
adding\r\n`remote_cluster` because it's not documented, and I don't know
yet if\r\nit's on purpose or not. As `remote_indices` was also missing
from the\r\nElasticsearch specification, I
opened\r\nhttps://github.com/elastic/elasticsearch-specification/pull/2915
too.\r\n\r\n## Screenshots\r\n\r\n<img width=\"561\" alt=\"Screenshot
2024-09-19 at 14 07
07\"\r\nsrc=\"https://github.com/user-attachments/assets/172a4c54-335c-43f7-a899-5b84bb4fd2da\">\r\n\r\n<img
width=\"591\" alt=\"Screenshot 2024-09-19 at 14 07
33\"\r\nsrc=\"https://github.com/user-attachments/assets/e57c20c3-6acf-4ede-8f79-e388f90e4104\">\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"5a034e9268620f3d757272599e584a3ec4da24fc"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193403","number":193403,"mergeCommit":{"message":"[Console]
Add remote_indices to autocomplete overrides (#193403)\n\n##
Summary\r\n\r\nCloses #188608 by
adding\r\n\"remote_indices\" to the Create or update roles API. I'm not
adding\r\n`remote_cluster` because it's not documented, and I don't know
yet if\r\nit's on purpose or not. As `remote_indices` was also missing
from the\r\nElasticsearch specification, I
opened\r\nhttps://github.com/elastic/elasticsearch-specification/pull/2915
too.\r\n\r\n## Screenshots\r\n\r\n<img width=\"561\" alt=\"Screenshot
2024-09-19 at 14 07
07\"\r\nsrc=\"https://github.com/user-attachments/assets/172a4c54-335c-43f7-a899-5b84bb4fd2da\">\r\n\r\n<img
width=\"591\" alt=\"Screenshot 2024-09-19 at 14 07
33\"\r\nsrc=\"https://github.com/user-attachments/assets/e57c20c3-6acf-4ede-8f79-e388f90e4104\">\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"5a034e9268620f3d757272599e584a3ec4da24fc"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabarasaba sabarasaba sabarasaba approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DevTools][Console] Autocomplete missing suggestion in _security/role
5 participants
@pquentin @elasticmachine @kibana-ci @kibanamachine @sabarasaba