Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Makes the entire feedback div clickable #194277

Merged
merged 1 commit into from
Sep 27, 2024
Merged

[ES|QL] Makes the entire feedback div clickable #194277

merged 1 commit into from
Sep 27, 2024

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Sep 27, 2024 •
edited by kibanamachine
Loading

Summary

Closes #193956

Makes the entire feedback area clickable.

@stratoula stratoula changed the title [ES|QL] Make the entire feedback div clickable [ES|QL] Makes the entire feedback div clickable Sep 27, 2024
@stratoula
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 178.4KB 178.4KB +34.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v9.0.0 v8.16.0 labels Sep 27, 2024
@stratoula stratoula marked this pull request as ready for review September 27, 2024 12:24
@stratoula stratoula requested a review from a team as a code owner September 27, 2024 12:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

drewdaemon
drewdaemon approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the little things...

@stratoula stratoula merged commit 2ec24f2 into elastic:main Sep 27, 2024
33 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11073694767

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 27, 2024
@stratoula
[ES|QL] Makes the entire feedback div clickable (elastic#194277)
83526f1 
## Summary

Closes elastic#193956

Makes the entire feedback area clickable.

(cherry picked from commit 2ec24f2)
@kibanamachine kibanamachine mentioned this pull request Sep 27, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 27, 2024
@kibanamachine @stratoula
[8.x] [ES|QL] Makes the entire feedback div clickable (#194277) (#194320
6df7d26 
)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Makes the entire feedback div clickable
(#194277)](#194277)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2024-09-27T15:47:58Z","message":"[ES|QL]
Makes the entire feedback div clickable (#194277)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/193956\r\n\r\nMakes the entire
feedback area
clickable.","sha":"2ec24f2f48b67a1c928fa6edb84214de57b59dd2","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL","v8.16.0"],"title":"[ES|QL]
Makes the entire feedback div
clickable","number":194277,"url":"https://github.com/elastic/kibana/pull/194277","mergeCommit":{"message":"[ES|QL]
Makes the entire feedback div clickable (#194277)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/193956\r\n\r\nMakes the entire
feedback area
clickable.","sha":"2ec24f2f48b67a1c928fa6edb84214de57b59dd2"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194277","number":194277,"mergeCommit":{"message":"[ES|QL]
Makes the entire feedback div clickable (#194277)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/193956\r\n\r\nMakes the entire
feedback area
clickable.","sha":"2ec24f2f48b67a1c928fa6edb84214de57b59dd2"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewdaemon drewdaemon drewdaemon approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ES|QL] Inconsistent cursor behaviour for editor footer links
5 participants
@stratoula @kibana-ci @elasticmachine @kibanamachine @drewdaemon