[Automatic Import] Fix Non-ecs compatible fields in grok processor #194727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhapas
added
bug
|
Pinging @elastic/security-scalability (Team:Security-Scalability) |
bhapas
force-pushed
the
automatic_import_grok_fixes
branch
from
51037d7 to
c7b1623
Compare
P1llus
approved these changes
Oct 3, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @bhapas |
|
Starting backport for target branches: 8.15, 8.x https://github.com/elastic/kibana/actions/runs/11159221243 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 3, 2024
…lastic#194727) ## Release Note Fixes a bug to resolve non-ecs compatible fields in Structured / Unstructured syslog processing in Automatic Import. ## Summary elastic#194205 explains the issue. This PR fixes `packageName.dataStreamName` for handling header values from grok processor for KV graph so that ecs mapping gets the header values in the converted json Samples too.. ### Before this PR  ### After this PR <img width="706" alt="image" src="https://github.com/user-attachments/assets/954b5a91-2123-46f9-b822-1709c3247901"> - Closes elastic#194205 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit b38941b)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 3, 2024
…lastic#194727) ## Release Note Fixes a bug to resolve non-ecs compatible fields in Structured / Unstructured syslog processing in Automatic Import. ## Summary elastic#194205 explains the issue. This PR fixes `packageName.dataStreamName` for handling header values from grok processor for KV graph so that ecs mapping gets the header values in the converted json Samples too.. ### Before this PR  ### After this PR <img width="706" alt="image" src="https://github.com/user-attachments/assets/954b5a91-2123-46f9-b822-1709c3247901"> - Closes elastic#194205 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit b38941b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 3, 2024
…ssor (#194727) (#194792) # Backport This will backport the following commits from `main` to `8.15`: - [[Automatic Import] Fix Non-ecs compatible fields in grok processor (#194727)](#194727) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bharat Pasupula","email":"123897612+bhapas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-03T09:14:39Z","message":"[Automatic Import] Fix Non-ecs compatible fields in grok processor (#194727)\n\n## Release Note\r\n\r\nFixes a bug to resolve non-ecs compatible fields in Structured /\r\nUnstructured syslog processing in Automatic Import.\r\n\r\n## Summary\r\n\r\nhttps://github.com//issues/194205 explains the issue. \r\n\r\nThis PR fixes `packageName.dataStreamName` for handling header values\r\nfrom grok processor for KV graph so that ecs mapping gets the header\r\nvalues in the converted json Samples too..\r\n\r\n### Before this PR\r\n\r\n\r\n\r\n\r\n### After this PR\r\n\r\n<img width=\"706\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/954b5a91-2123-46f9-b822-1709c3247901\">\r\n\r\n\r\n- Closes https://github.com/elastic/kibana/issues/194205\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"b38941be7a253c80d426a49af806575ba15652a5","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-major","Team:Security-Scalability","Feature:AutomaticImport"],"title":"[Automatic Import] Fix Non-ecs compatible fields in grok processor","number":194727,"url":"https://github.com/elastic/kibana/pull/194727","mergeCommit":{"message":"[Automatic Import] Fix Non-ecs compatible fields in grok processor (#194727)\n\n## Release Note\r\n\r\nFixes a bug to resolve non-ecs compatible fields in Structured /\r\nUnstructured syslog processing in Automatic Import.\r\n\r\n## Summary\r\n\r\nhttps://github.com//issues/194205 explains the issue. \r\n\r\nThis PR fixes `packageName.dataStreamName` for handling header values\r\nfrom grok processor for KV graph so that ecs mapping gets the header\r\nvalues in the converted json Samples too..\r\n\r\n### Before this PR\r\n\r\n\r\n\r\n\r\n### After this PR\r\n\r\n<img width=\"706\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/954b5a91-2123-46f9-b822-1709c3247901\">\r\n\r\n\r\n- Closes https://github.com/elastic/kibana/issues/194205\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"b38941be7a253c80d426a49af806575ba15652a5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194727","number":194727,"mergeCommit":{"message":"[Automatic Import] Fix Non-ecs compatible fields in grok processor (#194727)\n\n## Release Note\r\n\r\nFixes a bug to resolve non-ecs compatible fields in Structured /\r\nUnstructured syslog processing in Automatic Import.\r\n\r\n## Summary\r\n\r\nhttps://github.com//issues/194205 explains the issue. \r\n\r\nThis PR fixes `packageName.dataStreamName` for handling header values\r\nfrom grok processor for KV graph so that ecs mapping gets the header\r\nvalues in the converted json Samples too..\r\n\r\n### Before this PR\r\n\r\n\r\n\r\n\r\n### After this PR\r\n\r\n<img width=\"706\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/954b5a91-2123-46f9-b822-1709c3247901\">\r\n\r\n\r\n- Closes https://github.com/elastic/kibana/issues/194205\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"b38941be7a253c80d426a49af806575ba15652a5"}}]}] BACKPORT--> Co-authored-by: Bharat Pasupula <123897612+bhapas@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Oct 3, 2024
…sor (#194727) (#194793) # Backport This will backport the following commits from `main` to `8.x`: - [[Automatic Import] Fix Non-ecs compatible fields in grok processor (#194727)](#194727) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bharat Pasupula","email":"123897612+bhapas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-03T09:14:39Z","message":"[Automatic Import] Fix Non-ecs compatible fields in grok processor (#194727)\n\n## Release Note\r\n\r\nFixes a bug to resolve non-ecs compatible fields in Structured /\r\nUnstructured syslog processing in Automatic Import.\r\n\r\n## Summary\r\n\r\nhttps://github.com//issues/194205 explains the issue. \r\n\r\nThis PR fixes `packageName.dataStreamName` for handling header values\r\nfrom grok processor for KV graph so that ecs mapping gets the header\r\nvalues in the converted json Samples too..\r\n\r\n### Before this PR\r\n\r\n\r\n\r\n\r\n### After this PR\r\n\r\n<img width=\"706\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/954b5a91-2123-46f9-b822-1709c3247901\">\r\n\r\n\r\n- Closes https://github.com/elastic/kibana/issues/194205\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"b38941be7a253c80d426a49af806575ba15652a5","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-major","Team:Security-Scalability","Feature:AutomaticImport"],"title":"[Automatic Import] Fix Non-ecs compatible fields in grok processor","number":194727,"url":"https://github.com/elastic/kibana/pull/194727","mergeCommit":{"message":"[Automatic Import] Fix Non-ecs compatible fields in grok processor (#194727)\n\n## Release Note\r\n\r\nFixes a bug to resolve non-ecs compatible fields in Structured /\r\nUnstructured syslog processing in Automatic Import.\r\n\r\n## Summary\r\n\r\nhttps://github.com//issues/194205 explains the issue. \r\n\r\nThis PR fixes `packageName.dataStreamName` for handling header values\r\nfrom grok processor for KV graph so that ecs mapping gets the header\r\nvalues in the converted json Samples too..\r\n\r\n### Before this PR\r\n\r\n\r\n\r\n\r\n### After this PR\r\n\r\n<img width=\"706\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/954b5a91-2123-46f9-b822-1709c3247901\">\r\n\r\n\r\n- Closes https://github.com/elastic/kibana/issues/194205\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"b38941be7a253c80d426a49af806575ba15652a5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194727","number":194727,"mergeCommit":{"message":"[Automatic Import] Fix Non-ecs compatible fields in grok processor (#194727)\n\n## Release Note\r\n\r\nFixes a bug to resolve non-ecs compatible fields in Structured /\r\nUnstructured syslog processing in Automatic Import.\r\n\r\n## Summary\r\n\r\nhttps://github.com//issues/194205 explains the issue. \r\n\r\nThis PR fixes `packageName.dataStreamName` for handling header values\r\nfrom grok processor for KV graph so that ecs mapping gets the header\r\nvalues in the converted json Samples too..\r\n\r\n### Before this PR\r\n\r\n\r\n\r\n\r\n### After this PR\r\n\r\n<img width=\"706\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/954b5a91-2123-46f9-b822-1709c3247901\">\r\n\r\n\r\n- Closes https://github.com/elastic/kibana/issues/194205\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"b38941be7a253c80d426a49af806575ba15652a5"}}]}] BACKPORT--> Co-authored-by: Bharat Pasupula <123897612+bhapas@users.noreply.github.com>
tiansivive
pushed a commit
to tiansivive/kibana
that referenced
this pull request
Oct 7, 2024
…lastic#194727) ## Release Note Fixes a bug to resolve non-ecs compatible fields in Structured / Unstructured syslog processing in Automatic Import. ## Summary elastic#194205 explains the issue. This PR fixes `packageName.dataStreamName` for handling header values from grok processor for KV graph so that ecs mapping gets the header values in the converted json Samples too.. ### Before this PR  ### After this PR <img width="706" alt="image" src="https://github.com/user-attachments/assets/954b5a91-2123-46f9-b822-1709c3247901"> - Closes elastic#194205 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note
Fixes a bug to resolve non-ecs compatible fields in Structured / Unstructured syslog processing in Automatic Import.
Summary
#194205 explains the issue.
This PR fixes
packageName.dataStreamNamefor handling header values from grok processor for KV graph so that ecs mapping gets the header values in the converted json Samples too..Before this PR
After this PR
Checklist
Delete any items that are not applicable to this PR.