Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Obs AI Assistant] Attempt to resolve flaky knowledge based user instructions test #196026

Merged
merged 8 commits into from
Oct 31, 2024
Merged

[Obs AI Assistant] Attempt to resolve flaky knowledge based user instructions test #196026

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8082223
[Obs AI Assistant] Unskip test (#192222)
viduni94 Oct 13, 2024
4dba274
[Obs AI Assistant] Add a delay to let the data settle before running …
viduni94 Oct 14, 2024
21888c0
[Obs AI Assistant] Retry creating entries if any entry is missing (#1…
viduni94 Oct 25, 2024
d59a1f6
[Obs AI Assistant] Address PR comments (#192222)
viduni94 Oct 27, 2024
7e6094f
[Obs AI Assistant] Fix type (#192222)
viduni94 Oct 27, 2024
89a864e
[Obs AI Assistant] Update type any (#192222)
viduni94 Oct 31, 2024
042b9ea
[Obs AI Assistant] Remove the retry statements (#192222)
viduni94 Oct 31, 2024
833db6d
[Obs AI Assistant] Remove the retry statements (#192222)
viduni94 Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions ...i_assistant_api_integration/tests/knowledge_base/knowledge_base_user_instructions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { kbnTestConfig } from '@kbn/test';
import { sortBy } from 'lodash';
import { Message, MessageRole } from '@kbn/observability-ai-assistant-plugin/common';
import { CONTEXT_FUNCTION_NAME } from '@kbn/observability-ai-assistant-plugin/server/functions/context';
import { Instruction } from '@kbn/observability-ai-assistant-plugin/common/types';
import { FtrProviderContext } from '../../common/ftr_provider_context';
import {
clearConversations,
Expand Down Expand Up @@ -51,8 +52,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
await clearConversations(es);
});

// FLAKY: https://github.com/elastic/kibana/issues/192222
describe.skip('when creating private and public user instructions', () => {
describe('when creating private and public user instructions', () => {
before(async () => {
await clearKnowledgeBase(es);

Expand All @@ -75,6 +75,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
},
].map(async ({ username, isPublic }) => {
const visibility = isPublic ? 'Public' : 'Private';

await getScopedApiClientForUsername(username)({
endpoint: 'PUT /internal/observability_ai_assistant/kb/user_instructions',
params: {
Expand All @@ -94,9 +95,12 @@ export default function ApiTest({ getService }: FtrProviderContext) {
const res = await observabilityAIAssistantAPIClient.editorUser({
endpoint: 'GET /internal/observability_ai_assistant/kb/user_instructions',
});

const instructions = res.body.userInstructions;

const sortByDocId = (data: any) => sortBy(data, 'doc_id');
const sortByDocId = (data: Array<Instruction & { public?: boolean }>) =>
sortBy(data, 'doc_id');

expect(sortByDocId(instructions)).to.eql(
sortByDocId([
{
Expand Down Expand Up @@ -124,7 +128,9 @@ export default function ApiTest({ getService }: FtrProviderContext) {
});
const instructions = res.body.userInstructions;

const sortByDocId = (data: any) => sortBy(data, 'doc_id');
const sortByDocId = (data: Array<Instruction & { public?: boolean }>) =>
sortBy(data, 'doc_id');

expect(sortByDocId(instructions)).to.eql(
sortByDocId([
{
Expand Down