[Drilldowns] Fix drilldown add variable adding additional brackets #196539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kowalczyk-krzysztof
added
bug
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
sebelga
approved these changes
Oct 17, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11382492085 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 17, 2024
…lastic#196539) ## Summary This PR adds a check to create/edit drilldown template editor for whether the cursor (where variable would be inserted) is already between double brackets. Fixes: elastic#121421 (cherry picked from commit 3c3b7c8)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 17, 2024
…ets (#196539) (#196655) # Backport This will backport the following commits from `main` to `8.x`: - [[Drilldowns] Fix drilldown add variable adding additional brackets (#196539)](#196539) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Krzysztof Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2024-10-17T09:46:53Z","message":"[Drilldowns] Fix drilldown add variable adding additional brackets (#196539)\n\n## Summary\r\n\r\nThis PR adds a check to create/edit drilldown template editor for\r\nwhether the cursor (where variable would be inserted) is already between\r\ndouble brackets.\r\n\r\nFixes: #121421","sha":"3c3b7c8ecb97961d98f7760cb90f25e2937c623d","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Feature:Drilldowns","v9.0.0","Team:SharedUX","backport:prev-minor"],"title":"[Drilldowns] Fix drilldown add variable adding additional brackets","number":196539,"url":"https://github.com/elastic/kibana/pull/196539","mergeCommit":{"message":"[Drilldowns] Fix drilldown add variable adding additional brackets (#196539)\n\n## Summary\r\n\r\nThis PR adds a check to create/edit drilldown template editor for\r\nwhether the cursor (where variable would be inserted) is already between\r\ndouble brackets.\r\n\r\nFixes: #121421","sha":"3c3b7c8ecb97961d98f7760cb90f25e2937c623d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196539","number":196539,"mergeCommit":{"message":"[Drilldowns] Fix drilldown add variable adding additional brackets (#196539)\n\n## Summary\r\n\r\nThis PR adds a check to create/edit drilldown template editor for\r\nwhether the cursor (where variable would be inserted) is already between\r\ndouble brackets.\r\n\r\nFixes: #121421","sha":"3c3b7c8ecb97961d98f7760cb90f25e2937c623d"}}]}] BACKPORT--> Co-authored-by: Krzysztof Kowalczyk <krzysztof.kowalczyk@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a check to create/edit drilldown template editor for whether the cursor (where variable would be inserted) is already between double brackets.
Fixes: #121421