[Dashboard][ES|QL] Allow creating a dashboard with ES|QL chart even when there are no dataviews #196658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
changed the title
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7160[✅] test/functional/apps/dashboard/group6/config.ts: 25/25 tests passed. |
stratoula
added
v9.0.0
v8.17.0
v8.16.0
Feature:Dashboard
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
stratoula
added
loe:small
jloleysens
approved these changes
Oct 18, 2024
nreese
reviewed
Oct 21, 2024
src/plugins/dashboard/public/dashboard_app/no_data/dashboard_app_no_data.tsx
Outdated
Show resolved
Hide resolved
src/plugins/dashboard/public/dashboard_app/no_data/dashboard_app_no_data.tsx
Show resolved
Hide resolved
nreese
reviewed
Oct 21, 2024
src/plugins/dashboard/public/dashboard_app/no_data/dashboard_app_no_data.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|
nreese
reviewed
Oct 22, 2024
|
|
||
| const onTryESQL = useCallback(async () => { | ||
| abortController?.abort(); | ||
| if (lensHelpersAsync.value && isMounted()) { |
There was a problem hiding this comment.
Thanks for adding isMounted check. isMounted check needs to happen after async functions, so after getESQLQueryColumns instead of at the beginning of the function.
There was a problem hiding this comment.
Thinking about this more, maybe the isMounted check is not even needed since getESQLQueryColumns request is canceled on unmount.
There was a problem hiding this comment.
yes I wanted to tell you the same tbh, I am removing this
nreese
reviewed
Oct 22, 2024
| }); | ||
| } | ||
| } catch (error) { | ||
| coreServices.notifications.toasts.addWarning( |
There was a problem hiding this comment.
Toast should not be displayed if error is aborted request
There was a problem hiding this comment.
Good catch, done a6da3da
nreese
approved these changes
Oct 22, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11474367790 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 23, 2024
…hen there are no dataviews (elastic#196658) ## Summary Closes elastic#176159 Try ES|QL button now navigates to dashboard with an ES|QL chart embedded.  ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit af139b4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 23, 2024
…even when there are no dataviews (#196658) (#197366) # Backport This will backport the following commits from `main` to `8.x`: - [[Dashboard][ES|QL] Allow creating a dashboard with ES|QL chart even when there are no dataviews (#196658)](#196658) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2024-10-23T06:32:01Z","message":"[Dashboard][ES|QL] Allow creating a dashboard with ES|QL chart even when there are no dataviews (#196658)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/176159\r\n\r\nTry ES|QL button now navigates to dashboard with an ES|QL chart\r\nembedded.\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"af139b4038ad758ad0896492bf7aea0418334ef4","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:Dashboard","Team:Presentation","loe:small","impact:medium","v9.0.0","Feature:ES|QL","backport:version","v8.17.0"],"title":"[Dashboard][ES|QL] Allow creating a dashboard with ES|QL chart even when there are no dataviews","number":196658,"url":"https://github.com/elastic/kibana/pull/196658","mergeCommit":{"message":"[Dashboard][ES|QL] Allow creating a dashboard with ES|QL chart even when there are no dataviews (#196658)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/176159\r\n\r\nTry ES|QL button now navigates to dashboard with an ES|QL chart\r\nembedded.\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"af139b4038ad758ad0896492bf7aea0418334ef4"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196658","number":196658,"mergeCommit":{"message":"[Dashboard][ES|QL] Allow creating a dashboard with ES|QL chart even when there are no dataviews (#196658)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/176159\r\n\r\nTry ES|QL button now navigates to dashboard with an ES|QL chart\r\nembedded.\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"af139b4038ad758ad0896492bf7aea0418334ef4"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #176159
Try ES|QL button now navigates to dashboard with an ES|QL chart embedded.
Checklist