[Security Solution] Disable deprecated rules bulk CRUD API endpoints in Serverless and 9.0 #197422
+58
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banderror
added
release_note:breaking
backport:skip
banderror
force-pushed
the
disable-deprecated-rules-bulk-crud-api-endpoints
branch
3 times, most recently
from
2a35118 to
c6e7615
Compare
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
banderror
force-pushed
the
disable-deprecated-rules-bulk-crud-api-endpoints
branch
2 times, most recently
from
6979982 to
05b91bd
Compare
banderror
force-pushed
the
disable-deprecated-rules-bulk-crud-api-endpoints
branch
from
05b91bd to
21f1e87
Compare
banderror
commented
Nov 1, 2024
Comment on lines
+49
to
+56
| await Promise.all([ | ||
| securitySolutionApi | ||
| .createRule({ body: getCustomQueryRuleParams({ rule_id: 'rule-id-1' }) }) | ||
| .expect(200), | ||
| securitySolutionApi | ||
| .createRule({ body: getCustomQueryRuleParams({ rule_id: 'rule-id-2' }) }) | ||
| .expect(200), | ||
| ]); |
There was a problem hiding this comment.
I'm thinking if these changes to rules export tests should go in a separate PR so that we could backport them to 8.x to decrease the chance of introducing conflicts with any other follow-up PRs related to rule import/export that will be merged to 8.x.
There was a problem hiding this comment.
Ok, I'll open a new PR against 8.x after merging this one 👍
dplumlee
approved these changes
Nov 1, 2024
💚 Build Succeeded
Metrics [docs]
History
cc @banderror |
banderror
deleted the
disable-deprecated-rules-bulk-crud-api-endpoints
branch
banderror
added a commit
that referenced
this pull request
Nov 6, 2024
…rt tests (#198953) **Follow-up to:** #197422 (comment) ## Summary This PR manually "backports" some of the changes from #197422 directly to the `8.x` branch. Specifically, it removes API calls to the rules `_bulk_create` API endpoint from the tests for exporting rules. This API endpoint has been disabled in `main` (=> Serverless and Kibana 9.0) and should not be used in code. This PR aims to reduce the chances of introducing conflicts with any further changes to rule export tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses: #193184
Breaking change proposal: https://github.com/elastic/dev/issues/2772 (internal)
Summary
This PR disables the following deprecated bulk API endpoints for creating, updating and deleting detection rules from Elastic Security APIs in Serverless and upcoming
v9.0.0:Specifically, as a first step we remove the endpoints from the route registrations. Once https://github.com/elastic/dev/issues/2772 is approved, we will merge this PR and remove the corresponding endpoint handlers and associated code in a follow-up PR.
Checklist
For maintainers