-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Use EUI table getRowProps for anomalies table row mouseover #19755
Merged
peteharverson
merged 1 commit into
elastic:master
from
peteharverson:ml-anomalies-table-mouseover
Jun 8, 2018
Merged
[ML] Use EUI table getRowProps for anomalies table row mouseover #19755
peteharverson
merged 1 commit into
elastic:master
from
peteharverson:ml-anomalies-table-mouseover
Jun 8, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
v7.0.0
v6.4.0
:ml
Feature:ml-results
legacy - do not use
labels
Jun 8, 2018
Pinging @elastic/ml-ui |
jgowdyelastic
approved these changes
Jun 8, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
walterra
approved these changes
Jun 8, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Jun 8, 2018
peteharverson
added a commit
that referenced
this pull request
Jun 8, 2018
kindsun
pushed a commit
that referenced
this pull request
Jun 12, 2018
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Anomaly Detection
ML anomaly detection
Feature:ml-results
legacy - do not use
:ml
review
v6.4.0
v7.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the anomalies table
onMouseOver
functionality, replacing the previous jQuery method of obtaining the row / anomaly that the mouse was over, with thegetRowProps
property that was added to EUI tables in elastic/eui#869.Functionality is used to highlight the corresponding anomaly chart marker in the Single Metric Viewer.