Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataUsage][Serverless] Add missing tests #198007

Merged
merged 10 commits into from
Nov 7, 2024
Merged

[DataUsage][Serverless] Add missing tests #198007

merged 10 commits into from
Nov 7, 2024
+1,344 −215

Conversation

ashokaditya
Copy link
Member

@ashokaditya ashokaditya commented Oct 28, 2024 •
edited by kibanamachine
Loading

@ashokaditya ashokaditya added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:version Backport to applied version labels v8.17.0 labels Oct 28, 2024
@ashokaditya ashokaditya self-assigned this Oct 28, 2024
@ashokaditya ashokaditya force-pushed the task/serverless-data-usage-tests branch 4 times, most recently from b373558 to 0f0119e Compare November 1, 2024 16:05
@ashokaditya
Copy link
Member Author

/ci

@ashokaditya ashokaditya force-pushed the task/serverless-data-usage-tests branch from 0f0119e to 486ad91 Compare November 6, 2024 08:49
@ashokaditya
Copy link
Member Author

/ci

@ashokaditya ashokaditya force-pushed the task/serverless-data-usage-tests branch 7 times, most recently from 31465b1 to f159af5 Compare November 6, 2024 15:52
@ashokaditya ashokaditya marked this pull request as ready for review November 6, 2024 15:52
@ashokaditya ashokaditya requested review from a team as code owners November 6, 2024 15:52
@ashokaditya ashokaditya force-pushed the task/serverless-data-usage-tests branch from f159af5 to 13aa1b1 Compare November 6, 2024 15:58
ashokaditya
ashokaditya commented Nov 6, 2024
View reviewed changes
x-pack/plugins/data_usage/server/routes/internal/data_streams_handler.ts
storageSizeBytes: stat.size_in_bytes ?? 0,
}));
const body =
meteringStats && !!meteringStats.length
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neptunian I added this change just in case the metering stats API does not return anything useful.

ashokaditya
ashokaditya commented Nov 6, 2024
View reviewed changes
x-pack/plugins/data_usage/server/routes/internal/data_streams.test.ts
});
});

it.each([
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neptunian and the tests for that change here

@ashokaditya ashokaditya enabled auto-merge (squash) November 7, 2024 05:32
@ashokaditya ashokaditya disabled auto-merge November 7, 2024 05:40
This was referenced Nov 7, 2024
Open
Open
@ashokaditya ashokaditya enabled auto-merge (squash) November 7, 2024 18:03
@ashokaditya ashokaditya merged commit 207894e into elastic:main Nov 7, 2024
26 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11730353082

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #24 / @ess @serverless SecuritySolution Explore Network Network Top N Flow With filebeat should get Source NetworkTopNFlow data with bytes_in descending sort
  • [job] [logs] Jest Tests #14 / Users filter should search comma separated strings as multiple users
  • [job] [logs] Jest Tests #14 / Users filter should search on given search string on enter

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataUsage 237.6KB 237.9KB +347.0B
Unknown metric groups

ESLint disabled in files

id before after diff
dataUsage 1 2 +1

Total ESLint disabled count

id before after diff
dataUsage 5 6 +1

History

cc @ashokaditya

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 7, 2024
@ashokaditya
[DataUsage][Serverless] Add missing tests (elastic#198007)
a3eb8be 
## Summary

Adds missing UX/API tests for changes added in
- elastic#193966
- elastic#197056
- elastic#195556
- elastic#196559

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 207894e)
@kibanamachine kibanamachine mentioned this pull request Nov 7, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Nov 7, 2024
Merged
4 tasks
@ashokaditya ashokaditya deleted the task/serverless-data-usage-tests branch November 7, 2024 21:13
kibanamachine added a commit that referenced this pull request Nov 7, 2024
@kibanamachine @ashokaditya
[8.x] [DataUsage][Serverless] Add missing tests (#198007) (#199375)
de032ca 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[DataUsage][Serverless] Add missing tests
(#198007)](#198007)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Ash","email":"1849116+ashokaditya@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-11-07T19:57:46Z","message":"[DataUsage][Serverless]
Add missing tests (#198007)\n\n## Summary\r\n\r\nAdds missing UX/API
tests for changes added in \r\n-
https://github.com/elastic/kibana/pull/193966\r\n-
https://github.com/elastic/kibana/pull/197056\r\n-
https://github.com/elastic/kibana/pull/195556\r\n-
https://github.com/elastic/kibana/pull/196559\r\n\r\n\r\n###
Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"207894edd5c8bd2530dee2f54d47b4f497aa3687","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.17.0"],"title":"[DataUsage][Serverless]
Add missing
tests","number":198007,"url":"https://github.com/elastic/kibana/pull/198007","mergeCommit":{"message":"[DataUsage][Serverless]
Add missing tests (#198007)\n\n## Summary\r\n\r\nAdds missing UX/API
tests for changes added in \r\n-
https://github.com/elastic/kibana/pull/193966\r\n-
https://github.com/elastic/kibana/pull/197056\r\n-
https://github.com/elastic/kibana/pull/195556\r\n-
https://github.com/elastic/kibana/pull/196559\r\n\r\n\r\n###
Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"207894edd5c8bd2530dee2f54d47b4f497aa3687"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198007","number":198007,"mergeCommit":{"message":"[DataUsage][Serverless]
Add missing tests (#198007)\n\n## Summary\r\n\r\nAdds missing UX/API
tests for changes added in \r\n-
https://github.com/elastic/kibana/pull/193966\r\n-
https://github.com/elastic/kibana/pull/197056\r\n-
https://github.com/elastic/kibana/pull/195556\r\n-
https://github.com/elastic/kibana/pull/196559\r\n\r\n\r\n###
Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"207894edd5c8bd2530dee2f54d47b4f497aa3687"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>
mbondyra pushed a commit to mbondyra/kibana that referenced this pull request Nov 8, 2024
@ashokaditya @kibanamachine @mbondyra
[DataUsage][Serverless] Add missing tests (elastic#198007)
b56d95c 
## Summary

Adds missing UX/API tests for changes added in 
- elastic#193966
- elastic#197056
- elastic#195556
- elastic#196559


### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 8, 2024
@ashokaditya @kibanamachine @CAWilson94
[DataUsage][Serverless] Add missing tests (elastic#198007)
7f0131a 
## Summary

Adds missing UX/API tests for changes added in 
- elastic#193966
- elastic#197056
- elastic#195556
- elastic#196559


### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neptunian neptunian neptunian approved these changes

@YulNaumenko YulNaumenko Awaiting requested review from YulNaumenko

Assignees

@ashokaditya ashokaditya

Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashokaditya @kibanamachine @elasticmachine @neptunian