Enable summarisation spec #199134
Merged
Enable summarisation spec #199134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
sorenlouv
added
backport:prev-minor
sorenlouv
commented
Nov 6, 2024
Comment on lines
-167
to
-169
| if (this.config.enableKnowledgeBase) { | ||
| addLensDocsToKb({ service, logger: this.logger.get('kb').get('lens') }); | ||
| } |
There was a problem hiding this comment.
This is removed to make testing easier. Right now Lens docs are imported automatically and pollutes tests. In order not to bother with this I simply got rid of it.
It will be properly removed (and cleaned up) in #191043
botelastic
bot
added
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
viduni94
approved these changes
Nov 6, 2024
💚 Build Succeeded
Metrics [docs]
|
sorenlouv
added
the
release_note:skip
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11713577210 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 6, 2024
This enables the api test that covers summarisation. It was originally skipped because tiny_elser was not available on CI. Now it is we can effectively test storing and retrieving entries from the knowledge base. (cherry picked from commit e399483)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 7, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Enable summarisation spec (#199134)](#199134) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Søren Louv-Jansen","email":"soren.louv@elastic.co"},"sourceCommit":{"committedDate":"2024-11-06T23:25:30Z","message":"Enable summarisation spec (#199134)\n\nThis enables the api test that covers summarisation. It was originally\r\nskipped because tiny_elser was not available on CI. Now it is we can\r\neffectively test storing and retrieving entries from the knowledge base.","sha":"e3994831ff3c6f337a209bcd3d2f93344eb787a4","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:Obs AI Assistant","ci:project-deploy-observability"],"title":"Enable summarisation spec","number":199134,"url":"https://github.com/elastic/kibana/pull/199134","mergeCommit":{"message":"Enable summarisation spec (#199134)\n\nThis enables the api test that covers summarisation. It was originally\r\nskipped because tiny_elser was not available on CI. Now it is we can\r\neffectively test storing and retrieving entries from the knowledge base.","sha":"e3994831ff3c6f337a209bcd3d2f93344eb787a4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199134","number":199134,"mergeCommit":{"message":"Enable summarisation spec (#199134)\n\nThis enables the api test that covers summarisation. It was originally\r\nskipped because tiny_elser was not available on CI. Now it is we can\r\neffectively test storing and retrieving entries from the knowledge base.","sha":"e3994831ff3c6f337a209bcd3d2f93344eb787a4"}}]}] BACKPORT--> Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co>
mgadewoll
pushed a commit
to mgadewoll/kibana
that referenced
this pull request
Nov 7, 2024
This enables the api test that covers summarisation. It was originally skipped because tiny_elser was not available on CI. Now it is we can effectively test storing and retrieving entries from the knowledge base.
neptunian
added a commit
that referenced
this pull request
Dec 18, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 18, 2024
…elastic#204790) Closes elastic#192497 - Unskips summarize.spec.ts. It was originally skipped because tiny_elser was not available on CI. - Adds `this.tags(['skipMKI']` due to elastic#192751 Related: elastic#199134 (cherry picked from commit 4af2706)
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
…elastic#204790) Closes elastic#192497 - Unskips summarize.spec.ts. It was originally skipped because tiny_elser was not available on CI. - Adds `this.tags(['skipMKI']` due to elastic#192751 Related: elastic#199134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the api test that covers summarisation. It was originally skipped because tiny_elser was not available on CI. Now it is we can effectively test storing and retrieving entries from the knowledge base.