Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Improves the keep command description #199312

Merged
merged 1 commit into from
Nov 7, 2024
Merged

[ES|QL] Improves the keep command description #199312

merged 1 commit into from
Nov 7, 2024

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Nov 7, 2024 •
edited by kibanamachine
Loading

Summary

Closes #199297

image

@stratoula stratoula marked this pull request as ready for review November 7, 2024 13:13
@stratoula stratoula requested a review from a team as a code owner November 7, 2024 13:13
@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:version Backport to applied version labels v8.17.0 Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana labels Nov 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

florent-leborgne
florent-leborgne approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@stratoula stratoula enabled auto-merge (squash) November 7, 2024 14:15
@stratoula stratoula merged commit bcc5b36 into elastic:main Nov 7, 2024
35 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11725585757

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #96 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens Heatmap should convert to Lens if Y-axis is defined, but X-axis is not

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.4MB 13.4MB +2.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.4MB 3.4MB +2.0B

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 7, 2024
@stratoula
[ES|QL] Improves the keep command description (elastic#199312)
52e5b2c 
## Summary

Closes elastic#199297

<img width="1167" alt="image"
src="https://github.com/user-attachments/assets/c26d07e8-f782-412c-968c-c551a9bc7942">

(cherry picked from commit bcc5b36)
@kibanamachine kibanamachine mentioned this pull request Nov 7, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 7, 2024
@kibanamachine @stratoula
[8.x] [ES|QL] Improves the keep command description (#199312) (#199337)
f7c8827 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Improves the keep command description
(#199312)](#199312)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2024-11-07T15:00:49Z","message":"[ES|QL]
Improves the keep command description (#199312)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/199297\r\n\r\n<img
width=\"1167\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c26d07e8-f782-412c-968c-c551a9bc7942\">","sha":"bcc5b36cc3a07d15103c9ef86d68e9e657c701d3","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:ES|QL","Team:ESQL","backport:version","v8.17.0"],"title":"[ES|QL]
Improves the keep command
description","number":199312,"url":"https://github.com/elastic/kibana/pull/199312","mergeCommit":{"message":"[ES|QL]
Improves the keep command description (#199312)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/199297\r\n\r\n<img
width=\"1167\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c26d07e8-f782-412c-968c-c551a9bc7942\">","sha":"bcc5b36cc3a07d15103c9ef86d68e9e657c701d3"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199312","number":199312,"mergeCommit":{"message":"[ES|QL]
Improves the keep command description (#199312)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/199297\r\n\r\n<img
width=\"1167\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c26d07e8-f782-412c-968c-c551a9bc7942\">","sha":"bcc5b36cc3a07d15103c9ef86d68e9e657c701d3"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
mbondyra pushed a commit to mbondyra/kibana that referenced this pull request Nov 8, 2024
@stratoula @mbondyra
[ES|QL] Improves the keep command description (elastic#199312)
fb454f4 
## Summary

Closes elastic#199297

<img width="1167" alt="image"
src="https://github.com/user-attachments/assets/c26d07e8-f782-412c-968c-c551a9bc7942">
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 8, 2024
@stratoula @CAWilson94
[ES|QL] Improves the keep command description (elastic#199312)
e3405f6 
## Summary

Closes elastic#199297

<img width="1167" alt="image"
src="https://github.com/user-attachments/assets/c26d07e8-f782-412c-968c-c551a9bc7942">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadimkibana vadimkibana vadimkibana approved these changes

@florent-leborgne florent-leborgne florent-leborgne approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ES|QL] KEEP function description mentions 'input' table instead of 'results' table in Discover
5 participants
@stratoula @elasticmachine @kibanamachine @florent-leborgne @vadimkibana