Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sustainable Kibana Architecture: Categorise straightforward packages #199630

Merged
merged 62 commits into from
Nov 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
114387a
Categorise `discover-shared-plugin` as platform/shared
gsoldevila Nov 11, 2024
bb690ce
Categorise `index-lifecycle-management` as platform/private
gsoldevila Nov 11, 2024
6f1fe3a
Categorise straightforward platform/private packages
gsoldevila Nov 11, 2024
8114076
Categorise straightforward observability/private packages
gsoldevila Nov 11, 2024
8f89d3e
Categorise straightforward security/private packages
gsoldevila Nov 11, 2024
6d1c87f
Categorise straightforward search/private packages
gsoldevila Nov 11, 2024
414ae99
Categorise straightforward observability/private packages (round 2)
gsoldevila Nov 11, 2024
1b3952b
Make TSVB platform_shared
gsoldevila Nov 12, 2024
20230fe
Remove residual dependency `rollup=>vis-type-timeseries`
gsoldevila Nov 12, 2024
f8325dd
Categorise internal Core packages as platform/private
gsoldevila Nov 12, 2024
998d70c
Categorise non-internal Core packages as platform/shared
gsoldevila Nov 12, 2024
ca2aac7
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
kibanamachine Nov 13, 2024
879121f
Categorise packages with only platform, noDevOnly deps
gsoldevila Nov 14, 2024
0cf8b4c
Categorise packages with some platform, noDevOnly deps
gsoldevila Nov 14, 2024
5770d21
Integrate changes from `observability-utils` package split
gsoldevila Nov 14, 2024
9d06582
Update outdated CODEOWNERS
gsoldevila Nov 14, 2024
4a48576
Categorise @kbn/core as platform/shared
gsoldevila Nov 14, 2024
f089945
Categorise securitysolution-* packages as platform/shared (for now)
gsoldevila Nov 14, 2024
c2ba840
Allow devOnly + CLI tools to depend on any platform
gsoldevila Nov 18, 2024
4471a4b
Categorise kbn-reporting packages as platform/private
gsoldevila Nov 18, 2024
bd1cc80
Fix illegal deps on private platform packages
gsoldevila Nov 18, 2024
691c437
Categorise health-gateway-server as platform/private
gsoldevila Nov 18, 2024
355bb37
[CI] Auto-commit changed files from 'node scripts/capture_oas_snapsho…
kibanamachine Nov 18, 2024
b75c010
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Nov 18, 2024
c6945bb
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine Nov 18, 2024
2b568ab
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Nov 18, 2024
952cfe5
Categorise `unsaved-changes-prompt` as platform/shared
gsoldevila Nov 18, 2024
e30fa88
Prevent illegal access to `CoreKibanaRequest`
gsoldevila Nov 18, 2024
94b4ecf
Prevent illegal access to `KibanaResponse`
gsoldevila Nov 18, 2024
a250c8f
Access `LifecycleResponseFactory` from the right source
gsoldevila Nov 18, 2024
fc5fbfe
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine Nov 18, 2024
bd13f3b
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Nov 18, 2024
190adee
Workaround illegal deps by temporarily making alerting-rule-utils pla…
gsoldevila Nov 19, 2024
fc22526
Fix illegal dependency on `securitysolution-io-ts-list-types`
gsoldevila Nov 19, 2024
5fdb4c3
Remove dependency towards `core-saved-objects-migration-server-internal`
gsoldevila Nov 19, 2024
5e75887
Remove outdated / incorrect comments
gsoldevila Nov 19, 2024
0c79ab5
Create `core-http-server-utils` package (prevent cyclic dependency)
gsoldevila Nov 19, 2024
c6591df
[CI] Auto-commit changed files from 'node scripts/lint_packages --fix'
kibanamachine Nov 19, 2024
6aee11d
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Nov 19, 2024
c9f0b4b
Remove outdated exports
gsoldevila Nov 19, 2024
3b40cab
Fix outdated references to `kibanaRequestFactory`
gsoldevila Nov 19, 2024
9c1efde
Remove dependencies towards `CoreKibanaRequest`
gsoldevila Nov 20, 2024
1b4c206
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Nov 20, 2024
dff6daf
Include devOnly scenarios in test
gsoldevila Nov 20, 2024
0ef0da1
Categorise ai_infra plugins as platform/shared
gsoldevila Nov 20, 2024
5bfa71c
Categorise index-adapter as security/private (for now)
gsoldevila Nov 20, 2024
33c163f
Only used in Search solution
gsoldevila Nov 20, 2024
b019567
Add comments to vis-type-timeseries
gsoldevila Nov 20, 2024
2cae783
Categorise straightforward platform/private packages
gsoldevila Nov 20, 2024
ab9a644
Rollback manifest changes
gsoldevila Nov 20, 2024
2bd0d54
Set `devOnly` flag
gsoldevila Nov 20, 2024
46f9a11
[CI] Auto-commit changed files from 'node scripts/capture_oas_snapsho…
kibanamachine Nov 20, 2024
4ee3f30
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Nov 20, 2024
00e8d32
Categorise straightforward platform/shared packages
gsoldevila Nov 21, 2024
ccb1f03
Categorise straightforward platform/private packages
gsoldevila Nov 21, 2024
5cb334b
Accessed from example plugins
gsoldevila Nov 21, 2024
1ab7e0c
Categorise platform/shared packages (incl devOnly)
gsoldevila Nov 21, 2024
629d451
Categorise platform/private packages (incl devOnly)
gsoldevila Nov 21, 2024
09d2e8f
Packages used from multiple solutions
gsoldevila Nov 21, 2024
68d97f5
Untangle osquery-plugin deps issues
gsoldevila Nov 21, 2024
9f0d85f
Infra depends on osquery :sadpanda:
gsoldevila Nov 21, 2024
6a84255
Make testing packages shared
gsoldevila Nov 21, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ packages/core/http/core-http-router-server-mocks @elastic/kibana-core
packages/core/http/core-http-server @elastic/kibana-core
packages/core/http/core-http-server-internal @elastic/kibana-core
packages/core/http/core-http-server-mocks @elastic/kibana-core
packages/core/http/core-http-server-utils @elastic/kibana-core
packages/core/i18n/core-i18n-browser @elastic/kibana-core
packages/core/i18n/core-i18n-browser-internal @elastic/kibana-core
packages/core/i18n/core-i18n-browser-mocks @elastic/kibana-core
Expand Down
6 changes: 3 additions & 3 deletions examples/resizable_layout_examples/public/application.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* License v3.0 only", or the "Server Side Public License, v 1".
*/

import { CoreThemeProvider } from '@kbn/core-theme-browser-internal';
import { KibanaThemeProvider } from '@kbn/react-kibana-context-theme';
import type { AppMountParameters } from '@kbn/core/public';
import { I18nProvider } from '@kbn/i18n-react';
import React, { ReactNode, useState } from 'react';
Expand Down Expand Up @@ -101,7 +101,7 @@ const ResizableSection = ({
export const renderApp = ({ element, theme$ }: AppMountParameters) => {
ReactDOM.render(
<I18nProvider>
<CoreThemeProvider theme$={theme$}>
<KibanaThemeProvider theme={{ theme$ }}>
<div
css={css`
height: calc(100vh - var(--euiFixedHeadersOffset, 0));
Expand Down Expand Up @@ -151,7 +151,7 @@ export const renderApp = ({ element, theme$ }: AppMountParameters) => {
}
/>
</div>
</CoreThemeProvider>
</KibanaThemeProvider>
</I18nProvider>,
element
);
Expand Down
2 changes: 1 addition & 1 deletion examples/resizable_layout_examples/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
"include": ["common/**/*", "public/**/*", "server/**/*", "../../typings/**/*"],
"kbn_references": [
"@kbn/resizable-layout",
"@kbn/core-theme-browser-internal",
"@kbn/core",
"@kbn/i18n-react",
"@kbn/developer-examples-plugin",
"@kbn/react-kibana-context-theme",
],
"exclude": ["target/**/*"]
}
4 changes: 2 additions & 2 deletions examples/search_examples/public/search_sessions/app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ import { lastValueFrom, of } from 'rxjs';

import { CoreStart } from '@kbn/core/public';
import { KibanaRenderContextProvider } from '@kbn/react-kibana-context-render';
import { mountReactNode } from '@kbn/core-mount-utils-browser-internal';
import type { TimeRange } from '@kbn/es-query';
import { NavigationPublicPluginStart } from '@kbn/navigation-plugin/public';

Expand All @@ -48,6 +47,7 @@ import {
import { UnifiedSearchPublicPluginStart } from '@kbn/unified-search-plugin/public';
import type { DataView, DataViewField } from '@kbn/data-views-plugin/public';
import { createStateContainer, useContainerState } from '@kbn/kibana-utils-plugin/public';
import { toMountPoint } from '@kbn/react-kibana-mount';
import { PLUGIN_ID } from '../../common';
import { getInitialStateFromUrl, SEARCH_SESSIONS_EXAMPLES_APP_LOCATOR } from './app_locator';

Expand Down Expand Up @@ -735,7 +735,7 @@ function doSearch(
);
notifications.toasts.addSuccess({
title: 'Query result',
text: mountReactNode(message),
text: toMountPoint(message, startServices),
});
}
}),
Expand Down
1 change: 0 additions & 1 deletion examples/search_examples/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
"@kbn/utility-types",
"@kbn/es-query",
"@kbn/i18n",
"@kbn/core-mount-utils-browser-internal",
"@kbn/config-schema",
"@kbn/shared-ux-router",
"@kbn/search-types",
Expand Down
6 changes: 3 additions & 3 deletions examples/unified_field_list_examples/public/application.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import React from 'react';
import ReactDOM from 'react-dom';
import { I18nProvider } from '@kbn/i18n-react';
import { CoreThemeProvider } from '@kbn/core-theme-browser-internal';
import { KibanaThemeProvider } from '@kbn/react-kibana-context-theme';
import type { AppMountParameters, CoreStart } from '@kbn/core/public';
import { AppPluginStartDependencies } from './types';
import { UnifiedFieldListExampleApp } from './example_app';
Expand All @@ -22,14 +22,14 @@ export const renderApp = (
) => {
ReactDOM.render(
<I18nProvider>
<CoreThemeProvider theme$={theme$}>
<KibanaThemeProvider theme={{ theme$ }}>
<UnifiedFieldListExampleApp
services={{
core,
...deps,
}}
/>
</CoreThemeProvider>
</KibanaThemeProvider>
</I18nProvider>,
element
);
Expand Down
2 changes: 1 addition & 1 deletion examples/unified_field_list_examples/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@kbn/field-formats-plugin",
"@kbn/data-view-field-editor-plugin",
"@kbn/unified-field-list",
"@kbn/core-theme-browser-internal",
"@kbn/ui-actions-plugin",
"@kbn/react-kibana-context-theme",
]
}
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@
"@kbn/core-http-router-server-internal": "link:packages/core/http/core-http-router-server-internal",
"@kbn/core-http-server": "link:packages/core/http/core-http-server",
"@kbn/core-http-server-internal": "link:packages/core/http/core-http-server-internal",
"@kbn/core-http-server-utils": "link:packages/core/http/core-http-server-utils",
"@kbn/core-i18n-browser": "link:packages/core/i18n/core-i18n-browser",
"@kbn/core-i18n-browser-internal": "link:packages/core/i18n/core-i18n-browser-internal",
"@kbn/core-i18n-server": "link:packages/core/i18n/core-i18n-server",
Expand Down Expand Up @@ -640,7 +641,6 @@
"@kbn/management-settings-types": "link:packages/kbn-management/settings/types",
"@kbn/management-settings-utilities": "link:packages/kbn-management/settings/utilities",
"@kbn/management-test-plugin": "link:test/plugin_functional/plugins/management_test_plugin",
"@kbn/manifest": "link:packages/kbn-manifest",
"@kbn/mapbox-gl": "link:packages/kbn-mapbox-gl",
"@kbn/maps-custom-raster-source-plugin": "link:x-pack/examples/third_party_maps_source_example",
"@kbn/maps-ems-plugin": "link:src/plugins/maps_ems",
Expand Down Expand Up @@ -1460,6 +1460,7 @@
"@kbn/managed-vscode-config": "link:packages/kbn-managed-vscode-config",
"@kbn/managed-vscode-config-cli": "link:packages/kbn-managed-vscode-config-cli",
"@kbn/management-storybook-config": "link:packages/kbn-management/storybook/config",
"@kbn/manifest": "link:packages/kbn-manifest",
"@kbn/mock-idp-plugin": "link:packages/kbn-mock-idp-plugin",
"@kbn/mock-idp-utils": "link:packages/kbn-mock-idp-utils",
"@kbn/observability-onboarding-e2e": "link:x-pack/plugins/observability_solution/observability_onboarding/e2e",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"type": "shared-common",
"id": "@kbn/analytics-collection-utils",
"owner": "@elastic/kibana-core"
}
"owner": [
"@elastic/kibana-core"
],
"group": "platform",
"visibility": "private"
}
8 changes: 6 additions & 2 deletions packages/cloud/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"type": "shared-common",
"id": "@kbn/cloud",
"owner": "@elastic/kibana-core"
}
"owner": [
"@elastic/kibana-core"
],
"group": "platform",
"visibility": "shared"
}
8 changes: 6 additions & 2 deletions packages/content-management/content_editor/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"type": "shared-browser",
"id": "@kbn/content-management-content-editor",
"owner": "@elastic/appex-sharedux",
}
"owner": [
"@elastic/appex-sharedux"
],
"group": "platform",
"visibility": "shared"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"type": "shared-browser",
"id": "@kbn/content-management-content-insights-public",
"owner": "@elastic/appex-sharedux"
}
"owner": [
"@elastic/appex-sharedux"
],
"group": "platform",
"visibility": "shared"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"type": "shared-server",
"id": "@kbn/content-management-content-insights-server",
"owner": "@elastic/appex-sharedux"
}
"owner": [
"@elastic/appex-sharedux"
],
"group": "platform",
"visibility": "shared"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
{
"type": "shared-common",
"id": "@kbn/content-management-favorites-common",
"owner": "@elastic/appex-sharedux"
"owner": "@elastic/appex-sharedux",
"group": "platform",
"visibility": "private"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"type": "shared-browser",
"id": "@kbn/content-management-favorites-public",
"owner": "@elastic/appex-sharedux"
}
"owner": [
"@elastic/appex-sharedux"
],
"group": "platform",
"visibility": "shared"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"type": "shared-server",
"id": "@kbn/content-management-favorites-server",
"owner": "@elastic/appex-sharedux"
}
"owner": [
"@elastic/appex-sharedux"
],
"group": "platform",
"visibility": "shared"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"type": "shared-browser",
"id": "@kbn/content-management-tabbed-table-list-view",
"owner": "@elastic/appex-sharedux"
}
"owner": [
"@elastic/appex-sharedux"
],
"group": "platform",
"visibility": "private"
}
8 changes: 6 additions & 2 deletions packages/content-management/table_list_view/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"type": "shared-browser",
"id": "@kbn/content-management-table-list-view",
"owner": "@elastic/appex-sharedux"
}
"owner": [
"@elastic/appex-sharedux"
],
"group": "platform",
"visibility": "shared"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"type": "shared-common",
"id": "@kbn/content-management-table-list-view-common",
"owner": "@elastic/appex-sharedux"
}
"owner": [
"@elastic/appex-sharedux"
],
"group": "platform",
"visibility": "shared"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"type": "shared-browser",
"id": "@kbn/content-management-table-list-view-table",
"owner": "@elastic/appex-sharedux"
}
"owner": [
"@elastic/appex-sharedux"
],
"group": "platform",
"visibility": "shared"
}
8 changes: 6 additions & 2 deletions packages/content-management/user_profiles/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"type": "shared-browser",
"id": "@kbn/content-management-user-profiles",
"owner": "@elastic/appex-sharedux"
}
"owner": [
"@elastic/appex-sharedux"
],
"group": "platform",
"visibility": "shared"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"type": "shared-browser",
"id": "@kbn/core-analytics-browser-internal",
"owner": "@elastic/kibana-core"
}
"owner": [
"@elastic/kibana-core"
],
"group": "platform",
"visibility": "private"
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
{
"type": "shared-browser",
"id": "@kbn/core-analytics-browser-mocks",
"devOnly": true,
"owner": "@elastic/kibana-core"
}
"owner": [
"@elastic/kibana-core"
],
"group": "platform",
"visibility": "shared",
"devOnly": true
}
8 changes: 6 additions & 2 deletions packages/core/analytics/core-analytics-browser/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"type": "shared-browser",
"id": "@kbn/core-analytics-browser",
"owner": "@elastic/kibana-core"
}
"owner": [
"@elastic/kibana-core"
],
"group": "platform",
"visibility": "shared"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"type": "shared-server",
"id": "@kbn/core-analytics-server-internal",
"owner": "@elastic/kibana-core"
}
"owner": [
"@elastic/kibana-core"
],
"group": "platform",
"visibility": "private"
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
{
"type": "shared-server",
"id": "@kbn/core-analytics-server-mocks",
"devOnly": true,
"owner": "@elastic/kibana-core"
}
"owner": [
"@elastic/kibana-core"
],
"group": "platform",
"visibility": "shared",
"devOnly": true
}
8 changes: 6 additions & 2 deletions packages/core/analytics/core-analytics-server/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"type": "shared-server",
"id": "@kbn/core-analytics-server",
"owner": "@elastic/kibana-core"
}
"owner": [
"@elastic/kibana-core"
],
"group": "platform",
"visibility": "shared"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"type": "shared-browser",
"id": "@kbn/core-application-browser-internal",
"owner": "@elastic/kibana-core"
}
"owner": [
"@elastic/kibana-core"
],
"group": "platform",
"visibility": "private"
}
Loading