[Fleet] use defaultFleetErrorHandler in all fleet routes #200741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
force-pushed
the
feature-default-fleet-error-handler
branch
3 times, most recently
from
2c7400c to
96e0366
Compare
nchaulet
added
Team:Fleet
nchaulet
force-pushed
the
feature-default-fleet-error-handler
branch
from
96e0366 to
bcf1f17
Compare
|
Pinging @elastic/fleet (Team:Fleet) |
juliaElastic
approved these changes
Nov 19, 2024
Probably worth adding a section about our fleet_router in Fleet readme, I will made that change |
|
@juliaElastic @kpollich do you think this should be backported to 8.x? |
|
It sounds like a small risk change, so I would vote to backport. |
nchaulet
added
backport:prev-minor
💚 Build Succeeded
Metrics [docs]
cc @nchaulet |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11919725447 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Nov 19, 2024
) (cherry picked from commit 523fd13) # Conflicts: # x-pack/plugins/fleet/server/routes/agent/handlers.ts # x-pack/plugins/fleet/server/routes/agent_policy/handlers.ts # x-pack/plugins/fleet/server/routes/app/index.ts # x-pack/plugins/fleet/server/routes/epm/handlers.ts # x-pack/plugins/fleet/server/routes/health_check/handler.ts # x-pack/plugins/fleet/server/routes/settings/enrollment_settings_handler.ts # x-pack/plugins/fleet/server/routes/uninstall_token/handlers.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
nchaulet
added a commit
that referenced
this pull request
Nov 20, 2024
…) (#200803) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] use defaultFleetErrorHandler in all fleet routes (#200741)](#200741) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"nicolas.chaulet@elastic.co"},"sourceCommit":{"committedDate":"2024-11-19T18:49:44Z","message":"[Fleet] use defaultFleetErrorHandler in all fleet routes (#200741)","sha":"523fd13925cd0ec4f02f9ac069b09153e36fb9e0","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor"],"number":200741,"url":"https://github.com/elastic/kibana/pull/200741","mergeCommit":{"message":"[Fleet] use defaultFleetErrorHandler in all fleet routes (#200741)","sha":"523fd13925cd0ec4f02f9ac069b09153e36fb9e0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200741","number":200741,"mergeCommit":{"message":"[Fleet] use defaultFleetErrorHandler in all fleet routes (#200741)","sha":"523fd13925cd0ec4f02f9ac069b09153e36fb9e0"}}]}] BACKPORT-->
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #197518
To handle Fleet error with have a handler
defaultFleetErrorHandlerthat transform known error into specific response with specific statusCode.That PR make a change to use
defaultFleetErrorHandlerin all fleet registered route instead of having to manually add a try/catch in every fleet handler, so we do not forget to handle some errors.Should we backport this to
8.x?