chore(slo): refactor transform generators and managers dependency injection #201031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdelemme
added
Team:obs-ux-management
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
kdelemme
added
the
backport:prev-minor
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kdelemme
force-pushed
the
chore/transform-generator-refactor
branch
from
7fabed7 to
d8f4ff4
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
shahzad31
approved these changes
Nov 21, 2024
|
Starting backport for target branches: 8.17, 8.x https://github.com/elastic/kibana/actions/runs/11973901605 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 22, 2024
…ection (elastic#201031) (cherry picked from commit 2046663)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 22, 2024
…ection (elastic#201031) (cherry picked from commit 2046663)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This was referenced Nov 22, 2024
kibanamachine
added a commit
that referenced
this pull request
Nov 22, 2024
…cy injection (#201031) (#201390) # Backport This will backport the following commits from `main` to `8.x`: - [chore(slo): refactor transform generators and managers dependency injection (#201031)](#201031) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2024-11-22T13:52:18Z","message":"chore(slo): refactor transform generators and managers dependency injection (#201031)","sha":"204666310fec611773a1bfb8c0c80a72f1dc5468","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.17.0"],"title":"chore(slo): refactor transform generators and managers dependency injection","number":201031,"url":"https://github.com/elastic/kibana/pull/201031","mergeCommit":{"message":"chore(slo): refactor transform generators and managers dependency injection (#201031)","sha":"204666310fec611773a1bfb8c0c80a72f1dc5468"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201031","number":201031,"mergeCommit":{"message":"chore(slo): refactor transform generators and managers dependency injection (#201031)","sha":"204666310fec611773a1bfb8c0c80a72f1dc5468"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co>
4 tasks
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kdelemme
pushed a commit
that referenced
this pull request
Nov 25, 2024
kibanamachine
removed
the
backport missing
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #200966
Summary
This PR refactors the TransformGenerators and TransformGeneratorManager to simplify the dependency injection of the services/config used only from the generators.
The code related to these services evolved quite a bit in the past 24 months, but we never took the time to actually refactor it when adding new dependencies.
Everything should keep working as previously.