[Search] [Playground] [Bug] Add playground index validation #201032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yansavitski
added
release_note:skip
joemcelroy
approved these changes
Nov 21, 2024
|
thanks for fixing this quickly! |
joemcelroy
reviewed
Nov 21, 2024
|
|
||
| useEffect(() => { | ||
| if (isIndicesLoaded) { | ||
| setValidIndices(indices.filter((index) => unvalidatedIndices.includes(index))); |
There was a problem hiding this comment.
useQueryIndices gets the top 10 indices, what happens if its not in this list but does exist?
I would do an explicit API call for all the unvalidatedIndices to see if they exist.
There was a problem hiding this comment.
joemcelroy
requested changes
Nov 21, 2024
joemcelroy
approved these changes
Nov 21, 2024
joemcelroy
approved these changes
Nov 25, 2024
yansavitski
force-pushed
the
add-playground-index-validation
branch
from
db822c5 to
7b0a9df
Compare
joemcelroy
added
backport:prev-minor
yansavitski
force-pushed
the
add-playground-index-validation
branch
from
7b0a9df to
9f61325
Compare
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
|
yansavitski
force-pushed
the
add-playground-index-validation
branch
from
efb27bd to
f132064
Compare
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12018786643 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
yansavitski
added a commit
that referenced
this pull request
Nov 26, 2024
…201032) (#201750) # Backport This will backport the following commits from `main` to `8.16`: - [[Search] [Playground] [Bug] Add playground index validation (#201032)](#201032) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yan Savitski","email":"yan.savitski@elastic.co"},"sourceCommit":{"committedDate":"2024-11-25T21:06:54Z","message":"[Search] [Playground] [Bug] Add playground index validation (#201032)\n\nFix bug when localStorage has invalid index, then playground chat page\r\nopens with empty source.","sha":"d99431e51ea976baa69d51d4f7ba30592adecf7e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"number":201032,"url":"https://github.com/elastic/kibana/pull/201032","mergeCommit":{"message":"[Search] [Playground] [Bug] Add playground index validation (#201032)\n\nFix bug when localStorage has invalid index, then playground chat page\r\nopens with empty source.","sha":"d99431e51ea976baa69d51d4f7ba30592adecf7e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201032","number":201032,"mergeCommit":{"message":"[Search] [Playground] [Bug] Add playground index validation (#201032)\n\nFix bug when localStorage has invalid index, then playground chat page\r\nopens with empty source.","sha":"d99431e51ea976baa69d51d4f7ba30592adecf7e"}}]}] BACKPORT-->
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…201032) Fix bug when localStorage has invalid index, then playground chat page opens with empty source.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…201032) Fix bug when localStorage has invalid index, then playground chat page opens with empty source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug when localStorage has invalid index, then playground chat page opens with empty source.