[ES|QL] Update the functions definitions and tests to include date_nanos #201078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
stratoula
added
v9.0.0
backport:version
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
added
the
release_note:skip
stratoula
changed the title
qn895
reviewed
Nov 21, 2024
| @@ -5367,7 +5541,6 @@ const mvSortDefinition: FunctionDefinition = { | |||
| name: 'order', | |||
| type: 'keyword', | |||
| optional: true, | |||
| acceptedValues: ['asc', 'desc'], | |||
There was a problem hiding this comment.
I think we need to put this back cause otherwise the mv_sort will stop giving errors for non asc or desc for secon param.
There was a problem hiding this comment.
They got removed from the script, are we adding them manually?
There was a problem hiding this comment.
You were right! We do this manually, great catch! 9871adf
qn895
reviewed
Nov 21, 2024
| [], | ||
| ['Invalid option ["bogus"] for mv_sort. Supported options: ["asc", "desc"].'] | ||
| ); | ||
| testErrorsAndWarnings(`row var = mv_sort(["a", "b"], "bogus")`, [], []); |
There was a problem hiding this comment.
We can revert these changes once we fix the missing mv_sort acceptedValues.
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
|
Starting backport for target branches: 8.17, 8.x https://github.com/elastic/kibana/actions/runs/11960797299 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 21, 2024
…nos (elastic#201078) (cherry picked from commit 9da8f87)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 21, 2024
…nos (elastic#201078) (cherry picked from commit 9da8f87)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 21, 2024
…date_nanos (#201078) (#201277) # Backport This will backport the following commits from `main` to `8.17`: - [[ES|QL] Update the functions definitions and tests to include date_nanos (#201078)](#201078) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2024-11-21T20:05:41Z","message":"[ES|QL] Update the functions definitions and tests to include date_nanos (#201078)","sha":"9da8f87a8690e083c1c763941bd4e36d997f3de2","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:ES|QL","Team:ESQL","backport:version","v8.17.0","v8.18.0"],"title":"[ES|QL] Update the functions definitions and tests to include date_nanos","number":201078,"url":"https://github.com/elastic/kibana/pull/201078","mergeCommit":{"message":"[ES|QL] Update the functions definitions and tests to include date_nanos (#201078)","sha":"9da8f87a8690e083c1c763941bd4e36d997f3de2"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201078","number":201078,"mergeCommit":{"message":"[ES|QL] Update the functions definitions and tests to include date_nanos (#201078)","sha":"9da8f87a8690e083c1c763941bd4e36d997f3de2"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Nov 21, 2024
…ate_nanos (#201078) (#201278) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Update the functions definitions and tests to include date_nanos (#201078)](#201078) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2024-11-21T20:05:41Z","message":"[ES|QL] Update the functions definitions and tests to include date_nanos (#201078)","sha":"9da8f87a8690e083c1c763941bd4e36d997f3de2","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:ES|QL","Team:ESQL","backport:version","v8.17.0","v8.18.0"],"title":"[ES|QL] Update the functions definitions and tests to include date_nanos","number":201078,"url":"https://github.com/elastic/kibana/pull/201078","mergeCommit":{"message":"[ES|QL] Update the functions definitions and tests to include date_nanos (#201078)","sha":"9da8f87a8690e083c1c763941bd4e36d997f3de2"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201078","number":201078,"mergeCommit":{"message":"[ES|QL] Update the functions definitions and tests to include date_nanos (#201078)","sha":"9da8f87a8690e083c1c763941bd4e36d997f3de2"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the functions definitions for 8.17 to include date_nanos support
Checklist