Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Add missing aria-label attribute to various components #20117

Merged
merged 1 commit into from
Jun 21, 2018
Merged

[ML] Add missing aria-label attribute to various components #20117

merged 1 commit into from
Jun 21, 2018

Conversation

peteharverson
Copy link
Contributor

Adds the accessibility aria-label attribute to various form controls from which it was missing:

  • Single Metric wizard 'run search' button
  • Data Visualizer 'field types' dropdown
  • Data Visualizer 'metric details display' dropdown
  • Calendars List 'Add calendar' button (corrects text on label)

Addresses one item under 'Create Single Metric job' section in #18278

Fixes #20096 #20102 #20103

@peteharverson peteharverson added bug Fixes for quality problems that affect the customer experience review Project:Accessibility v7.0.0 v6.4.0 :ml Feature:Anomaly Detection ML anomaly detection Feature:ml-results legacy - do not use labels Jun 21, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

jgowdyelastic
jgowdyelastic approved these changes Jun 21, 2018
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@peteharverson peteharverson merged commit c267b4d into elastic:master Jun 21, 2018
@peteharverson peteharverson deleted the ml-add-aria-label branch June 21, 2018 11:21
@peteharverson peteharverson mentioned this pull request Jun 21, 2018
Merged
peteharverson added a commit to peteharverson/kibana that referenced this pull request Jun 21, 2018
@peteharverson
[ML] Add missing aria-label attribute to various components (elastic#…
88fff98 
…20117)
peteharverson added a commit that referenced this pull request Jun 21, 2018
@peteharverson
[ML] Add missing aria-label attribute to various components (#20117) (#…
66a73dd 
…20119)
This was referenced Jun 21, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection Feature:ml-results legacy - do not use :ml Project:Accessibility review v6.4.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peteharverson @elasticmachine @jgowdyelastic