[8.17] [Automatic Import] Correctly output icons in the manifest (#201139) #201224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1139) ## Release Note Fixes a bug in Automatic Import where icons were not shown after the integration was installed. ## Summary Closes elastic#201008. When implementing safe manifest output elastic#192316 a bug crept in: the icons array was incorrectly output as a dictionary icons: src: /img/logoElastic.svg title: syslog_test3 Logo size: 32x32 type: image/svg+xml and the test was not smart enough to pick it up: expect(manifest.icons).toBeTruthy(); We fix the field and add better tests for it. (cherry picked from commit 30e075a)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]
cc @ilyannn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.17:Questions ?
Please refer to the Backport tool documentation