fix(slo): remove KibanaThemeProvider' #201257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdelemme
added
release_note:skip
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
shahzad31
approved these changes
Nov 21, 2024
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History |
|
Starting backport for target branches: 8.17, 8.x https://github.com/elastic/kibana/actions/runs/11973899032 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 22, 2024
(cherry picked from commit 455a075)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 22, 2024
(cherry picked from commit 455a075)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This was referenced Nov 22, 2024
kibanamachine
added a commit
that referenced
this pull request
Nov 22, 2024
# Backport This will backport the following commits from `main` to `8.17`: - [fix(slo): remove KibanaThemeProvider' (#201257)](#201257) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2024-11-22T13:52:09Z","message":"fix(slo): remove KibanaThemeProvider' (#201257)","sha":"455a075495e5857fbf3a1c885c5836dc8a0611f5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.17.0"],"title":"fix(slo): remove KibanaThemeProvider'","number":201257,"url":"https://github.com/elastic/kibana/pull/201257","mergeCommit":{"message":"fix(slo): remove KibanaThemeProvider' (#201257)","sha":"455a075495e5857fbf3a1c885c5836dc8a0611f5"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201257","number":201257,"mergeCommit":{"message":"fix(slo): remove KibanaThemeProvider' (#201257)","sha":"455a075495e5857fbf3a1c885c5836dc8a0611f5"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Nov 22, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [fix(slo): remove KibanaThemeProvider' (#201257)](#201257) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2024-11-22T13:52:09Z","message":"fix(slo): remove KibanaThemeProvider' (#201257)","sha":"455a075495e5857fbf3a1c885c5836dc8a0611f5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.17.0"],"title":"fix(slo): remove KibanaThemeProvider'","number":201257,"url":"https://github.com/elastic/kibana/pull/201257","mergeCommit":{"message":"fix(slo): remove KibanaThemeProvider' (#201257)","sha":"455a075495e5857fbf3a1c885c5836dc8a0611f5"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201257","number":201257,"mergeCommit":{"message":"fix(slo): remove KibanaThemeProvider' (#201257)","sha":"455a075495e5857fbf3a1c885c5836dc8a0611f5"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the usage of KibanaThemeProvider from the SLO mounted providers, which removes the following toast error: