Revert "[dashboard] fix Reset dashboard breaks panel state when ran after editor edits (#201687)" #201902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter editor edits (elastic#201687)" This reverts commit 289bb16.
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7498[✅] x-pack/test_serverless/functional/test_suites/search/common_configs/config.group4.ts: 25/25 tests passed. |
kibanamachine
added
v9.0.0
backport:skip
💚 Build Succeeded
Metrics [docs]Async chunks
|
jbudz
added
backport:version
|
Starting backport for target branches: 8.16, 8.17 https://github.com/elastic/kibana/actions/runs/12053951430 |
|
Starting backport for target branches: 8.16, 8.17 https://github.com/elastic/kibana/actions/runs/12053951432 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 27, 2024
…fter editor edits (elastic#201687)" (elastic#201902) This reverts commit 289bb16. (cherry picked from commit a0f88d9)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 27, 2024
…fter editor edits (elastic#201687)" (elastic#201902) This reverts commit 289bb16. (cherry picked from commit a0f88d9)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 27, 2024
…e when ran after editor edits (#201687)" (#201902) (#202019) # Backport This will backport the following commits from `main` to `8.17`: - [Revert "[dashboard] fix Reset dashboard breaks panel state when ran after editor edits (#201687)" (#201902)](#201902) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jon","email":"jon@elastic.co"},"sourceCommit":{"committedDate":"2024-11-27T04:53:22Z","message":"Revert \"[dashboard] fix Reset dashboard breaks panel state when ran after editor edits (#201687)\" (#201902)\n\nThis reverts commit 289bb16.","sha":"a0f88d90134f8c49b32cffe23f438a91f77c7055","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["v9.0.0","backport:version","v8.17.0","v8.16.2"],"title":"Revert \"[dashboard] fix Reset dashboard breaks panel state when ran after editor edits (#201687)\"","number":201902,"url":"https://github.com/elastic/kibana/pull/201902","mergeCommit":{"message":"Revert \"[dashboard] fix Reset dashboard breaks panel state when ran after editor edits (#201687)\" (#201902)\n\nThis reverts commit 289bb16.","sha":"a0f88d90134f8c49b32cffe23f438a91f77c7055"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201902","number":201902,"mergeCommit":{"message":"Revert \"[dashboard] fix Reset dashboard breaks panel state when ran after editor edits (#201687)\" (#201902)\n\nThis reverts commit 289bb16.","sha":"a0f88d90134f8c49b32cffe23f438a91f77c7055"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jon <jon@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Nov 27, 2024
…e when ran after editor edits (#201687)" (#201902) (#202018) # Backport This will backport the following commits from `main` to `8.16`: - [Revert "[dashboard] fix Reset dashboard breaks panel state when ran after editor edits (#201687)" (#201902)](#201902) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jon","email":"jon@elastic.co"},"sourceCommit":{"committedDate":"2024-11-27T04:53:22Z","message":"Revert \"[dashboard] fix Reset dashboard breaks panel state when ran after editor edits (#201687)\" (#201902)\n\nThis reverts commit 289bb16.","sha":"a0f88d90134f8c49b32cffe23f438a91f77c7055","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["v9.0.0","backport:version","v8.17.0","v8.16.2"],"title":"Revert \"[dashboard] fix Reset dashboard breaks panel state when ran after editor edits (#201687)\"","number":201902,"url":"https://github.com/elastic/kibana/pull/201902","mergeCommit":{"message":"Revert \"[dashboard] fix Reset dashboard breaks panel state when ran after editor edits (#201687)\" (#201902)\n\nThis reverts commit 289bb16.","sha":"a0f88d90134f8c49b32cffe23f438a91f77c7055"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201902","number":201902,"mergeCommit":{"message":"Revert \"[dashboard] fix Reset dashboard breaks panel state when ran after editor edits (#201687)\" (#201902)\n\nThis reverts commit 289bb16.","sha":"a0f88d90134f8c49b32cffe23f438a91f77c7055"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jon <jon@elastic.co>
1 task
dej611
added a commit
that referenced
this pull request
Nov 29, 2024
## Summary Fixes: #190737, #190802, #190990, #179307 This test started failing after @nreese Reset PR was merged here: #201687 and the Lens embeddable refactor PR introducing a regression which affected the test. Later on the PR was reverted with #201902 . ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
…2275) ## Summary Fixes: elastic#190737, elastic#190802, elastic#190990, elastic#179307 This test started failing after @nreese Reset PR was merged here: elastic#201687 and the Lens embeddable refactor PR introducing a regression which affected the test. Later on the PR was reverted with elastic#201902 . ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…fter editor edits (elastic#201687)" (elastic#201902) This reverts commit 289bb16.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…2275) ## Summary Fixes: elastic#190737, elastic#190802, elastic#190990, elastic#179307 This test started failing after @nreese Reset PR was merged here: elastic#201687 and the Lens embeddable refactor PR introducing a regression which affected the test. Later on the PR was reverted with elastic#201902 . ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 289bb16.