[8.x] [Rules migration] Add install and install all migration rules endpoints (#11283) (#202026)
#202368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…points (elastic#11283) (elastic#202026) ## Summary [Internal link](elastic/security-team#10820) to the feature details With these changes we two new routes: * `/internal/siem_migrations/rules/install`: allows to install a specific set of migration rules * `/internal/siem_migrations/rules/install_translated`: allows to install all translated rules in specified migration Also we connect these two new API calls with the "Install" button within the "migration rules" table and the "Install translated rules" button on the "SIEM migration rules" page. ### Screenshots https://github.com/user-attachments/assets/29390d07-eab5-4157-8958-1e3f8459db09 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com> (cherry picked from commit 07fbb92) # Conflicts: # x-pack/plugins/security_solution/public/siem_migrations/rules/api/api.ts # x-pack/plugins/security_solution/server/lib/siem_migrations/rules/task/agent/nodes/match_prebuilt_rule/match_prebuilt_rule.ts # x-pack/test/api_integration/services/security_solution_api.gen.ts
semd
approved these changes
Nov 30, 2024
semd
reviewed
Nov 30, 2024
| @@ -51,6 +52,7 @@ export const getMatchPrebuiltRuleNode = | |||
| description: result.rule.description, | |||
| prebuilt_rule_id: result.rule.rule_id, | |||
| id: result.installedRuleId, | |||
| translation_result: SiemMigrationRuleTranslationResult.FULL, | |||
There was a problem hiding this comment.
The translation_result goes outside elatic_rule, I wonder how the linter accepted this 🤔
I'll fix it on the following backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:installandinstall allmigration rules endpoints (#11283) (#202026)Questions ?
Please refer to the Backport tool documentation