Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sustainable Kibana Architecture: Move modules owned by @elastic/appex-ai-infra #202410

Merged
merged 7 commits into from
Dec 10, 2024

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Dec 2, 2024

Summary

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.

Important

  • We kindly ask you to:
    • Manually fix the errors in the error section below (if there are any).
    • Search for the packages[\/\\] and plugins[\/\\] patterns in the source code (Babel and Eslint config files), and update them appropriately.
    • Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names
    • Review all of the updated files, specially the .ts and .js files listed in the sections below, as some of them contain relative paths that have been updated.
    • Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.:
      • customised eslint rules
      • docs pointing to source code

Note

This PR has been auto-generated.
Do not attempt to push any changes unless you know what you are doing.
Please use #sustainable_kibana_architecture Slack channel for feedback.

3 plugin(s) are going to be relocated:

Id Target folder
@kbn/inference-plugin x-pack/platform/plugins/shared/inference
@kbn/llm-tasks-plugin x-pack/platform/plugins/shared/ai_infra/llm_tasks
@kbn/product-doc-base-plugin x-pack/platform/plugins/shared/ai_infra/product_doc_base

2 package(s) are going to be relocated:

Id Target folder
@kbn/inference-common x-pack/platform/packages/shared/ai-infra/inference-common
@kbn/product-doc-common x-pack/platform/packages/shared/ai-infra/product-doc-common
Updated references
./docs/developer/plugin-list.asciidoc
./package.json
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./tsconfig.base.json
./x-pack/.i18nrc.json
./x-pack/platform/packages/shared/ai-infra/inference-common/jest.config.js
./x-pack/platform/packages/shared/ai-infra/product-doc-common/jest.config.js
./x-pack/platform/plugins/shared/ai_infra/llm_tasks/jest.config.js
./x-pack/platform/plugins/shared/ai_infra/product_doc_base/jest.config.js
./x-pack/platform/plugins/shared/inference/jest.config.js
./x-pack/platform/plugins/shared/inference/scripts/evaluation/README.md
./yarn.lock
Updated relative paths
x-pack/platform/packages/shared/ai-infra/inference-common/jest.config.js:10
x-pack/platform/packages/shared/ai-infra/inference-common/tsconfig.json:2
x-pack/platform/packages/shared/ai-infra/product-doc-common/jest.config.js:10
x-pack/platform/packages/shared/ai-infra/product-doc-common/tsconfig.json:2
x-pack/platform/plugins/shared/ai_infra/llm_tasks/jest.config.js:10
x-pack/platform/plugins/shared/ai_infra/llm_tasks/tsconfig.json:2
x-pack/platform/plugins/shared/ai_infra/llm_tasks/tsconfig.json:7
x-pack/platform/plugins/shared/ai_infra/product_doc_base/jest.config.js:10
x-pack/platform/plugins/shared/ai_infra/product_doc_base/tsconfig.json:2
x-pack/platform/plugins/shared/ai_infra/product_doc_base/tsconfig.json:7
x-pack/platform/plugins/shared/inference/jest.config.js:10
x-pack/platform/plugins/shared/inference/scripts/util/read_kibana_config.ts:16
x-pack/platform/plugins/shared/inference/tsconfig.json:2
x-pack/platform/plugins/shared/inference/tsconfig.json:7
Script errors

@gsoldevila gsoldevila added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:AI Infra AppEx AI Infrastructure Team labels Dec 2, 2024
@gsoldevila gsoldevila requested review from a team as code owners December 2, 2024 09:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-ai-infra (Team:AI Infra)

Copy link
Contributor

github-actions bot commented Dec 2, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@gsoldevila gsoldevila added backport:skip This commit does not require backporting and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 4, 2024
@gsoldevila gsoldevila changed the title Sustainable Kibana Architecture: Move modules owned by appex-ai-infra Sustainable Kibana Architecture: Move modules owned by @elastic/appex-ai-infra Dec 4, 2024
@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-appex-ai-infra branch 2 times, most recently from 90f1c30 to 810735c Compare December 5, 2024 06:54
@gsoldevila gsoldevila requested a review from a team as a code owner December 5, 2024 06:54
@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-appex-ai-infra branch from 810735c to b273020 Compare December 9, 2024 10:05
@@ -156,7 +156,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
(await doAnyChangesMatch([
/^x-pack\/packages\/ai-infra/,
/^x-pack\/plugins\/ai_infra/,
/^x-pack\/plugins\/inference/,
/^x-pack\/platform\/plugins\/shared\/inference/,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two previous lines,

/^x-pack\/packages\/ai-infra/,
/^x-pack\/plugins\/ai_infra/,

Needs to be adapted too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This escapes the power of the relocate script, need to be fixed manually.
I'll be grateful if you can update it and push changes to the branch!

Copy link
Contributor

@delanni delanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, provided Pierre's path updates are addressed

Copy link
Contributor

@rudolf rudolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core owned files (kibana.jsonc) were only moved not changed.

Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably LGTM

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Security GenAI! Code reviewed and successfully tested the Security AI Assistant features that rely on ai infra packages (ProductDocumentationTool and NaturalLanguageESQLTool)

@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-appex-ai-infra branch from c60b748 to e702577 Compare December 9, 2024 15:25
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 9, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #57 / Observability AI Assistant API tests public_complete/public_complete.spec.ts /api/observability_ai_assistant/chat/complete after executing an action closes the stream without persisting the conversation
  • [job] [logs] FTR Configs #64 / serverless search UI connectors create and configure connector edit type
  • [job] [logs] FTR Configs #64 / serverless search UI connectors create and configure connector edit type

Metrics [docs]

✅ unchanged

History

@gsoldevila gsoldevila merged commit a0f5a7f into elastic:main Dec 10, 2024
8 checks passed
@gsoldevila gsoldevila added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Dec 10, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12254309779

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12254309727

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [UA] kibana-core ownership (#203410)
- [Security Solution] - Update codeowners (#202046)

Manual backport

To create the backport manually run:

node scripts/backport --pr 202410

Questions ?

Please refer to the Backport tool documentation

1 similar comment
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [UA] kibana-core ownership (#203410)
- [Security Solution] - Update codeowners (#202046)

Manual backport

To create the backport manually run:

node scripts/backport --pr 202410

Questions ?

Please refer to the Backport tool documentation

gsoldevila added a commit to gsoldevila/kibana that referenced this pull request Dec 10, 2024
…x-ai-infra` (elastic#202410)

## Summary

This PR aims at relocating some of the Kibana modules (plugins and
packages) into a new folder structure, according to the _Sustainable
Kibana Architecture_ initiative.

> [!IMPORTANT]
> * We kindly ask you to:
> * Manually fix the errors in the error section below (if there are
any).
> * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the
source code (Babel and Eslint config files), and update them
appropriately.
> * Manually review
`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that
any CI pipeline customizations continue to be correctly applied after
the changed path names
> * Review all of the updated files, specially the `.ts` and `.js` files
listed in the sections below, as some of them contain relative paths
that have been updated.
> * Think of potential impact of the move, including tooling and
configuration files that can be pointing to the relocated modules. E.g.:
>     * customised eslint rules
>     * docs pointing to source code

> [!NOTE]
> This PR has been auto-generated.
> Do not attempt to push any changes unless you know what you are doing.
> Please use
[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)
Slack channel for feedback.

#### 3 plugin(s) are going to be relocated:

| Id | Target folder |
| -- | ------------- |
| `@kbn/inference-plugin` | `x-pack/platform/plugins/shared/inference` |
| `@kbn/llm-tasks-plugin` |
`x-pack/platform/plugins/shared/ai_infra/llm_tasks` |
| `@kbn/product-doc-base-plugin` |
`x-pack/platform/plugins/shared/ai_infra/product_doc_base` |

#### 2 package(s) are going to be relocated:

  | Id | Target folder |
  | -- | ------------- |
| `@kbn/inference-common` |
`x-pack/platform/packages/shared/ai-infra/inference-common` |
| `@kbn/product-doc-common` |
`x-pack/platform/packages/shared/ai-infra/product-doc-common` |

<details>
<summary>Updated references</summary>

```
./docs/developer/plugin-list.asciidoc
./package.json
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./tsconfig.base.json
./x-pack/.i18nrc.json
./x-pack/platform/packages/shared/ai-infra/inference-common/jest.config.js
./x-pack/platform/packages/shared/ai-infra/product-doc-common/jest.config.js
./x-pack/platform/plugins/shared/ai_infra/llm_tasks/jest.config.js
./x-pack/platform/plugins/shared/ai_infra/product_doc_base/jest.config.js
./x-pack/platform/plugins/shared/inference/jest.config.js
./x-pack/platform/plugins/shared/inference/scripts/evaluation/README.md
./yarn.lock
```
</details>
<details>
<summary>Updated relative paths</summary>

```
x-pack/platform/packages/shared/ai-infra/inference-common/jest.config.js:10
x-pack/platform/packages/shared/ai-infra/inference-common/tsconfig.json:2
x-pack/platform/packages/shared/ai-infra/product-doc-common/jest.config.js:10
x-pack/platform/packages/shared/ai-infra/product-doc-common/tsconfig.json:2
x-pack/platform/plugins/shared/ai_infra/llm_tasks/jest.config.js:10
x-pack/platform/plugins/shared/ai_infra/llm_tasks/tsconfig.json:2
x-pack/platform/plugins/shared/ai_infra/llm_tasks/tsconfig.json:7
x-pack/platform/plugins/shared/ai_infra/product_doc_base/jest.config.js:10
x-pack/platform/plugins/shared/ai_infra/product_doc_base/tsconfig.json:2
x-pack/platform/plugins/shared/ai_infra/product_doc_base/tsconfig.json:7
x-pack/platform/plugins/shared/inference/jest.config.js:10
x-pack/platform/plugins/shared/inference/scripts/util/read_kibana_config.ts:16
x-pack/platform/plugins/shared/inference/tsconfig.json:2
x-pack/platform/plugins/shared/inference/tsconfig.json:7
```
</details>
<details>
<summary>Script errors</summary>

```

```
</details>

---------

Co-authored-by: pgayvallet <pierre.gayvallet@elastic.co>
(cherry picked from commit a0f5a7f)

# Conflicts:
#	.github/CODEOWNERS
@gsoldevila
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

gsoldevila added a commit that referenced this pull request Dec 10, 2024
…c/appex-ai-infra` (#202410) (#203541)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Sustainable Kibana Architecture: Move modules owned by
`@elastic/appex-ai-infra`
(#202410)](#202410)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2024-12-10T10:36:23Z","message":"Sustainable
Kibana Architecture: Move modules owned by `@elastic/appex-ai-infra`
(#202410)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the
Kibana modules (plugins and\r\npackages) into a new folder structure,
according to the _Sustainable\r\nKibana Architecture_
initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> *
Manually fix the errors in the error section below (if there
are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and
`plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint
config files), and update them\r\nappropriately.\r\n> * Manually
review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\r\nany CI pipeline customizations continue to be correctly
applied after\r\nthe changed path names\r\n> * Review all of the updated
files, specially the `.ts` and `.js` files\r\nlisted in the sections
below, as some of them contain relative paths\r\nthat have been
updated.\r\n> * Think of potential impact of the move, including tooling
and\r\nconfiguration files that can be pointing to the relocated
modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to
source code\r\n\r\n> [!NOTE]\r\n> This PR has been auto-generated.\r\n>
Do not attempt to push any changes unless you know what you are
doing.\r\n> Please
use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack
channel for feedback.\r\n\r\n\r\n\r\n\r\n#### 3 plugin(s) are going to
be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | -------------
|\r\n| `@kbn/inference-plugin` |
`x-pack/platform/plugins/shared/inference` |\r\n|
`@kbn/llm-tasks-plugin`
|\r\n`x-pack/platform/plugins/shared/ai_infra/llm_tasks` |\r\n|
`@kbn/product-doc-base-plugin`
|\r\n`x-pack/platform/plugins/shared/ai_infra/product_doc_base`
|\r\n\r\n\r\n#### 2 package(s) are going to be relocated:\r\n\r\n | Id |
Target folder |\r\n | -- | ------------- |\r\n| `@kbn/inference-common`
|\r\n`x-pack/platform/packages/shared/ai-infra/inference-common` |\r\n|
`@kbn/product-doc-common`
|\r\n`x-pack/platform/packages/shared/ai-infra/product-doc-common`
|\r\n\r\n\r\n<details>\r\n<summary>Updated
references</summary>\r\n\r\n```\r\n./docs/developer/plugin-list.asciidoc\r\n./package.json\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./tsconfig.base.json\r\n./x-pack/.i18nrc.json\r\n./x-pack/platform/packages/shared/ai-infra/inference-common/jest.config.js\r\n./x-pack/platform/packages/shared/ai-infra/product-doc-common/jest.config.js\r\n./x-pack/platform/plugins/shared/ai_infra/llm_tasks/jest.config.js\r\n./x-pack/platform/plugins/shared/ai_infra/product_doc_base/jest.config.js\r\n./x-pack/platform/plugins/shared/inference/jest.config.js\r\n./x-pack/platform/plugins/shared/inference/scripts/evaluation/README.md\r\n./yarn.lock\r\n```\r\n</details>\r\n<details>\r\n<summary>Updated
relative
paths</summary>\r\n\r\n```\r\nx-pack/platform/packages/shared/ai-infra/inference-common/jest.config.js:10\r\nx-pack/platform/packages/shared/ai-infra/inference-common/tsconfig.json:2\r\nx-pack/platform/packages/shared/ai-infra/product-doc-common/jest.config.js:10\r\nx-pack/platform/packages/shared/ai-infra/product-doc-common/tsconfig.json:2\r\nx-pack/platform/plugins/shared/ai_infra/llm_tasks/jest.config.js:10\r\nx-pack/platform/plugins/shared/ai_infra/llm_tasks/tsconfig.json:2\r\nx-pack/platform/plugins/shared/ai_infra/llm_tasks/tsconfig.json:7\r\nx-pack/platform/plugins/shared/ai_infra/product_doc_base/jest.config.js:10\r\nx-pack/platform/plugins/shared/ai_infra/product_doc_base/tsconfig.json:2\r\nx-pack/platform/plugins/shared/ai_infra/product_doc_base/tsconfig.json:7\r\nx-pack/platform/plugins/shared/inference/jest.config.js:10\r\nx-pack/platform/plugins/shared/inference/scripts/util/read_kibana_config.ts:16\r\nx-pack/platform/plugins/shared/inference/tsconfig.json:2\r\nx-pack/platform/plugins/shared/inference/tsconfig.json:7\r\n```\r\n</details>\r\n<details>\r\n<summary>Script
errors</summary>\r\n\r\n```\r\n\r\n```\r\n</details>\r\n\r\n---------\r\n\r\nCo-authored-by:
pgayvallet
<pierre.gayvallet@elastic.co>","sha":"a0f5a7f3fc23d4ba241bc511ddd2987a679ec00d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:prev-minor","Team:AI
Infra","ci:all-gen-ai-suites"],"number":202410,"url":"https://github.com/elastic/kibana/pull/202410","mergeCommit":{"message":"Sustainable
Kibana Architecture: Move modules owned by `@elastic/appex-ai-infra`
(#202410)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the
Kibana modules (plugins and\r\npackages) into a new folder structure,
according to the _Sustainable\r\nKibana Architecture_
initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> *
Manually fix the errors in the error section below (if there
are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and
`plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint
config files), and update them\r\nappropriately.\r\n> * Manually
review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\r\nany CI pipeline customizations continue to be correctly
applied after\r\nthe changed path names\r\n> * Review all of the updated
files, specially the `.ts` and `.js` files\r\nlisted in the sections
below, as some of them contain relative paths\r\nthat have been
updated.\r\n> * Think of potential impact of the move, including tooling
and\r\nconfiguration files that can be pointing to the relocated
modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to
source code\r\n\r\n> [!NOTE]\r\n> This PR has been auto-generated.\r\n>
Do not attempt to push any changes unless you know what you are
doing.\r\n> Please
use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack
channel for feedback.\r\n\r\n\r\n\r\n\r\n#### 3 plugin(s) are going to
be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | -------------
|\r\n| `@kbn/inference-plugin` |
`x-pack/platform/plugins/shared/inference` |\r\n|
`@kbn/llm-tasks-plugin`
|\r\n`x-pack/platform/plugins/shared/ai_infra/llm_tasks` |\r\n|
`@kbn/product-doc-base-plugin`
|\r\n`x-pack/platform/plugins/shared/ai_infra/product_doc_base`
|\r\n\r\n\r\n#### 2 package(s) are going to be relocated:\r\n\r\n | Id |
Target folder |\r\n | -- | ------------- |\r\n| `@kbn/inference-common`
|\r\n`x-pack/platform/packages/shared/ai-infra/inference-common` |\r\n|
`@kbn/product-doc-common`
|\r\n`x-pack/platform/packages/shared/ai-infra/product-doc-common`
|\r\n\r\n\r\n<details>\r\n<summary>Updated
references</summary>\r\n\r\n```\r\n./docs/developer/plugin-list.asciidoc\r\n./package.json\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./tsconfig.base.json\r\n./x-pack/.i18nrc.json\r\n./x-pack/platform/packages/shared/ai-infra/inference-common/jest.config.js\r\n./x-pack/platform/packages/shared/ai-infra/product-doc-common/jest.config.js\r\n./x-pack/platform/plugins/shared/ai_infra/llm_tasks/jest.config.js\r\n./x-pack/platform/plugins/shared/ai_infra/product_doc_base/jest.config.js\r\n./x-pack/platform/plugins/shared/inference/jest.config.js\r\n./x-pack/platform/plugins/shared/inference/scripts/evaluation/README.md\r\n./yarn.lock\r\n```\r\n</details>\r\n<details>\r\n<summary>Updated
relative
paths</summary>\r\n\r\n```\r\nx-pack/platform/packages/shared/ai-infra/inference-common/jest.config.js:10\r\nx-pack/platform/packages/shared/ai-infra/inference-common/tsconfig.json:2\r\nx-pack/platform/packages/shared/ai-infra/product-doc-common/jest.config.js:10\r\nx-pack/platform/packages/shared/ai-infra/product-doc-common/tsconfig.json:2\r\nx-pack/platform/plugins/shared/ai_infra/llm_tasks/jest.config.js:10\r\nx-pack/platform/plugins/shared/ai_infra/llm_tasks/tsconfig.json:2\r\nx-pack/platform/plugins/shared/ai_infra/llm_tasks/tsconfig.json:7\r\nx-pack/platform/plugins/shared/ai_infra/product_doc_base/jest.config.js:10\r\nx-pack/platform/plugins/shared/ai_infra/product_doc_base/tsconfig.json:2\r\nx-pack/platform/plugins/shared/ai_infra/product_doc_base/tsconfig.json:7\r\nx-pack/platform/plugins/shared/inference/jest.config.js:10\r\nx-pack/platform/plugins/shared/inference/scripts/util/read_kibana_config.ts:16\r\nx-pack/platform/plugins/shared/inference/tsconfig.json:2\r\nx-pack/platform/plugins/shared/inference/tsconfig.json:7\r\n```\r\n</details>\r\n<details>\r\n<summary>Script
errors</summary>\r\n\r\n```\r\n\r\n```\r\n</details>\r\n\r\n---------\r\n\r\nCo-authored-by:
pgayvallet
<pierre.gayvallet@elastic.co>","sha":"a0f5a7f3fc23d4ba241bc511ddd2987a679ec00d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202410","number":202410,"mergeCommit":{"message":"Sustainable
Kibana Architecture: Move modules owned by `@elastic/appex-ai-infra`
(#202410)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the
Kibana modules (plugins and\r\npackages) into a new folder structure,
according to the _Sustainable\r\nKibana Architecture_
initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> *
Manually fix the errors in the error section below (if there
are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and
`plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint
config files), and update them\r\nappropriately.\r\n> * Manually
review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\r\nany CI pipeline customizations continue to be correctly
applied after\r\nthe changed path names\r\n> * Review all of the updated
files, specially the `.ts` and `.js` files\r\nlisted in the sections
below, as some of them contain relative paths\r\nthat have been
updated.\r\n> * Think of potential impact of the move, including tooling
and\r\nconfiguration files that can be pointing to the relocated
modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to
source code\r\n\r\n> [!NOTE]\r\n> This PR has been auto-generated.\r\n>
Do not attempt to push any changes unless you know what you are
doing.\r\n> Please
use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack
channel for feedback.\r\n\r\n\r\n\r\n\r\n#### 3 plugin(s) are going to
be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | -------------
|\r\n| `@kbn/inference-plugin` |
`x-pack/platform/plugins/shared/inference` |\r\n|
`@kbn/llm-tasks-plugin`
|\r\n`x-pack/platform/plugins/shared/ai_infra/llm_tasks` |\r\n|
`@kbn/product-doc-base-plugin`
|\r\n`x-pack/platform/plugins/shared/ai_infra/product_doc_base`
|\r\n\r\n\r\n#### 2 package(s) are going to be relocated:\r\n\r\n | Id |
Target folder |\r\n | -- | ------------- |\r\n| `@kbn/inference-common`
|\r\n`x-pack/platform/packages/shared/ai-infra/inference-common` |\r\n|
`@kbn/product-doc-common`
|\r\n`x-pack/platform/packages/shared/ai-infra/product-doc-common`
|\r\n\r\n\r\n<details>\r\n<summary>Updated
references</summary>\r\n\r\n```\r\n./docs/developer/plugin-list.asciidoc\r\n./package.json\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./tsconfig.base.json\r\n./x-pack/.i18nrc.json\r\n./x-pack/platform/packages/shared/ai-infra/inference-common/jest.config.js\r\n./x-pack/platform/packages/shared/ai-infra/product-doc-common/jest.config.js\r\n./x-pack/platform/plugins/shared/ai_infra/llm_tasks/jest.config.js\r\n./x-pack/platform/plugins/shared/ai_infra/product_doc_base/jest.config.js\r\n./x-pack/platform/plugins/shared/inference/jest.config.js\r\n./x-pack/platform/plugins/shared/inference/scripts/evaluation/README.md\r\n./yarn.lock\r\n```\r\n</details>\r\n<details>\r\n<summary>Updated
relative
paths</summary>\r\n\r\n```\r\nx-pack/platform/packages/shared/ai-infra/inference-common/jest.config.js:10\r\nx-pack/platform/packages/shared/ai-infra/inference-common/tsconfig.json:2\r\nx-pack/platform/packages/shared/ai-infra/product-doc-common/jest.config.js:10\r\nx-pack/platform/packages/shared/ai-infra/product-doc-common/tsconfig.json:2\r\nx-pack/platform/plugins/shared/ai_infra/llm_tasks/jest.config.js:10\r\nx-pack/platform/plugins/shared/ai_infra/llm_tasks/tsconfig.json:2\r\nx-pack/platform/plugins/shared/ai_infra/llm_tasks/tsconfig.json:7\r\nx-pack/platform/plugins/shared/ai_infra/product_doc_base/jest.config.js:10\r\nx-pack/platform/plugins/shared/ai_infra/product_doc_base/tsconfig.json:2\r\nx-pack/platform/plugins/shared/ai_infra/product_doc_base/tsconfig.json:7\r\nx-pack/platform/plugins/shared/inference/jest.config.js:10\r\nx-pack/platform/plugins/shared/inference/scripts/util/read_kibana_config.ts:16\r\nx-pack/platform/plugins/shared/inference/tsconfig.json:2\r\nx-pack/platform/plugins/shared/inference/tsconfig.json:7\r\n```\r\n</details>\r\n<details>\r\n<summary>Script
errors</summary>\r\n\r\n```\r\n\r\n```\r\n</details>\r\n\r\n---------\r\n\r\nCo-authored-by:
pgayvallet
<pierre.gayvallet@elastic.co>","sha":"a0f5a7f3fc23d4ba241bc511ddd2987a679ec00d"}}]}]
BACKPORT-->
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
…x-ai-infra` (elastic#202410)

## Summary

This PR aims at relocating some of the Kibana modules (plugins and
packages) into a new folder structure, according to the _Sustainable
Kibana Architecture_ initiative.

> [!IMPORTANT]
> * We kindly ask you to:
> * Manually fix the errors in the error section below (if there are
any).
> * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the
source code (Babel and Eslint config files), and update them
appropriately.
> * Manually review
`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that
any CI pipeline customizations continue to be correctly applied after
the changed path names
> * Review all of the updated files, specially the `.ts` and `.js` files
listed in the sections below, as some of them contain relative paths
that have been updated.
> * Think of potential impact of the move, including tooling and
configuration files that can be pointing to the relocated modules. E.g.:
>     * customised eslint rules
>     * docs pointing to source code

> [!NOTE]
> This PR has been auto-generated.
> Do not attempt to push any changes unless you know what you are doing.
> Please use
[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)
Slack channel for feedback.




#### 3 plugin(s) are going to be relocated:

| Id | Target folder |
| -- | ------------- |
| `@kbn/inference-plugin` | `x-pack/platform/plugins/shared/inference` |
| `@kbn/llm-tasks-plugin` |
`x-pack/platform/plugins/shared/ai_infra/llm_tasks` |
| `@kbn/product-doc-base-plugin` |
`x-pack/platform/plugins/shared/ai_infra/product_doc_base` |


#### 2 package(s) are going to be relocated:

  | Id | Target folder |
  | -- | ------------- |
| `@kbn/inference-common` |
`x-pack/platform/packages/shared/ai-infra/inference-common` |
| `@kbn/product-doc-common` |
`x-pack/platform/packages/shared/ai-infra/product-doc-common` |


<details>
<summary>Updated references</summary>

```
./docs/developer/plugin-list.asciidoc
./package.json
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./tsconfig.base.json
./x-pack/.i18nrc.json
./x-pack/platform/packages/shared/ai-infra/inference-common/jest.config.js
./x-pack/platform/packages/shared/ai-infra/product-doc-common/jest.config.js
./x-pack/platform/plugins/shared/ai_infra/llm_tasks/jest.config.js
./x-pack/platform/plugins/shared/ai_infra/product_doc_base/jest.config.js
./x-pack/platform/plugins/shared/inference/jest.config.js
./x-pack/platform/plugins/shared/inference/scripts/evaluation/README.md
./yarn.lock
```
</details>
<details>
<summary>Updated relative paths</summary>

```
x-pack/platform/packages/shared/ai-infra/inference-common/jest.config.js:10
x-pack/platform/packages/shared/ai-infra/inference-common/tsconfig.json:2
x-pack/platform/packages/shared/ai-infra/product-doc-common/jest.config.js:10
x-pack/platform/packages/shared/ai-infra/product-doc-common/tsconfig.json:2
x-pack/platform/plugins/shared/ai_infra/llm_tasks/jest.config.js:10
x-pack/platform/plugins/shared/ai_infra/llm_tasks/tsconfig.json:2
x-pack/platform/plugins/shared/ai_infra/llm_tasks/tsconfig.json:7
x-pack/platform/plugins/shared/ai_infra/product_doc_base/jest.config.js:10
x-pack/platform/plugins/shared/ai_infra/product_doc_base/tsconfig.json:2
x-pack/platform/plugins/shared/ai_infra/product_doc_base/tsconfig.json:7
x-pack/platform/plugins/shared/inference/jest.config.js:10
x-pack/platform/plugins/shared/inference/scripts/util/read_kibana_config.ts:16
x-pack/platform/plugins/shared/inference/tsconfig.json:2
x-pack/platform/plugins/shared/inference/tsconfig.json:7
```
</details>
<details>
<summary>Script errors</summary>

```

```
</details>

---------

Co-authored-by: pgayvallet <pierre.gayvallet@elastic.co>
@rudolf rudolf added the plugin groups Relocate all plugins and packages under their respective platform/solution groups label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:all-gen-ai-suites plugin groups Relocate all plugins and packages under their respective platform/solution groups release_note:skip Skip the PR/issue when compiling release notes Team:AI Infra AppEx AI Infrastructure Team Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants