fix: [Search:AppSearch:Engines:Synonyms page]Button behind Manage synonym set dialog modal is announced by screen reader #202417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
added
release_note:skip
|
/ci |
…onym set dialog modal is announced by screen reader Closes: elastic#202272
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12154144095 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 4, 2024
…onym set dialog modal is announced by screen reader (elastic#202417) Closes: elastic#202272 ## Description Buttons which are behind dialog modals shouldn't be announced for the user using assistive technology. ## Changes Made: 1. The DELETE_VALUE_BUTTON_LABEL translation was updated to include the row index in its value. 2. A container with role="group" was created for input values. Now, the container is focused when the "Delete row" item is pressed. ## Screen <img width="1135" alt="image" src="https://github.com/user-attachments/assets/919a547c-f878-430b-b187-1273e698bb61"> (cherry picked from commit 258754d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 4, 2024
…ge synonym set dialog modal is announced by screen reader (#202417) (#202871) # Backport This will backport the following commits from `main` to `8.x`: - [fix: [Search:AppSearch:Engines:Synonyms page]Button behind Manage synonym set dialog modal is announced by screen reader (#202417)](#202417) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2024-12-04T06:18:18Z","message":"fix: [Search:AppSearch:Engines:Synonyms page]Button behind Manage synonym set dialog modal is announced by screen reader (#202417)\n\nCloses: #202272\r\n\r\n## Description\r\nButtons which are behind dialog modals shouldn't be announced for the\r\nuser using assistive technology.\r\n\r\n## Changes Made:\r\n1. The DELETE_VALUE_BUTTON_LABEL translation was updated to include the\r\nrow index in its value.\r\n2. A container with role=\"group\" was created for input values. Now, the\r\ncontainer is focused when the \"Delete row\" item is pressed.\r\n\r\n## Screen\r\n\r\n<img width=\"1135\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/919a547c-f878-430b-b187-1273e698bb61\">","sha":"258754d011d4fcc1be2ebe5834215e019c834949","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"fix: [Search:AppSearch:Engines:Synonyms page]Button behind Manage synonym set dialog modal is announced by screen reader","number":202417,"url":"https://github.com/elastic/kibana/pull/202417","mergeCommit":{"message":"fix: [Search:AppSearch:Engines:Synonyms page]Button behind Manage synonym set dialog modal is announced by screen reader (#202417)\n\nCloses: #202272\r\n\r\n## Description\r\nButtons which are behind dialog modals shouldn't be announced for the\r\nuser using assistive technology.\r\n\r\n## Changes Made:\r\n1. The DELETE_VALUE_BUTTON_LABEL translation was updated to include the\r\nrow index in its value.\r\n2. A container with role=\"group\" was created for input values. Now, the\r\ncontainer is focused when the \"Delete row\" item is pressed.\r\n\r\n## Screen\r\n\r\n<img width=\"1135\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/919a547c-f878-430b-b187-1273e698bb61\">","sha":"258754d011d4fcc1be2ebe5834215e019c834949"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202417","number":202417,"mergeCommit":{"message":"fix: [Search:AppSearch:Engines:Synonyms page]Button behind Manage synonym set dialog modal is announced by screen reader (#202417)\n\nCloses: #202272\r\n\r\n## Description\r\nButtons which are behind dialog modals shouldn't be announced for the\r\nuser using assistive technology.\r\n\r\n## Changes Made:\r\n1. The DELETE_VALUE_BUTTON_LABEL translation was updated to include the\r\nrow index in its value.\r\n2. A container with role=\"group\" was created for input values. Now, the\r\ncontainer is focused when the \"Delete row\" item is pressed.\r\n\r\n## Screen\r\n\r\n<img width=\"1135\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/919a547c-f878-430b-b187-1273e698bb61\">","sha":"258754d011d4fcc1be2ebe5834215e019c834949"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Dec 5, 2024
…onym set dialog modal is announced by screen reader (elastic#202417) Closes: elastic#202272 ## Description Buttons which are behind dialog modals shouldn't be announced for the user using assistive technology. ## Changes Made: 1. The DELETE_VALUE_BUTTON_LABEL translation was updated to include the row index in its value. 2. A container with role="group" was created for input values. Now, the container is focused when the "Delete row" item is pressed. ## Screen <img width="1135" alt="image" src="https://github.com/user-attachments/assets/919a547c-f878-430b-b187-1273e698bb61">
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
…onym set dialog modal is announced by screen reader (elastic#202417) Closes: elastic#202272 ## Description Buttons which are behind dialog modals shouldn't be announced for the user using assistive technology. ## Changes Made: 1. The DELETE_VALUE_BUTTON_LABEL translation was updated to include the row index in its value. 2. A container with role="group" was created for input values. Now, the container is focused when the "Delete row" item is pressed. ## Screen <img width="1135" alt="image" src="https://github.com/user-attachments/assets/919a547c-f878-430b-b187-1273e698bb61">
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…onym set dialog modal is announced by screen reader (elastic#202417) Closes: elastic#202272 ## Description Buttons which are behind dialog modals shouldn't be announced for the user using assistive technology. ## Changes Made: 1. The DELETE_VALUE_BUTTON_LABEL translation was updated to include the row index in its value. 2. A container with role="group" was created for input values. Now, the container is focused when the "Delete row" item is pressed. ## Screen <img width="1135" alt="image" src="https://github.com/user-attachments/assets/919a547c-f878-430b-b187-1273e698bb61">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #202272
Description
Buttons which are behind dialog modals shouldn't be announced for the user using assistive technology.
Changes Made:
Screen