[8.17] [Spaces UI] Role Editor Flyout Should Match in Roles Mgmt (#198182) #202821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8182) Part of elastic/kibana-team#1242 **Fixes for alignment of the Role editor flyout** 1. Remove the warning callout regarding global privileges that impact other privileges 1. Unify the info callouts regarding combination of privileges 1. set "Customize" as the default selected option when assigning new privileges 1. update placeholders for selector box when assigning privileges 1. Hide privileges controls if no spaces are selected 1. Update button group label text to "Define privileges" and align helper texts below 1. Align headers for assign/edit states 1. Remove descriptions under headers 1. Update size of info callout above button group to small 1. Reduce text size for the "Manage roles" link 1. Remove the "Additional Stack Management permissions can be found outside of this menu..." test for the Spaces Management context. **Polish fixes** 1. Remove features visible column 1. ~~Remove identifier column from spaces grid~~ 1. Fix vertical alignment of non-current space name in table 1. Ordered the listing of assigned roles during and after search 1. Removing a role from the space shows a confirmation modal 1. Update columns widths in the spaces grid 1. Remove the "By default your current view is Classic" callout Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) (cherry picked from commit 226924e)
6 tasks
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
|
jeramysoucy
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.17:Questions ?
Please refer to the Backport tool documentation