Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sustainable Kibana Architecture: Move modules owned by @elastic/security-detection-engine #202844

Merged
merged 27 commits into from
Dec 17, 2024
Merged

Sustainable Kibana Architecture: Move modules owned by @elastic/security-detection-engine #202844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
5095ca3
Relocating module `@kbn/lists-plugin`
gsoldevila Dec 17, 2024
1a113e3
Relocating module `@kbn/securitysolution-autocomplete`
gsoldevila Dec 17, 2024
a3c80c6
Relocating module `@kbn/securitysolution-endpoint-exceptions-common`
gsoldevila Dec 17, 2024
dfe0ac5
Relocating module `@kbn/securitysolution-es-utils`
gsoldevila Dec 17, 2024
6690ac8
Relocating module `@kbn/securitysolution-exception-list-components`
gsoldevila Dec 17, 2024
ef47283
Relocating module `@kbn/securitysolution-exceptions-common`
gsoldevila Dec 17, 2024
466eac1
Relocating module `@kbn/securitysolution-hook-utils`
gsoldevila Dec 17, 2024
b10e7bf
Relocating module `@kbn/securitysolution-io-ts-alerting-types`
gsoldevila Dec 17, 2024
09b903b
Relocating module `@kbn/securitysolution-io-ts-list-types`
gsoldevila Dec 17, 2024
b0a1df5
Relocating module `@kbn/securitysolution-io-ts-types`
gsoldevila Dec 17, 2024
afd129c
Relocating module `@kbn/securitysolution-io-ts-utils`
gsoldevila Dec 17, 2024
a39de31
Relocating module `@kbn/securitysolution-list-api`
gsoldevila Dec 17, 2024
6b25be9
Relocating module `@kbn/securitysolution-list-constants`
gsoldevila Dec 17, 2024
e0d4cec
Relocating module `@kbn/securitysolution-list-hooks`
gsoldevila Dec 17, 2024
5c73737
Relocating module `@kbn/securitysolution-list-utils`
gsoldevila Dec 17, 2024
75fd44f
Relocating module `@kbn/securitysolution-lists-common`
gsoldevila Dec 17, 2024
eeb8e23
Relocating module `@kbn/securitysolution-rules`
gsoldevila Dec 17, 2024
ddfd260
Relocating module `@kbn/securitysolution-t-grid`
gsoldevila Dec 17, 2024
3fd0cbd
Relocating module `@kbn/securitysolution-utils`
gsoldevila Dec 17, 2024
ed504de
Fix lists-common schema.yaml references
marshallmain Dec 11, 2024
e7bb50d
Fix exceptions-common schema.yaml references
marshallmain Dec 11, 2024
3fb45ef
Fix endpoint-exceptions-common schema.yaml references
marshallmain Dec 11, 2024
92a31f8
Add new lists plugin location to styled_components_files.js
marshallmain Dec 11, 2024
ea8aa10
Fix linting problems
marshallmain Dec 12, 2024
a48a50e
Update i18nrc paths
marshallmain Dec 12, 2024
1f98e02
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Dec 17, 2024
68594bf
Another i18n conflict fix
marshallmain Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
12 changes: 6 additions & 6 deletions .buildkite/scripts/pipelines/pull_request/pipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
/^packages\/kbn-securitysolution-.*/,
/^x-pack\/plugins\/alerting/,
/^x-pack\/plugins\/data_views\/common/,
/^x-pack\/plugins\/lists/,
/^x-pack\/solutions\/security\/plugins\/lists/,
/^x-pack\/plugins\/rule_registry\/common/,
/^x-pack\/solutions\/security\/plugins\/security_solution/,
/^x-pack\/solutions\/security\/plugins\/security_solution_ess/,
Expand Down Expand Up @@ -306,10 +306,10 @@ const getPipeline = (filename: string, removeSteps = true) => {
/^packages\/kbn-search-types/,
/^packages\/kbn-securitysolution-.*/,
/^src\/platform\/packages\/shared\/kbn-securitysolution-ecs/,
/^packages\/kbn-securitysolution-io-ts-alerting-types/,
/^packages\/kbn-securitysolution-io-ts-list-types/,
/^packages\/kbn-securitysolution-list-hooks/,
/^packages\/kbn-securitysolution-t-grid/,
/^x-pack\/solutions\/security\/packages\/kbn-securitysolution-io-ts-alerting-types/,
/^x-pack\/solutions\/security\/packages\/kbn-securitysolution-io-ts-list-types/,
/^x-pack\/solutions\/security\/packages\/kbn-securitysolution-list-hooks/,
/^x-pack\/solutions\/security\/packages\/kbn-securitysolution-t-grid/,
/^packages\/kbn-ui-theme/,
/^packages\/kbn-utility-types/,
/^packages\/react/,
Expand All @@ -335,7 +335,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
/^x-pack\/plugins\/cases/,
/^x-pack\/plugins\/data_views\/common/,
/^x-pack\/solutions\/security\/plugins\/elastic_assistant/,
/^x-pack\/plugins\/lists/,
/^x-pack\/solutions\/security\/plugins\/lists/,
/^x-pack\/plugins\/rule_registry\/common/,
/^x-pack\/solutions\/security\/plugins\/security_solution/,
/^x-pack\/solutions\/security\/plugins\/security_solution_ess/,
Expand Down
6 changes: 3 additions & 3 deletions .buildkite/scripts/steps/code_generation/security_solution_codegen.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ echo -e "\n[Security Solution OpenAPI Code Generation] OpenAPI Common Package\n"
(cd packages/kbn-openapi-common && yarn openapi:generate)

echo -e "\n[Security Solution OpenAPI Code Generation] Lists Common Package\n"
(cd packages/kbn-securitysolution-lists-common && yarn openapi:generate)
(cd x-pack/solutions/security/packages/kbn-securitysolution-lists-common && yarn openapi:generate)

echo -e "\n[Security Solution OpenAPI Code Generation] Exceptions Common Package\n"
(cd packages/kbn-securitysolution-exceptions-common && yarn openapi:generate)
(cd x-pack/solutions/security/packages/kbn-securitysolution-exceptions-common && yarn openapi:generate)

echo -e "\n[Security Solution OpenAPI Code Generation] Endpoint Exceptions Common Package\n"
(cd packages/kbn-securitysolution-endpoint-exceptions-common && yarn openapi:generate)
(cd x-pack/solutions/security/packages/kbn-securitysolution-endpoint-exceptions-common && yarn openapi:generate)

echo -e "\n[Security Solution OpenAPI Code Generation] Security Solution Plugin\n"
(cd x-pack/solutions/security/plugins/security_solution && yarn openapi:generate)
Expand Down
6 changes: 3 additions & 3 deletions .buildkite/scripts/steps/openapi_bundling/security_solution_openapi_bundling.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ echo -e "\n[Security Solution OpenAPI Bundling] Entity Analytics API\n"
(cd x-pack/solutions/security/plugins/security_solution && yarn openapi:bundle:entity-analytics)

echo -e "\n[Security Solution OpenAPI Bundling] Lists API\n"
(cd packages/kbn-securitysolution-lists-common && yarn openapi:bundle)
(cd x-pack/solutions/security/packages/kbn-securitysolution-lists-common && yarn openapi:bundle)

echo -e "\n[Security Solution OpenAPI Bundling] Exceptions API\n"
(cd packages/kbn-securitysolution-exceptions-common && yarn openapi:bundle)
(cd x-pack/solutions/security/packages/kbn-securitysolution-exceptions-common && yarn openapi:bundle)

echo -e "\n[Security Solution OpenAPI Bundling] Endpoint Exceptions API\n"
(cd packages/kbn-securitysolution-endpoint-exceptions-common && yarn openapi:bundle)
(cd x-pack/solutions/security/packages/kbn-securitysolution-endpoint-exceptions-common && yarn openapi:bundle)

echo -e "\n[Security Solution OpenAPI Bundling] Endpoint Management API\n"
(cd x-pack/solutions/security/plugins/security_solution && yarn openapi:bundle:endpoint-management)
Expand Down
18 changes: 12 additions & 6 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1343,8 +1343,8 @@ module.exports = {
{
// front end and common typescript and javascript files only
files: [
'x-pack/plugins/lists/public/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/lists/common/**/*.{js,mjs,ts,tsx}',
'x-pack/solutions/security/plugins/lists/public/**/*.{js,mjs,ts,tsx}',
'x-pack/solutions/security/plugins/lists/common/**/*.{js,mjs,ts,tsx}',
],
rules: {
'import/no-nodejs-modules': 'error',
Expand All @@ -1360,14 +1360,20 @@ module.exports = {
},
{
// typescript for /public and /common
files: ['x-pack/plugins/lists/public/*.{ts,tsx}', 'x-pack/plugins/lists/common/*.{ts,tsx}'],
files: [
'x-pack/solutions/security/plugins/lists/public/*.{ts,tsx}',
'x-pack/solutions/security/plugins/lists/common/*.{ts,tsx}',
],
rules: {
'@typescript-eslint/no-for-in-array': 'error',
},
},
{
// typescript for /public and /common
files: ['x-pack/plugins/lists/public/*.{ts,tsx}', 'x-pack/plugins/lists/common/*.{ts,tsx}'],
files: [
'x-pack/solutions/security/plugins/lists/public/*.{ts,tsx}',
'x-pack/solutions/security/plugins/lists/common/*.{ts,tsx}',
],
plugins: ['react'],
env: {
jest: true,
Expand Down Expand Up @@ -1425,7 +1431,7 @@ module.exports = {
},
},
{
files: ['x-pack/plugins/lists/public/**/!(*.test).{js,mjs,ts,tsx}'],
files: ['x-pack/solutions/security/plugins/lists/public/**/!(*.test).{js,mjs,ts,tsx}'],
plugins: ['react-perf'],
rules: {
'react-perf/jsx-no-new-object-as-prop': 'error',
Expand All @@ -1436,7 +1442,7 @@ module.exports = {
},
{
// typescript and javascript for front and back
files: ['x-pack/plugins/lists/**/*.{js,mjs,ts,tsx}'],
files: ['x-pack/solutions/security/plugins/lists/**/*.{js,mjs,ts,tsx}'],
plugins: ['eslint-plugin-node'],
env: {
jest: true,
Expand Down
68 changes: 34 additions & 34 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -454,24 +454,6 @@ packages/kbn-search-index-documents @elastic/search-kibana
packages/kbn-search-response-warnings @elastic/kibana-data-discovery
packages/kbn-search-types @elastic/kibana-data-discovery
packages/kbn-security-hardening @elastic/kibana-security
packages/kbn-securitysolution-autocomplete @elastic/security-detection-engine
packages/kbn-securitysolution-endpoint-exceptions-common @elastic/security-detection-engine
packages/kbn-securitysolution-es-utils @elastic/security-detection-engine
packages/kbn-securitysolution-exception-list-components @elastic/security-detection-engine
packages/kbn-securitysolution-exceptions-common @elastic/security-detection-engine
packages/kbn-securitysolution-hook-utils @elastic/security-detection-engine
packages/kbn-securitysolution-io-ts-alerting-types @elastic/security-detection-engine
packages/kbn-securitysolution-io-ts-list-types @elastic/security-detection-engine
packages/kbn-securitysolution-io-ts-types @elastic/security-detection-engine
packages/kbn-securitysolution-io-ts-utils @elastic/security-detection-engine
packages/kbn-securitysolution-list-api @elastic/security-detection-engine
packages/kbn-securitysolution-list-constants @elastic/security-detection-engine
packages/kbn-securitysolution-list-hooks @elastic/security-detection-engine
packages/kbn-securitysolution-list-utils @elastic/security-detection-engine
packages/kbn-securitysolution-lists-common @elastic/security-detection-engine
packages/kbn-securitysolution-rules @elastic/security-detection-engine
packages/kbn-securitysolution-t-grid @elastic/security-detection-engine
packages/kbn-securitysolution-utils @elastic/security-detection-engine
packages/kbn-server-http-tools @elastic/kibana-core
packages/kbn-set-map @elastic/kibana-operations
packages/kbn-shared-svg @elastic/obs-ux-infra_services-team
Expand Down Expand Up @@ -615,6 +597,10 @@ src/platform/packages/shared/kbn-management/settings/types @elastic/kibana-manag
src/platform/packages/shared/kbn-management/settings/utilities @elastic/kibana-management
src/platform/packages/shared/kbn-osquery-io-ts-types @elastic/security-asset-management
src/platform/packages/shared/kbn-securitysolution-ecs @elastic/security-threat-hunting-explore
src/platform/packages/shared/kbn-securitysolution-es-utils @elastic/security-detection-engine
src/platform/packages/shared/kbn-securitysolution-io-ts-types @elastic/security-detection-engine
src/platform/packages/shared/kbn-securitysolution-io-ts-utils @elastic/security-detection-engine
src/platform/packages/shared/kbn-securitysolution-rules @elastic/security-detection-engine
src/platform/packages/shared/kbn-server-route-repository @elastic/obs-knowledge-team
src/platform/packages/shared/kbn-server-route-repository-client @elastic/obs-knowledge-team
src/platform/packages/shared/kbn-server-route-repository-utils @elastic/obs-knowledge-team
Expand Down Expand Up @@ -909,7 +895,6 @@ x-pack/plugins/graph @elastic/kibana-visualizations
x-pack/plugins/index_management @elastic/kibana-management
x-pack/plugins/lens @elastic/kibana-visualizations
x-pack/plugins/licensing @elastic/kibana-core
x-pack/plugins/lists @elastic/security-detection-engine
x-pack/plugins/logstash @elastic/logstash
x-pack/plugins/maps @elastic/kibana-presentation
x-pack/plugins/monitoring @elastic/stack-monitoring
Expand Down Expand Up @@ -986,6 +971,20 @@ x-pack/solutions/security/packages/features @elastic/security-threat-hunting-exp
x-pack/solutions/security/packages/index-adapter @elastic/security-threat-hunting
x-pack/solutions/security/packages/kbn-cloud-security-posture/graph @elastic/kibana-cloud-security-posture
x-pack/solutions/security/packages/kbn-cloud-security-posture/public @elastic/kibana-cloud-security-posture
x-pack/solutions/security/packages/kbn-securitysolution-autocomplete @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-endpoint-exceptions-common @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-exception-list-components @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-exceptions-common @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-hook-utils @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-io-ts-alerting-types @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-io-ts-list-types @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-list-api @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-list-constants @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-list-hooks @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-list-utils @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-lists-common @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-t-grid @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-utils @elastic/security-detection-engine
x-pack/solutions/security/packages/navigation @elastic/security-threat-hunting-explore
x-pack/solutions/security/packages/side_nav @elastic/security-threat-hunting-explore
x-pack/solutions/security/packages/storybook/config @elastic/security-threat-hunting-explore
Expand All @@ -996,6 +995,7 @@ x-pack/solutions/security/plugins/cloud_security_posture @elastic/kibana-cloud-s
x-pack/solutions/security/plugins/ecs_data_quality_dashboard @elastic/security-threat-hunting-explore
x-pack/solutions/security/plugins/elastic_assistant @elastic/security-generative-ai
x-pack/solutions/security/plugins/kubernetes_security @elastic/kibana-cloud-security-posture
x-pack/solutions/security/plugins/lists @elastic/security-detection-engine
x-pack/solutions/security/plugins/security_solution @elastic/security-solution
x-pack/solutions/security/plugins/security_solution_ess @elastic/security-solution
x-pack/solutions/security/plugins/security_solution_serverless @elastic/security-solution
Expand Down Expand Up @@ -3354,20 +3354,20 @@ x-pack/solutions/security/packages/kbn-cloud-security-posture/public @elastic/ki
x-pack/solutions/security/packages/data-stream-adapter @elastic/security-threat-hunting
x-pack/solutions/security/packages/expandable-flyout @elastic/security-threat-hunting-investigations
x-pack/solutions/security/packages/index-adapter @elastic/security-threat-hunting
x-pack/solutions/security/packages/kbn-securitysolution-autocomplete @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-endpoint-exceptions-common @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-exception-list-components @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-exceptions-common @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-hook-utils @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-io-ts-alerting-types @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-io-ts-list-types @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-list-api @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-list-constants @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-list-hooks @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-list-utils @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-lists-common @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-t-grid @elastic/security-detection-engine
x-pack/solutions/security/packages/kbn-securitysolution-utils @elastic/security-detection-engine
x-pack/solutions/security/x-pack/solutions/security/packages/kbn-securitysolution-autocomplete @elastic/security-detection-engine
x-pack/solutions/security/x-pack/solutions/security/packages/kbn-securitysolution-endpoint-exceptions-common @elastic/security-detection-engine
x-pack/solutions/security/x-pack/solutions/security/packages/kbn-securitysolution-exception-list-components @elastic/security-detection-engine
x-pack/solutions/security/x-pack/solutions/security/packages/kbn-securitysolution-exceptions-common @elastic/security-detection-engine
x-pack/solutions/security/x-pack/solutions/security/packages/kbn-securitysolution-hook-utils @elastic/security-detection-engine
x-pack/solutions/security/x-pack/solutions/security/packages/kbn-securitysolution-io-ts-alerting-types @elastic/security-detection-engine
x-pack/solutions/security/x-pack/solutions/security/packages/kbn-securitysolution-io-ts-list-types @elastic/security-detection-engine
x-pack/solutions/security/x-pack/solutions/security/packages/kbn-securitysolution-list-api @elastic/security-detection-engine
x-pack/solutions/security/x-pack/solutions/security/packages/kbn-securitysolution-list-constants @elastic/security-detection-engine
x-pack/solutions/security/x-pack/solutions/security/packages/kbn-securitysolution-list-hooks @elastic/security-detection-engine
x-pack/solutions/security/x-pack/solutions/security/packages/kbn-securitysolution-list-utils @elastic/security-detection-engine
x-pack/solutions/security/x-pack/solutions/security/packages/kbn-securitysolution-lists-common @elastic/security-detection-engine
x-pack/solutions/security/x-pack/solutions/security/packages/kbn-securitysolution-t-grid @elastic/security-detection-engine
x-pack/solutions/security/x-pack/solutions/security/packages/kbn-securitysolution-utils @elastic/security-detection-engine
x-pack/solutions/security/packages/navigation @elastic/security-threat-hunting-explore
x-pack/solutions/security/packages/side_nav @elastic/security-threat-hunting-explore
x-pack/solutions/security/packages/upselling @elastic/security-threat-hunting-explore
Expand All @@ -3377,7 +3377,7 @@ x-pack/solutions/security/plugins/cloud_security_posture @elastic/kibana-cloud-s
x-pack/solutions/security/plugins/ecs_data_quality_dashboard @elastic/security-threat-hunting-explore
x-pack/solutions/security/plugins/elastic_assistant @elastic/security-generative-ai
x-pack/solutions/security/plugins/kubernetes_security @elastic/kibana-cloud-security-posture
x-pack/solutions/security/plugins/lists @elastic/security-detection-engine
x-pack/solutions/security/solutions/security/plugins/lists @elastic/security-detection-engine
x-pack/solutions/security/solutions/security/plugins/security_solution @elastic/security-solution
x-pack/solutions/security/solutions/security/plugins/security_solution_ess @elastic/security-solution
x-pack/solutions/security/solutions/security/plugins/security_solution_serverless @elastic/security-solution
Expand Down
4 changes: 2 additions & 2 deletions .github/codeql/codeql-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ paths-ignore:
- x-pack/solutions/security/plugins/elastic_assistant/scripts
- x-pack/plugins/event_log/scripts
- x-pack/plugins/fleet/scripts
- x-pack/plugins/lists/scripts
- x-pack/plugins/lists/server/scripts
- x-pack/solutions/security/plugins/lists/scripts
- x-pack/solutions/security/plugins/lists/server/scripts
- x-pack/plugins/observability_solution/*/scripts
- x-pack/platform/plugins/shared/osquery/scripts
- x-pack/plugins/rule_registry/scripts
Expand Down
Loading
Loading