Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-cloud-security-posture` #202862

gsoldevila · 2024-12-04T01:04:14Z

Summary

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.

Important

We kindly ask you to:
- Manually fix the errors in the error section below (if there are any).
- Search for the packages[\/\\] and plugins[\/\\] patterns in the source code (Babel and Eslint config files), and update them appropriately.
- Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names
- Review all of the updated files, specially the .ts and .js files listed in the sections below, as some of them contain relative paths that have been updated.
- Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.:
  - customised eslint rules
  - docs pointing to source code

Note

This PR has been auto-generated.
Any manual contributions will be lost if the 'relocate' script is re-run.
Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash.
Please use #sustainable_kibana_architecture Slack channel for feedback.

5 plugin(s) are going to be relocated:

Id	Target folder
`@kbn/asset-inventory-plugin`	`x-pack/solutions/security/plugins/asset_inventory`
`@kbn/cloud-defend-plugin`	`x-pack/solutions/security/plugins/cloud_defend`
`@kbn/cloud-security-posture-plugin`	`x-pack/solutions/security/plugins/cloud_security_posture`
`@kbn/kubernetes-security-plugin`	`x-pack/solutions/security/plugins/kubernetes_security`
`@kbn/session-view-plugin`	`x-pack/solutions/security/plugins/session_view`

4 packages(s) are going to be relocated:

Id	Target folder
`@kbn/cloud-security-posture`	`x-pack/solutions/security/packages/kbn-cloud-security-posture/public`
`@kbn/cloud-security-posture-common`	`x-pack/platform/packages/shared/kbn-cloud-security-posture/common`
`@kbn/cloud-security-posture-graph`	`x-pack/solutions/security/packages/kbn-cloud-security-posture/graph`
`@kbn/security-solution-distribution-bar`	`x-pack/solutions/security/packages/distribution_bar`

Updated references

./.eslintrc.js
./.github/codeql/codeql-config.yml
./docs/developer/plugin-list.asciidoc
./package.json
./packages/deeplinks/security/deep_links.ts
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./tsconfig.base.json
./tsconfig.base.type_check.json
./tsconfig.refs.json
./x-pack/.i18nrc.json
./x-pack/platform/packages/shared/kbn-cloud-security-posture/common/README.md
./x-pack/platform/packages/shared/kbn-cloud-security-posture/common/jest.config.js
./x-pack/plugins/security_solution/tsconfig.type_check.json
./x-pack/solutions/security/packages/kbn-cloud-security-posture/graph/jest.config.js
./x-pack/solutions/security/packages/kbn-cloud-security-posture/public/jest.config.js
./x-pack/solutions/security/plugins/cloud_defend/README.md
./x-pack/solutions/security/plugins/cloud_defend/jest.config.js
./x-pack/solutions/security/plugins/cloud_defend/server/lib/telemetry/collectors/types.ts
./x-pack/solutions/security/plugins/cloud_security_posture/README.md
./x-pack/solutions/security/plugins/cloud_security_posture/common/dev_docs/__auto_generated_csp_requirements_test_coverage.md
./x-pack/solutions/security/plugins/cloud_security_posture/common/scripts/__auto_generated_csp_test_log.json
./x-pack/solutions/security/plugins/cloud_security_posture/common/scripts/get_tests.js
./x-pack/solutions/security/plugins/cloud_security_posture/jest.config.js
./x-pack/solutions/security/plugins/kubernetes_security/jest.config.js
./x-pack/solutions/security/plugins/session_view/README.md
./x-pack/solutions/security/plugins/session_view/jest.config.js
./x-pack/test/tsconfig.type_check.json
./x-pack/test_serverless/tsconfig.type_check.json
./yarn.lock

Updated relative paths

x-pack/platform/packages/shared/kbn-cloud-security-posture/common/jest.config.js:10
x-pack/platform/packages/shared/kbn-cloud-security-posture/common/tsconfig.json:2
x-pack/solutions/security/packages/kbn-cloud-security-posture/graph/jest.config.js:11
x-pack/solutions/security/packages/kbn-cloud-security-posture/graph/tsconfig.json:2
x-pack/solutions/security/packages/kbn-cloud-security-posture/public/jest.config.js:10
x-pack/solutions/security/packages/kbn-cloud-security-posture/public/tsconfig.json:2
x-pack/solutions/security/plugins/asset_inventory/tsconfig.json:14
x-pack/solutions/security/plugins/asset_inventory/tsconfig.json:2
x-pack/solutions/security/plugins/cloud_defend/jest.config.js:11
x-pack/solutions/security/plugins/cloud_defend/tsconfig.json:10
x-pack/solutions/security/plugins/cloud_defend/tsconfig.json:2
x-pack/solutions/security/plugins/cloud_security_posture/README.md:18
x-pack/solutions/security/plugins/cloud_security_posture/README.md:19
x-pack/solutions/security/plugins/cloud_security_posture/README.md:20
x-pack/solutions/security/plugins/cloud_security_posture/README.md:21
x-pack/solutions/security/plugins/cloud_security_posture/README.md:22
x-pack/solutions/security/plugins/cloud_security_posture/README.md:23
x-pack/solutions/security/plugins/cloud_security_posture/jest.config.js:11
x-pack/solutions/security/plugins/cloud_security_posture/tsconfig.json:14
x-pack/solutions/security/plugins/cloud_security_posture/tsconfig.json:2
x-pack/solutions/security/plugins/kubernetes_security/jest.config.js:10
x-pack/solutions/security/plugins/kubernetes_security/package.json:8
x-pack/solutions/security/plugins/kubernetes_security/package.json:9
x-pack/solutions/security/plugins/kubernetes_security/tsconfig.json:15
x-pack/solutions/security/plugins/kubernetes_security/tsconfig.json:2
x-pack/solutions/security/plugins/session_view/jest.config.js:10
x-pack/solutions/security/plugins/session_view/package.json:8
x-pack/solutions/security/plugins/session_view/package.json:9
x-pack/solutions/security/plugins/session_view/tsconfig.json:15
x-pack/solutions/security/plugins/session_view/tsconfig.json:2

github-actions · 2024-12-04T01:04:30Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

elasticmachine · 2024-12-04T08:21:15Z

Pinging @elastic/kibana-core (Team:Core)

elasticmachine · 2024-12-04T08:21:16Z

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine · 2024-12-04T08:21:17Z

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

seanrathier

Did a quick check for CSPM plugin and it works.
Fixed linting errors in CI

However, the CI is failing on unused i18n translations but they are in fact used

gsoldevila · 2024-12-09T16:43:24Z

Did a quick check for CSPM plugin and it works. Fixed linting errors in CI

However, the CI is failing on unused i18n translations but they are in fact used

Thanks for the contributions! The i18n issue might be caused by outdated paths in .i18nrc.json. Checking . . .

gsoldevila · 2024-12-09T16:49:59Z

This is outdated https://github.com/gsoldevila/kibana/blob/ed9d2d34dabeee93af1479e845ff27d73fcd3942/x-pack/.i18nrc.json#L26

kc13greiner

code ql config changes LGTM!

seanrathier

Fixed lint errors. Thanks!

stephmilovic

Security solutions changes LGTM!

seanrathier · 2024-12-12T19:48:29Z

I needed to run the relocate script again to fix conflicts.

…na-cloud-security-posture` (elastic#202862) (cherry picked from commit f508ad2) # Conflicts: # .github/CODEOWNERS # .github/codeql/codeql-config.yml # package.json # tsconfig.base.json

seanrathier · 2024-12-16T19:39:04Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…na-cloud-security-posture` (elastic#202862) (cherry picked from commit f508ad2) # Conflicts: # .github/CODEOWNERS # .github/codeql/codeql-config.yml # package.json # tsconfig.base.json

seanrathier · 2024-12-16T19:57:16Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…na-cloud-security-posture` (elastic#202862) (cherry picked from commit f508ad2) # Conflicts: # .github/CODEOWNERS # .github/codeql/codeql-config.yml # package.json # tsconfig.base.json

seanrathier · 2024-12-16T20:36:41Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

seanrathier · 2024-12-17T16:09:38Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…na-cloud-security-posture` (elastic#202862) (cherry picked from commit f508ad2) # Conflicts: # .github/CODEOWNERS

kibanamachine · 2024-12-17T18:48:53Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

…na-cloud-security-posture` (elastic#202862) (cherry picked from commit f508ad2) # Conflicts: # .buildkite/scripts/pipelines/pull_request/pipeline.ts # .github/CODEOWNERS # x-pack/.i18nrc.json # x-pack/plugins/telemetry_collection_xpack/schema/xpack_security.json

seanrathier · 2024-12-17T20:12:43Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…na-cloud-security-posture` (elastic#202862) (cherry picked from commit f508ad2) # Conflicts: # .buildkite/scripts/pipelines/pull_request/pipeline.ts # .github/CODEOWNERS # x-pack/.i18nrc.json # x-pack/plugins/telemetry_collection_xpack/schema/xpack_security.json

seanrathier · 2024-12-17T20:55:31Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…c/kibana-cloud-security-posture` (#202862) (#204474) # Backport This will backport the following commits from `main` to `8.x`: - [Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-cloud-security-posture` (#202862)](#202862)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  --------- Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

…r Kibana sustainability (#204500) ## Summary Move @kbn/cloud-security-posture-storybook-config package to `x-pack/solutions/security/packages/kbn-cloud-security-posture/.storybook` Renamed removed the `config` folder to align with the `.storybook` [naming convention](https://github.com/elastic/kibana/pull/204500/files#diff-91918a63f6365a8f40f674ab54a8df7ce9aeb313f77fe8eda76284d712ef5425R21). ![Screenshot 2024-12-16 at 5 50 53 PM](https://github.com/user-attachments/assets/de1d0a81-353f-434c-bb2d-989210b35b43) ### Related Issues - #202862 --------- Co-authored-by: Brad White <Ikuni17@users.noreply.github.com>

…r Kibana sustainability (elastic#204500) ## Summary Move @kbn/cloud-security-posture-storybook-config package to `x-pack/solutions/security/packages/kbn-cloud-security-posture/.storybook` Renamed removed the `config` folder to align with the `.storybook` [naming convention](https://github.com/elastic/kibana/pull/204500/files#diff-91918a63f6365a8f40f674ab54a8df7ce9aeb313f77fe8eda76284d712ef5425R21). ![Screenshot 2024-12-16 at 5 50 53 PM](https://github.com/user-attachments/assets/de1d0a81-353f-434c-bb2d-989210b35b43) ### Related Issues - elastic#202862 --------- Co-authored-by: Brad White <Ikuni17@users.noreply.github.com> (cherry picked from commit d6cb398)

## Summary Clean-up all "Asset Inventory" plugin code from the `8.x` branch. ### Motivation It was decided in the weekly meetings not to backport any work related to Asset Inventory because it's a new feature. However, this decision was made after I had already shipped the first PR that introduced all the minimal required boilerplate: - #202291 which was backported with: - #202827 I couldn't auto revert the merge commit because of this refactor PR that was merged in between: - #202862 So I'm deleting and reverting each change manually. ### Checklist - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Risks No risk at all.

…na-cloud-security-posture` (elastic#202862)

…r Kibana sustainability (elastic#204500) ## Summary Move @kbn/cloud-security-posture-storybook-config package to `x-pack/solutions/security/packages/kbn-cloud-security-posture/.storybook` Renamed removed the `config` folder to align with the `.storybook` [naming convention](https://github.com/elastic/kibana/pull/204500/files#diff-91918a63f6365a8f40f674ab54a8df7ce9aeb313f77fe8eda76284d712ef5425R21). ![Screenshot 2024-12-16 at 5 50 53 PM](https://github.com/user-attachments/assets/de1d0a81-353f-434c-bb2d-989210b35b43) ### Related Issues - elastic#202862 --------- Co-authored-by: Brad White <Ikuni17@users.noreply.github.com>

gsoldevila marked this pull request as ready for review December 4, 2024 08:21

gsoldevila requested review from a team as code owners December 4, 2024 08:21

gsoldevila force-pushed the kbn-team-1309-move-kibana-cloud-security-posture branch 3 times, most recently from f78242c to 8544578 Compare December 9, 2024 11:48

gsoldevila requested a review from a team as a code owner December 9, 2024 11:48

kc13greiner self-requested a review December 9, 2024 13:07

seanrathier reviewed Dec 9, 2024

View reviewed changes

kc13greiner approved these changes Dec 9, 2024

View reviewed changes

rudolf approved these changes Dec 9, 2024

View reviewed changes

seanrathier approved these changes Dec 9, 2024

View reviewed changes

stephmilovic approved these changes Dec 10, 2024

View reviewed changes

Ikuni17 approved these changes Dec 11, 2024

View reviewed changes

seanrathier force-pushed the kbn-team-1309-move-kibana-cloud-security-posture branch from 61f8c78 to 949e653 Compare December 12, 2024 19:46

seanrathier added the ci:cloud-deploy Create or update a Cloud deployment label Dec 12, 2024

kibanamachine mentioned this pull request Dec 16, 2024

[ingest pipeline mgmt] Move to x-pack/platform/plugins/shared/ingest_pipelines #204331

Merged

seanrathier mentioned this pull request Dec 16, 2024

[Cloud Security] Move @kbn/cloud-security-posture-storybook-config for Kibana sustainability #204500

Merged

seanrathier self-assigned this Dec 16, 2024

kibanamachine mentioned this pull request Dec 17, 2024

[Security Solution][SIEM migrations] Onboarding UI improvements #204320

Merged

albertoblaz mentioned this pull request Dec 17, 2024

[8.x] Revert backported AssetInventory plugin (revert #202827) #204641

Merged

2 tasks

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 17, 2024

kibanamachine mentioned this pull request Dec 17, 2024

Sustainable Kibana Architecture: Move modules owned by @elastic/security-detection-engine #202844

Merged

kibanamachine added v8.18.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Dec 18, 2024

rudolf added the plugin groups Relocate all plugins and packages under their respective platform/solution groups label Dec 18, 2024

JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024

Sustainable Kibana Architecture: Move modules owned by `@elastic/kiba…

5eba7cb

…na-cloud-security-posture` (elastic#202862)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-cloud-security-posture` #202862

Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-cloud-security-posture` #202862

gsoldevila commented Dec 4, 2024 •

edited by kibanamachine

Loading

github-actions bot commented Dec 4, 2024

elasticmachine commented Dec 4, 2024

elasticmachine commented Dec 4, 2024

elasticmachine commented Dec 4, 2024

seanrathier left a comment

gsoldevila commented Dec 9, 2024

gsoldevila commented Dec 9, 2024

kc13greiner left a comment

seanrathier left a comment

stephmilovic left a comment

seanrathier commented Dec 12, 2024

seanrathier commented Dec 16, 2024

seanrathier commented Dec 16, 2024

seanrathier commented Dec 16, 2024

seanrathier commented Dec 17, 2024

kibanamachine commented Dec 17, 2024

seanrathier commented Dec 17, 2024

seanrathier commented Dec 17, 2024

Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-cloud-security-posture #202862

Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-cloud-security-posture #202862

Conversation

gsoldevila commented Dec 4, 2024 • edited by kibanamachine Loading

Summary

5 plugin(s) are going to be relocated:

4 packages(s) are going to be relocated:

github-actions bot commented Dec 4, 2024

elasticmachine commented Dec 4, 2024

elasticmachine commented Dec 4, 2024

elasticmachine commented Dec 4, 2024

seanrathier left a comment

Choose a reason for hiding this comment

gsoldevila commented Dec 9, 2024

gsoldevila commented Dec 9, 2024

kc13greiner left a comment

Choose a reason for hiding this comment

seanrathier left a comment

Choose a reason for hiding this comment

stephmilovic left a comment

Choose a reason for hiding this comment

seanrathier commented Dec 12, 2024

seanrathier commented Dec 16, 2024

💚 All backports created successfully

Questions ?

seanrathier commented Dec 16, 2024

💚 All backports created successfully

Questions ?

seanrathier commented Dec 16, 2024

💚 All backports created successfully

Questions ?

seanrathier commented Dec 17, 2024

💚 All backports created successfully

Questions ?

kibanamachine commented Dec 17, 2024

seanrathier commented Dec 17, 2024

💚 All backports created successfully

Questions ?

seanrathier commented Dec 17, 2024

💚 All backports created successfully

Questions ?

Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-cloud-security-posture` #202862

Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-cloud-security-posture` #202862

gsoldevila commented Dec 4, 2024 •

edited by kibanamachine

Loading